doubleconversion: update to the new module system

ThirdParty/doubleconversion/CMakeLists.txt

-vtk_module_third_party(doubleconversion
-  PACKAGE double-conversion
-  INCLUDE_DIRS
-    ${CMAKE_CURRENT_SOURCE_DIR}/vtkdoubleconversion
-    ${CMAKE_CURRENT_BINARY_DIR}/vtkdoubleconversion)
+vtk_module_third_party(
+  INTERNAL
+    LICENSE_FILES "vtkdoubleconversion/COPYING"
+                  "vtkdoubleconversion/LICENSE"
+    VERSION       "3.1.1"
+    STANDARD_INCLUDE_DIRS
+  EXTERNAL
+    PACKAGE double-conversion
+    TARGETS double-conversion::double-conversion
+    STANDARD_INCLUDE_DIRS)
+
+configure_file(
+  "${CMAKE_CURRENT_SOURCE_DIR}/vtk_doubleconversion.h.in"
+  "${CMAKE_CURRENT_BINARY_DIR}/vtk_doubleconversion.h")
+
+vtk_module_install_headers(
+  FILES "${CMAKE_CURRENT_BINARY_DIR}/vtk_doubleconversion.h")

ThirdParty/doubleconversion/module.cmake

-vtk_module(vtkdoubleconversion
-  EXCLUDE_FROM_WRAPPING
-)

ThirdParty/doubleconversion/update.sh

@@ -8,9 +8,10 @@ readonly name="doubleconversion"
 readonly ownership="double-conversion Upstream <kwrobot@kitware.com>"
 readonly subtree="ThirdParty/$name/vtk$name"
 readonly repo="https://gitlab.kitware.com/third-party/double-conversion.git"
-readonly tag="for/vtk"
+readonly tag="for/vtk-20181025-3.1.1"
 readonly paths="
 AUTHORS
+Changelog
 CMakeLists.vtk.txt
 COPYING
 double-conversion/

ThirdParty/doubleconversion/vtk.module

+NAME
+  VTK::doubleconversion
+LIBRARY_NAME
+  vtkdoubleconversion
+THIRD_PARTY

ThirdParty/doubleconversion/vtk_doubleconversion.h.in

@@ -15,13 +15,13 @@
 #ifndef vtk_doubleconversion_h
 #define vtk_doubleconversion_h
 
-#cmakedefine VTK_USE_SYSTEM_DOUBLECONVERSION
+/* Use the doubleconversion library configured for VTK.  */
+#cmakedefine01 VTK_MODULE_USE_EXTERNAL_vtkdoubleconversion
 
-#ifndef VTK_USE_SYSTEM_DOUBLECONVERSION
-#define VTK_DOUBLECONVERSION_QUOTE_HEADER_NAME(str) #str
-#  define VTK_DOUBLECONVERSION_HEADER(header) VTK_DOUBLECONVERSION_QUOTE_HEADER_NAME(vtkdoubleconversion/double-conversion/header)
+#if VTK_MODULE_USE_EXTERNAL_vtkdoubleconversion
+# define VTK_DOUBLECONVERSION_HEADER(header) <header>
 #else
-#  define VTK_DOUBLECONVERSION_HEADER(header) #header
+# define VTK_DOUBLECONVERSION_HEADER(header) <vtkdoubleconversion/double-conversion/header>
 #endif
 
 #endif