Skip to content
Snippets Groups Projects
  1. Nov 08, 2022
  2. Nov 07, 2022
    • Michael Hirsch's avatar
      Find{BZip2,LibLZMA,ZLIB}: use *_VERSION as modern CMake · 9e3f1723
      Michael Hirsch authored and Brad King's avatar Brad King committed
      The old *_VERSION_STRING is silently left set for backward compat.
      9e3f1723
    • Brad King's avatar
      cmState: Clarify name of member tracking the active scope in a directory · 96ddcbee
      Brad King authored
      The `DirectoryEnd` member added by commit 52dbe654 (cmState: Record
      the end position of each directory., 2015-08-01, v3.4.0-rc1~251^2~1)
      actually tracks the current top-most scope in a directory's stack.  This
      is evidenced by the use case in commit 3f4e5e8c (cmState: Return end
      snapshot for GetBuildsystemDirectoryParent., 2015-09-01,
      v3.4.0-rc1~100^2~1).  Rename the member to `CurrentScope` to clarify
      this role.
      96ddcbee
    • Brad King's avatar
      block: Fix variable scope protection from modification by subdirectories · cb53d930
      Brad King authored
      When `cmStateSnapshot::RaiseScope` raises a variable in to a parent
      directory scope, it uses `GetBuildsystemDirectoryParent` to find the
      current top-most scope on the directory's stack.  Since commit 3f4e5e8c
      (cmState: Return end snapshot for GetBuildsystemDirectoryParent.,
      2015-09-01, v3.4.0-rc1~100^2~1), that depends on the `DirectoryEnd`
      field in the directory's state.  However, when variable-only scopes were
      added by commit 6954c893 (cmState: Add a VariableScope snapshot type.,
      2015-08-01, v3.4.0-rc1~179^2~1), we neglected to account for the
      addition of that field by commit 52dbe654 (cmState: Record the end
      position of each directory., 2015-08-01, v3.4.0-rc1~251^2~1).
      
      Prior to commit 44a2f3f3 (Add new flow-control commands for variables
      and policies scopes management, 2022-08-05, v3.25.0-rc1~257^2) this
      problem went unnoticed because there was no way to have a variable scope
      at the top of a directory's stack while processing a subdirectory. Now
      the `block()/endblock()` commands enable the behavior, so fix tracking
      of a variable scope as the top-most scope in a directory.
      
      Fixes: #24138
      cb53d930
    • Kyle Edwards's avatar
      clang-tidy: disable bespoke enum class check · 5f97772f
      Kyle Edwards authored
      CMake is not remotely ready for this yet...
      5f97772f
    • Sean Orner's avatar
Loading