Skip to content

Reorganize vtkPVApplicationOptions

Christos Tsolakis requested to merge christos.tsolakis/paraview:reorganize-options into master

Consider the current GetOptions() API:

  • vtkPVApplicationOptions* vtkPVCoreApplication::GetOptions()
  • vtkPVApplicationOptions* vtkPVApplication::GetOptions()
  • vtkPVServerOptions* vtkPVServerApplication::GetOptions()
  • vtkPVGUIOptions* vtkPVGUIApplication::GetOptions()

vtkPVApplicationOptions defines a basic set of options which is expanded in vtkPVServerOptions and vtkPVGUIOptions for each application type which is great. However, vtkPVGUIOptions has nothing GUI specific (sets test directories and server-url for client/server connections) and although it is in pq/Core module it has no Qt dependencies.

This MR renames vtkPVApplicationOptions -> vtkPVCoreApplicationOptions and vtkPVGUIOptions -> vtkPVApplicationOptions this allows to:

  • Keep shared application options as before.
  • Provides client-specific options like server-url to all tests
  • Keeps server-specific options as before.
  • Move non-gui options out of pqCore module.

As an example PTS* tests are updated so they can run both with the builtin session and a remote server with minimal changes:

> ./bin/pvserver
....
Accepting connection: cs://<ip>:33333

> ./bin/vtkRemotingApplicationCxxTests TestPTSPipelineBuilderWithRendering --server-url cs://<ip>:33333

@jaswant.panchumarti this should allow to check remote rendering on MacOS with no need of Qt or the parat client.

Merge request reports