Skip to content
Snippets Groups Projects
  1. Nov 02, 2016
    • Brad King's avatar
      Features: Add meta-features requesting awareness of a particular standard · b0996a3f
      Brad King authored
      A common use case of `target_compile_features` is simply to specify that
      the compiler should be run in a mode that is aware of e.g. C++11.  Some
      projects simply specify a particular C++11-only feature to request this.
      Provide a first-class way to do this by naming features after the
      corresponding language standard.  Record them as always available in the
      corresponding standard level so that requesting them always ensures that
      standard (or higher) is used.
      b0996a3f
  2. Oct 28, 2016
  3. Oct 27, 2016
  4. Oct 25, 2016
    • Alex Wang's avatar
      Features: Fix cxx_right_angle_brackets compiler feature test · 68e7250a
      Alex Wang authored and Brad King's avatar Brad King committed
      The clang-format pass in commit v3.6.0-rc1~54^2~1 (Revise C++ coding
      style using clang-format, 2016-05-16) changed the template right angle
      brackets from `>>` to `> >`, which defeats the purpose of this test.
      Change it back and exclude this content from formatting.
      68e7250a
  5. Oct 24, 2016
    • Brad King's avatar
      cmake-server: Change message wrapper to avoid ambiguity with content · 9b8dc79c
      Brad King authored
      Change our message wrapper from
      
          [== CMake Server ==[ ... ]== CMake Server ==]
      
      to
      
          [== "CMake Server" ==[ ... ]== "CMake Server" ==]
      
      to guarantee that no JSON content can ever contain the ending string
      (because it would be encoded as `]== \"CMake Server\" ==]`).
      9b8dc79c
    • Alexis Murzeau's avatar
      Ninja: Use binary dir for `$subdir/all` targets · e983bd32
      Alexis Murzeau authored and Brad King's avatar Brad King committed
      The targets added by commit v3.6.0-rc1~240^2~2 (Ninja: Add `$subdir/all`
      targets, 2016-03-11) use as `$subdir` the relative path from the top of
      the source tree to the current source directory.  This is not correct
      when using `add_subdirectory(test test_bin)`.  Instead we need to use
      the relative path from the top of the binary tree to the current binary
      directory as was done for related targets by commit v3.7.0-rc1~268^2
      (Ninja: Add `$subdir/{test,install,package}` targets, 2016-08-05).
      e983bd32
    • Alexis Murzeau's avatar
      Ninja: Use binary dir for `$subdir/all` targets · 42db2ebc
      Alexis Murzeau authored and Brad King's avatar Brad King committed
      The targets added by commit v3.6.0-rc1~240^2~2 (Ninja: Add `$subdir/all`
      targets, 2016-03-11) use as `$subdir` the relative path from the top of
      the source tree to the current source directory.  This is not correct
      when using `add_subdirectory(test test_bin)`.  Instead we need to use
      the relative path from the top of the binary tree to the current binary
      directory as was done for related targets by commit v3.7.0-rc1~268^2
      (Ninja: Add `$subdir/{test,install,package}` targets, 2016-08-05).
      42db2ebc
  6. Oct 21, 2016
  7. Oct 20, 2016
  8. Oct 18, 2016
  9. Oct 17, 2016
  10. Oct 16, 2016
    • Stephen Kelly's avatar
      cmTarget: Move sanity checks and computed property access to callers · c3fb0d95
      Stephen Kelly authored
      The GetProperty method is now just accessing contained data, meaning it
      can be implemented in cmState.
      
      Remove the cmMakefile context from the signature as a result and remove
      the overload with the same signature.
      
      Add a GetComputedProperty to cmTarget so that templates can be properly
      instantiated.  Otherwise the Commands would need to be able to reach the
      specializations which are currently in cmTarget.cxx.
      
      As a side-effect, the CMP0026 warning now gives a backtrace to the
      target when issued from a generator expression.
      c3fb0d95
  11. Oct 14, 2016
  12. Oct 13, 2016
    • Brad King's avatar
      Ninja: Fix POST_BUILD commands on macOS Frameworks · 20278872
      Brad King authored
      The condition added by commit v2.8.12~179^2 (OS X: Fix regression
      handling frameworks for Ninja, 2013-07-16) for excluding use of
      versioning symlinks on macOS Frameworks must match that used for
      POST_BUILD selection.  Otherwise we place the POST_BUILD commands after
      a symlink step that is never added.
      
      Closes: #16363
      20278872
  13. Oct 10, 2016
  14. Oct 07, 2016
  15. Oct 06, 2016
    • Brad King's avatar
      Android: Suppress -Wattributes warnings in test case builds · ebef3632
      Brad King authored
      We use `-Werror` in the Android test builds to make sure there are
      no warnings that we care about (e.g. unused flags).  However, the
      NDK r13 tools produce a warning about their own builtins:
      
      ```
      <built-in>: In function 'float abs(float)':
      <built-in>: warning: conflicts with previous declaration here [-Wattributes]
      ```
      
      Suppress this warning so that we can continue using `-Werror` but
      tolerate these warnings.
      ebef3632
  16. Oct 03, 2016
  17. Sep 30, 2016
  18. Sep 29, 2016
  19. Sep 28, 2016
    • Matthew Woehlke's avatar
      cmake_parse_arguments: Add additional unit tests · 66c70cd9
      Matthew Woehlke authored
      Add additional unit tests for some corner cases in argument splitting.
      66c70cd9
    • Matthew Woehlke's avatar
      cmake_parse_arguments: Fix PARSE_ARGV multi-value argument handling · 41291b20
      Matthew Woehlke authored and Brad King's avatar Brad King committed
      The `PARSE_ARGV` mode was recently added to help functions properly
      parse their arguments even when those arguments may be quoted and
      contain literal `;` in their values.  Fix the implementation to encode
      `;`s in reported multi-value arguments and in `UNPARSED_ARGUMENTS` so
      that `;`s in the individual values are preserved in the lists.  This
      allows clients to access all their argument values correctly.
      41291b20
    • Tobias Hunger's avatar
      server-mode: Add project data for unit tests · 71a50587
      Tobias Hunger authored
      Do some basic unit tests for "codemodel", "cmakeInputs" and "cache"
      commands of the cmake server.
      
      This just calls the commands right now and makes sure the server
      thinks it can reply to the request. The data itself is currently not
      validated.
      71a50587
    • Brad King's avatar
      project: Fix support for explicit RC language · 9c5238df
      Brad King authored
      The check added in commit v3.6.0-rc1~293^2 (Diagnose recursive
      project/enable_language without crashing, 2016-03-07) broke support for
      enabling `RC` explicitly along with other languages like `C`.  The
      reason is that we enable all listed languages at once so the internal
      `enable_language(RC)` that we do while enabling `C` or `CXX` on some
      platforms triggers the recursion check if `RC` is explicitly listed.
      
      Ideally we should refactor things to only enable one language at a time,
      but for now it is simplest to just exclude `RC` from the explicit list
      until other languages are enabled, and then enable it.
      
      Closes: #16330
      9c5238df
Loading