- May 31, 2019
-
- May 30, 2019
-
-
Brad King authored
Merge-request: !3388
-
Avoid listing the same input more than once in custom commands generated in `.vcxproj` and `.csproj` files. In the case of a `.vcxproj` file additionally avoid listing the source to which the command is attached since it is already implicitly a dependency. This is a nice cleanup and also works around a VS 2019 16.1 regression in MSBuild dependency checking. Starting with that version, MSBuild now re-builds custom commands when the list of dependencies has changed. However, its check is confused by duplicate dependencies. De-duplicating them avoids this problem. Co-Author: Brad King <brad.king@kitware.com> Fixes: #19303
-
-
Brad King authored
-
Brad King authored
Merge-request: !3395
-
Brad King authored
Entries of the `CPATH` environment variable are implicitly searched as include directories by some C/C++ compilers. Since commit 5990ecb7 (Compute implicit include directories from compiler output, 2018-12-07, v3.14.0-rc1~108^2) these entries are detected by CMake and included in the `CMAKE_{C,CXX}_IMPLICIT_INCLUDE_DIRECTORIES` variables. However, we should not exclude them from explicit specification via `-I` or particularly `-isystem` because they are meant as user-specified include directories that can be re-ordered without breaking compiler builtin headers. In particular, we need explicit requests via `include_directories` with the `SYSTEM` option to result in `-isystem` so that third-party headers do not produce warnings. Co-Author: Ben Boeckel <ben.boeckel@kitware.com> Fixes: #19291
-
- May 28, 2019
-
-
Brad King authored
Merge-request: !3391
-
- May 24, 2019
-
-
Brad King authored
Merge-request: !3368
-
-
- May 21, 2019
- May 14, 2019
- May 13, 2019
- May 11, 2019
-
-
Gregor Jasny authored
Closes: #19172
-
- May 06, 2019
-
-
Brad King authored
Merge-request: !3283
-
Brad King authored
Merge-request: !3287
-
Brad King authored
Merge-request: !3272
-
When building for iOS, the compiled target is placed into a bundle. If a single-configuration generator is used, like Makefiles or Ninja, the try_compile FILE_COPY behavior fails to find the bundle, because it only looks for the bundle inside a Debug subfolder (presumably to support a multi-configuration generator like Xcode). Consider looking for the bundle in the root try_compile folder, as well as in the location specified by CMAKE_TRY_COMPILE_CONFIGURATION. Closes: #19211
-
- May 05, 2019
-
-
Gregor Jasny authored
On macOS ranlib truncates the fractional part of the static achive file modification time. If the archive and at least one contained object file were created within the same second this will make look the archive older than the object file. On subsequent ninja runs this leads to re-achiving and updating dependent targets. As a work-around we touch the archive after ranlib. Closes: #19222
-
Marc Chevrier authored
-
- Apr 30, 2019
-
-
Brad King authored
Merge-request: !3274
-
Brad King authored
Merge-request: !3266
-
-
Remove the 1.67 upper-bound on compiler feature computation so that with newer versions we at least get it mostly right. Leave a comment with notes about updating features for future versions.
-
Brad King authored
Merge-request: !3276
-
Brad King authored
Merge-request: !3276
-
Brad King authored
In commit a1ad0a69 (target_link_libraries: Allow use with targets in other directories, 2018-09-07, v3.13.0-rc1~94^2) we accidentally broke the logic that adds `$<LINK_ONLY:...>` to private dependencies of static libraries in their `INTERFACE_LINK_LIBRARIES` in the case that the dependency is added from outside the directory creating the library. The check for a valid target name should apply to the original name specified by the caller and not the encoded cross-directory reference. Fixes: #19197
-
Marc Chevrier authored
-
- Apr 22, 2019
-
-
Brad King authored
Merge-request: !3254
- Apr 19, 2019
-
-
Brad King authored
Merge-request: !3246
-