Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

VTK no longer supports any compilers that do not provide this type.
Therefore all code conditional on VTK_TYPE_USE_LONG_LONG can be made
unconditional.  Leave the macro defined to tell dependent projects that
APIs using the type are available in case they still support versions of
VTK that make it conditional.

VTK no longer supports any compilers that have `__int64` but not a
`long` or `long long` that is 64-bit.  Therefore all code that is
conditional on VTK_TYPE_USE___INT64 is never used and can be dropped.

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

Change-Id: I76848acf2f0939f63df6c3194b302eebd6a68009

This will allow kits to gather all of the required libraries to link
since the modules themselves won't "exist" to link anything when kits
are enabled.

Change-Id: Ic73220c7b97e17a5fbc0aa6c0f7a5e5a61dc6bef

Change-Id: I10a54acbd076e055d8071414f2fff1ebafe1653d

CMake 2.8.12 introduces policies CMP0022 and CMP0023 that trigger
warnings in some of VTK's CMake code.  Fix them as follows.  The result
is a cleaner and more explicit link specification anyway.

CMP0022 warns when we set the LINK_INTERFACE_LIBRARIES property directly
without also setting the newly introduced INTERFACE_LINK_LIBRARIES
property directly.  Simply drop these settings because they are achieved
already by use of the keyword-based target_link_libraries signature.

CMP0023 warns when we use both the plain and keyword signatures of the
target_link_libraries command for a single target.  The module macros
use the keyword signature (LINK_PUBLIC/LINK_PRIVATE), so any direct
calls to the plain target_link_libraries signature are doing "private"
linking.  Add the LINK_PRIVATE keyword to such calls to make this
explicit and avoid the warning.

Change-Id: I1e5bf687733e3f19462da698c0d5e3899439bf02

Oops!  I left a couple of debugging messages in the serialize/
deserialize code.  Fixed.

Change-Id: I6e3c09075e4a59df02ad92f17f09ee874be0313e

I modified Infovis/Boost/Testing/Cxx/TestVariantSerialization to
exercise the serialize/deserialize code for vtkUnicodeString.  The
test string is UTF-16 in the file and gets converted to and from UTF-8.

Change-Id: I3a5bb966832d972e7e926aa88ebc8d3d16a59d8d

I need to be able to save and restore vtkVariants containing a
vtkUnicodeString.  To do this I rely on vtkUnicodeString::utf8_str
and vtkUnicodeString::from_utf8 to convert to/from a friendlier
representation.

Change-Id: Icbe9d559e323636a805de21a7e0d0961abc7d94c

They must export their basic information.

Change-Id: Id3556580d8233b99d34aa06224b7f84c7ad7b584

List headers needed to build the Testing/External project against the
install tree.

Change-Id: I927e433500395bb18dcb02f2c235b3486a6aa1e0

Add a comment to the bottom of each header that used to be excluded from
kit HeaderTesting tests in monolithic VTK.  Format the comment in a way
that cannot be accidentally copied into another header without
modification.  This comment will tell HeaderTesting.py to exclude a
header from testing so we do not have to separately list every excluded
header in every module.

Change-Id: I9d7ae607125459a6527843c8c15ac463a20f6812

VTK Developers authored 12 years ago and Brad King committed 12 years ago

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

VTK Developers authored 12 years ago and Brad King committed 12 years ago

Add module.cmake, CMakeLists.txt, and other build system files.

The modular VTK build system is not yet mature.  The monolithic build
files had a lot of infrastructure.  The modular build files reproduce
much of the functionality but some features will need to be restored
later.  Document status and tasks in "TODO-Modularization.txt".

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

VTK Developers authored 12 years ago and Brad King committed 12 years ago

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>