Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
  • NikitaKolebaev NikitaKolebaev NikitaKolebaev
  • buildbot buildbot buildbot
2 authors
  1. Jul 26, 2022
  3. Jul 25, 2022
  5. Jul 23, 2022
  7. Jul 22, 2022
  9. Jul 21, 2022
  11. Jul 20, 2022
  13. Jul 19, 2022
  15. Jul 18, 2022
  17. Jul 15, 2022
  19. Jul 14, 2022
  21. Jul 12, 2022
  23. Jul 11, 2022
  25. Jul 09, 2022
  27. Jul 08, 2022
    • Sean McBride's avatar
      Null vtkCocoaGLView to vtkCocoaRenderWindow pointer in dtor · 2002a12c
      Sean McBride authored and David Gobbi's avatar David Gobbi committed 
      vtkCocoaGLView keeps a pointer to the vtkCocoaRenderWindow that created it.
When vtkCocoaRenderWindow (a C++ object) is deallocated, the vtkCocoaGLView
(an Objective-C object) doesn't get notified. Therefore vtkCocoaGLView's
pointer to the vtkCocoaRenderWindow can eventually reference a deallocated
object.

So, now, in the vtkCocoaRenderWindow destructor, check if it was the
vtkCocoaRenderWindow that created the vtkCocoaGLView (something we already
keep track of) and if so null out the relationship.
      2002a12c
  29. Jul 07, 2022
  31. Jul 06, 2022
  33. Jul 05, 2022
    • Andras Lasso's avatar
      Fix vtkPolyData::GetCell() crash · 1f04cc68
      Andras Lasso authored and Jean-Christophe Fillion-Robin's avatar Jean-Christophe Fillion-Robin committed 
      vtkPolyData::GetCell() crashed the application if any of a cell in a polydata contained less points than expected.

Details: There was a very strict check in vtkPolyData::BuildCells() that cleared out vtkPolyData::Cells when
the number of points in any of the cells in a polydata was less than expected.
Since vtkPolyData::GetCell() assumes that vtkPolyData::BuildCells() creates a valid vtkPolyData::Cells object,
when that strict check failed, vtkPolyData::GetCell() crashed.

The crash could be fixed by an additional null-pointer checks at every use of vtkPolyData::Cells.
However, it has been valid to store less than 2 points in a VTK_POLY_LINE cell for decades.
Very complex algorithms have been built, relying on this feature.
This feature cannot be just suddenly taken away, because it is extremely difficult to rework large
computational geometry algorithms to take into account this new constraint.
      1f04cc68
    • Sean McBride's avatar
      Added missing libraries to SimpleCocoaVTK Xcode project · 1dc35f76
      Sean McBride authored 
      Recent changes to VTK require linking to additional libaries.
      1dc35f76
    • David Gobbi's avatar
      Merge topic '18594-override-import' into release · 696c296f
      David Gobbi authored and Kitware Robot's avatar Kitware Robot committed 
      
16c37820 Updates to the PythonWrappers doxygen page
cb00d756 More places to skip Python overrides
66623847 Fix Python module load SystemError for overrides

Acked-by: default avatarKitware Robot <kwrobot@kitware.com>
Acked-by: default avatarBane Sullivan <bane.sullivan@kitware.com>
Merge-request: !9344
      696c296f
  35. Jul 04, 2022