Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • LidarView-Superbuild LidarView-Superbuild
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • LidarView
  • LidarView-SuperbuildLidarView-Superbuild
  • Merge requests
  • !18

Check system boost environment variables and clean boost related CMake variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicolas Cadart requested to merge fix/CheckSystemBoostEnvVar into master Aug 27, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

If some Boost environment variables are defined, they could hide the superbuild Boost install. This can lead to superbuild failure if the system boost does not have all required components. It may also lead to runtime errors if all binaries were not built using the same boost libs (system VS superbuild ones).

This adds a check to verify the definition of these environment variables if user does not want to use his system boost install.

This also cleans a bit pcl.cmake by removing useless Boost related CMake variables :

  • Boost_USE_STATIC which does not exist in CMake > 3.0.
  • Boost_LIBRARY_DIR_DEBUG/RELEASE which are automatically set by FindBoost.cmake according to BOOST_LIBRARYDIR hint.

@nick.laurenson @jerome.dias @lea.vauchier @melanie.carriere PTAL

Edited Aug 28, 2020 by Nicolas Cadart
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/CheckSystemBoostEnvVar