Skip to content

[fix] Replace buggy lqSpreadSheetManager with lqDockableSpreadSheetReaction

Nick Laurenson requested to merge fix/CreateDockableSpreadSheetView into master

With the paraview 5.6 upgrade, the lqSpreadSheetManager stop to work because:

  1. To save hidden columns, the code relied on the argument of the signal headerDataChanged. This hack isn't usable anymore, as the whole header is changed each time.
  2. Also with the commit bjacquet/paraview@9fe63c47 paraview introduce an desynchronization in the pqSpreadSheetViewModel: the data are set in a vtkObject, but are get from the qtObject...

This commit:

  1. Refactor the code into a reaction mechanism
  2. Rely on the proxy/property mechanisme to bypass the bug introduce by bjacquet/paraview@9fe63c47
  3. Simplify the code structure by restoring the settings at view/dock creation saving the settings at view/dock destruction
Edited by MelanieCarriere

Merge request reports