Skip to content
Snippets Groups Projects

Fix test stream and remove warnings

Merged Fix test stream and remove warnings
FixTestStreamAndRemoveWarnings into master
All threads resolved!
Merged MelanieCarriere requested to merge FixTestStreamAndRemoveWarnings into master
All threads resolved!
Viewing commit c4f835b8
Next
Show latest version
1 file
+ 1
− 1
Compare changes
  • Side-by-side
  • Inline
  • c4f835b8
    MelanieCarriere
    [test] Fix the stream test · c4f835b8
    MelanieCarriere authored 
    The reader test all frames of a pcap (even the first and the last one by enabling the corresponding option)
So to generate the data, you also need to check "Chow first and last frame options"
In case there is no uncomplete last frame (for a truncated pcap for example) this option create an empty frame at the end of the pcap.

So when you test such a data in stream mode there is a segfault at the last split frame :
There is no point in the last frame,
so a simple call of "split frame" does not push back the current frame in the lidarPacketInterpreter frame buffer
because there is a check on the number of point.

The only way to avoid this segfault is by forcing the splitFrame.
So an empty frame can be push back to the lidarPacketInterpreter frame buffer
LidarPlugin/Testing/TestHelpers.cxx
+ 1
− 1
@@ -575,7 +575,7 @@ int SendAndTestAllFrames(vtkLidarStream *stream, vtkLidarPacketInterpreter* inte
// check for a potential uncomplete last frame.
if (idFrame < referenceFilesList.size())
{
interpreter->SplitFrame();
interpreter->SplitFrame(true);
vtkPolyData* currentFrame = interpreter->GetLastFrameAvailable();
vtkPolyData* currentReference = GetCurrentReference(referenceFilesList, idFrame);