The loop options of the PacketfileSender was broken.
The pcap filename is open at the creation of the vvPacketSender and close when its delete.
We now create a new vvPacketSender for each send.

[doc] Add contribution.md and .gitmessage template

Closes #29

See merge request !132

Using custom animation play mode in LidarView

See merge request !148

Going previous/next frame changes animation mode to 'Snap To Timesteps'.
This will set the speed factor text to 'All frames'.
Currently, user has to set back themselves the desired speed factor using the combo box.

This commit restores previous animation play mode after having snaped to previous/next frame,
so that user does not have to set it themselves again using the speed factor combo box.

Also, if we are in 'Real Time' play mode with for example a speed factor 'x5',
and if we click Next frame, the speed factor will blink to 'All frames' before going back to 'x5'.
As this blink is noisy, we block all animations signals to keep it unchanged during operation.

Changing speed factor using combo box may lead to animation play mode change.
However, if user changes manually the animation play mode, it may be contradictory with the information displayed by the combo box.

lqPlayerControlsToolbar now listens to animation play mode changes, and adapt the combo box display accordingly.

Furthermore, when a new animations scene is set, lqPlayerControlsToolbar set its PlayMode accordingly with UI speed combo box.

Animation PlayMode and Duration were reset each time Play/Pause buttons were clicked.
This prevented using general paraview animations by manually chosing animation settings.

Now, the animation PlayMode and Duration is directly updated when the user selects a different playing speed,
and Play/Pause buttons have trivial behavior of invoking Play/Pause commands.
The animation Duration is also updated when timesteps range changes, e.g. when a new pcap is loaded.

NOTE : When upgrading LVCore in your specific LidarView based application,
you should consider removing the line `app.scene.UpdateAnimationUsingDataTimeSteps()`
in function `applogic.openPCAP()`. Without this change, the speed mode will be set to 'All Frames'
when a new pcap will be loaded. By removing this line, the speed mode and animation settings
won't be changed, and will be kept as user set them before.

[fix] Allow applying a property to a proxy of the same group in LoadLidarState

See merge request !149

During loadLidarState function, the property was applied only if a proxy of the same name of the one saved was found in the pipeline.
For exemple :
If you save the LidarState with a LidarPacketInterpreter i1 and you open a file using a LidarPacketInterpreter i2
The properties saved from i1 couldn't be applied to i2.
This commit allows applying the property to a proxy of the same group.

If the property is not found in this proxy, the message is still display to the user.

[feature] Add a function to Get the sensor information concisely

See merge request !146

MelanieCarriere authored 4 years ago and MelanieCarriere committed 4 years ago

The status bar of LidarView is the lower part of Lidarview.
This contains :
- The pcap filename
- Information about the sensor displayed in Lidarview
- The paraview progress bar
- The application logo

The pcap filename was cropped if it was too long (longer than 43 characters).
This is too short from the clients point of view.

'GetSensorInformation' was called to display the sensor information part.
For some sensor, this can be very long.
By shorting this part we can allow more space to the pcap name.

[test] Restore Reader Test

See merge request !147

MelanieCarriere authored 4 years ago and MelanieCarriere committed 4 years ago

The return value of check currentFrame was not used.
The test seemed to pass even though there were some errors.

[fix] Add bracket to get vector size.

See merge request !142

[ui] Expose the "Record Default filename" of the interpreter to the user

See merge request !145

There is no reason why it should appear in the properties panel.
The goal of this change is mostly to have access to the function through python console.

Add reaction to enable/disable interpreter's advanced arrays

See merge request !143

[ui] Remove the reset of the Spreadsheet options "Show only selected points"

See merge request !144

When opening Lidarview, the default action should be "EnableAdvancedArrays"
Then when the user click on the button, the enable advanced arrays are ON.
The buttons should now represent the action "Disable advanced arrays"
The Reaction update the icon and the tooltip according to that.

fix #29

Some brackets to get vector size are missing. This can cause a build error
in some case.

This was reset to avoid the user opening VeloView and have an empty Spreadsheet.
The user prefer to conserve the option across session.

[fix] Automatically update the pipeline after loading a lidar state

See merge request !141

Add lidar camera toolbar

See merge request !139

This "Lidar Camera Toolbar" is almost the same as the paraview's camera toolbar.
In paraview the "set view Direction" buttons reset the center of rotation to the center of the data
For Lidar data the center of data is less important than the position of the lidar.
So in this "Lidar camera toolbar", the "set view direction" reset the center of rotation to the lidar position (0,0,0)

This will allow us to instantiate our own camera toolbar

Fix spreadsheet view

See merge request !140

The option is saved in the settings and reapply everytime the spreadsheet is opened
When we open Veloview for the first time this option is set to false
This avoid having an empty spreadsheet an misleading the user.

Columns visibility was restored only in the first opening of LidarView.
For example :
if you open the spreadsheet (using ctrl-t), hide a specific column,
       close the spreadsheet (using ctrl-t) and reopen it, the column wasn't hide.

This was due to the check on the current object (if it was different thant the previous).
Actually we want to update the column selection everytime the spreadsheet is displayed.
Even if it's the same object or the same frame.

Fix test stream and remove warnings

See merge request !137

The reader test all frames of a pcap (even the first and the last one by enabling the corresponding option)
So to generate the data, you also need to check "Chow first and last frame options"
In case there is no uncomplete last frame (for a truncated pcap for example) this option create an empty frame at the end of the pcap.

So when you test such a data in stream mode there is a segfault at the last split frame :
There is no point in the last frame,
so a simple call of "split frame" does not push back the current frame in the lidarPacketInterpreter frame buffer
because there is a check on the number of point.

The only way to avoid this segfault is by forcing the splitFrame.
So an empty frame can be push back to the lidarPacketInterpreter frame buffer

[Fix] fix windows compilation of lqLoadLidarStateReaction

See merge request !138

MelanieCarriere authored 4 years ago and MelanieCarriere committed 4 years ago

With MSVC : a double[size] can not be instantiate with a non constant size.

[feature] Save and load lidar state

See merge request !135