Skip to content
Snippets Groups Projects
  1. Dec 16, 2019
  2. Dec 12, 2019
  3. Dec 09, 2019
  4. Nov 26, 2019
  5. Nov 25, 2019
  6. Nov 07, 2019
  7. Oct 30, 2019
  8. Oct 21, 2019
  9. Oct 11, 2019
  10. Oct 07, 2019
  11. Oct 02, 2019
  12. Oct 01, 2019
  13. Sep 30, 2019
  14. Sep 27, 2019
    • Brad King's avatar
      Makefiles: Revert "Make build root targets ... recursive" · 156b5648
      Brad King authored
      Revert the main logic change from commit 827da111 (Makefiles: Make
      build root targets "all", "clean" and "preinstall" recursive,
      2019-05-17, v3.15.0-rc1~96^2~2) for the "all" and "preinstall" targets.
      
      The commit cleaned up the Makefile generator to use the same logic for
      the "all" target in the top-level directory as for subdirectories.  It
      exposed a long-existing bug that caused the "all" target in a
      subdirectory to include the "all" targets from sub-subdirectories even
      if they are marked `EXCLUDE_FROM_ALL`.  The `Tests/SubDir` test should
      fail but the problem is currently covered up by another bug introduced
      by commit dc688857 (Pass EXCLUDE_FROM_ALL from directory to targets,
      2019-01-15, v3.14.0-rc1~83^2) that causes the "all" targets in
      `EXCLUDE_FROM_ALL` subdirectories to be empty.
      
      Revert the top-level "all" and "preinstall" targets to the old approach
      to prepare to fix the latter bug without exposing the long-existing bug
      at the top-level.  Leave the "clean" target in the new approach because
      it does not honor `EXCLUDE_FROM_ALL` anyway.
      
      Issue: #19753
      156b5648
Loading