These warnings can be fixed in the future, but are ignored for now.

CMake has intentional recursion in its codebase, so avoid warning about
occurrences.

CMake has lots of instances of this which is outside the scope of this
topic right now.

CMake isn't ready for this yet.

Set the MinTypeNameLength option to an impossibly high value in order
to limit the diagnostics to iterators.  Leave new expressions and cast
expressions for later.

Now that clang-tidy-8 is used, we can remove the checks that have been
renamed.  Also enable a return-braced-init-list, because we don't have
any violations for that one.

Annotate the remaining typedefs with NOLINT.
Unfortunately, clang-tidy is not smart enough and suggests the use
of using inside extern "C" blocks.

Enables the clang-tidy test performance-inefficient-string-concatenation
and replaces all inefficient string concatenations with `cmStrCat`.

Closes: #19555

Check the codebase with clang-tidy version 8, fix the low hanging
fruits, blacklist the rest.

clang-tidy 7 has an option to suppress this warning in macros which
defaults to '1'.  Set the option to '0' and silence the warning
explicitly.

wahikihiki authored 6 years ago and Brad King committed 6 years ago

Suppress some cases in `Source/cmGeneratorExpressionNode.cxx` and
`Source/cmUVHandlePtr.h` where a few older compilers require a
user-defined default constructor (with `{}`).

Enable the check in .clang-tidy and fix all warnings.

wahikihiki authored 6 years ago and Brad King committed 6 years ago

Fix some warnings that are new since clang-tidy version 4, and update
`.clang-tidy` to suppress the rest.

We disabled this in commit 1fe0d72e (clang-tidy: exclude
'misc-noexcept-move-constructor', 2018-09-24) due to false positives.
Restore it and use a NOLINT comment to suppress them instead.

Our installation is producing false positives on move constructors
and assignment operators that are clearly marked `noexcept`.

We still support compiling CMake on VS 2013 that does not support
`noexcept`, so disable the clang-tidy diagnostic for now.