- Aug 11, 2020
-
-
MSVC >=19.27 supports a C11 switch. The `c_restrict` feature has also been implemented. Fixes: #21069
-
e038107e FindHDF5: fix compiler detection when HL is disabled Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !5112
-
70ce1ad6 PCH: Avoid Apple-specific architecture flags on other platforms Acked-by:
-
5b5be348 Help: Add 3.18.2 release note about AUTOMOC_PATH_PREFIX default change db659e18 Merge branch 'backport-3.17-automoc-path-prefix-off' e503fbe3 Merge branch 'backport-3.16-automoc-path-prefix-off' 4c33b305 Autogen: Turn off moc path prefix generation by default 56510b7d Merge branch 'backport-test-FindPkgConfig-isolate-env' into release-3.17 effc9a10 Merge branch 'backport-3.17-automoc_timestamp_deps' into release-3.17 507fecd7 Merge branch 'ninja-multi-rsp-remove-path' into release-3.17 Acked-by:
-
- Aug 10, 2020
-
-
Brad King authored
Since commit f593b354 (PCH: Add support for multi architecture iOS projects, 2020-04-02, v3.18.0-rc1~414^2) the `OSX_ARCHITECTURES` target property (and corresponding `CMAKE_OSX_ARCHITECTURES` variable) affects flags on non-Apple platforms by accident. Add a missing condition to avoid this. Fixes: #21072
-
A valid HDF5 installation with the "high level" extensions not configured will *fail* to be correctly detected by CMake since commit d9e39f3f (FindHDF5: check that compiler wrapper can compile a minimal program, 2020-02-10, v3.18.0-rc1~744^2~1): ``` /.../hdf5/cmake_hdf5_test.c:2:10: fatal error: 'hdf5_hl.h' file not found ``` This does not stop the configuration but does prevent flags and libraries from being recognized.
-
98844ec9 FPHSA: detect inclusion between find modules Acked-by:
Logan Barnes <barneslt63@gmail.com> Merge-request: !5107
-
97d581b2 Xcode: Explicitly turn off signing in try_compile projects Acked-by:
-
69597441 FindRuby: Restore compatibility variable RUBY_INCLUDE_PATH Acked-by:
-
a92d3845 FindPython: ensure user's policies are respected Acked-by:
Henry Schreiner <henryschreineriii@gmail.com> Merge-request: !5098
-
-
Brad King authored
-
8b129826 Merge branch 'backport-test-FindPkgConfig-isolate-env' 4c939b0d Tests: Isolate RunCMake.FindPkgConfig from caller environment 20eeb40a Tests: Isolate RunCMake.FindPkgConfig from caller environment Acked-by:
-
Brad King authored
-
Change the default value of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF` to restore compatibility with behavior of CMake 3.15 and below. C++ source files that are generated by Qt's meta object compiler (moc) include the header file that was passed as input argument to moc. This is usually a path relative to the source directory, for example #include "../../source/dir/myobject.h" That is problematic for reproducible builds as described in #18815. To cope with that, the target property AUTOMOC_PATH_PREFIX was introduced in CMake 3.16 by commit d018d27c (Autogen: Add moc path prefix generation (AUTOMOC_PATH_PREFIX), 2019-09-13, v3.16.0-rc1~94^2~4). The property is default-initialized from the variable `CMAKE_AUTOMOC_PATH_PREFIX`, which defaults to `ON`. If this property is ON, and myobject.h is located in an include directory of the target, moc-generated C++ files include the file without the "path prefix": #include "myobject.h" This behavior, however, can break projects that have equally named header files in different include directories. As "not breaking existing projects" trumps "have reproducible builds by default" we change the default of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF`. Also, it is now possible to pass `-DCMAKE_AUTOMOC_PATH_PREFIX=ON` on the CMake command line. Before, it was overridden in `CMakeGenericSystem`. Fixes: #20598 Issue: #18815 -
Fixes: #18407, #20571, #20688
-
- Aug 07, 2020
-
-
Brad King authored
Since commit e672db62 (FindRuby: Rename variables to match case of module name, 2020-03-11, v3.18.0-rc1~546^2), the result variables named with the old `RUBY_` prefix are provided by compatibility code that maps from the new `Ruby_` prefix variables. There is no `Ruby_INCLUDE_PATH` variable, so do not try to map it to `RUBY_INCLUDE_PATH`. The latter is provided by dedicated compatibility code left from before that transition. Fixes: #21064
-
Brad King authored
Merge-request: !5108
-
Brad King authored
-
Brad King authored
Avoid interference from `CMAKE_PREFIX_PATH` and friends if they happen to be set in the environment from which the tests are run.
-
Brad King authored
Avoid interference from `CMAKE_PREFIX_PATH` and friends if they happen to be set in the environment from which the tests are run.
-
Ben Boeckel authoredVarious find modules include each other to delegate finding some subset or variant of the package. Ideally, these would use `find_dependency` or some other actual `find_package` mechanism, but that is a larger change. Instead, just detect inclusion and suppress FPHSA name mismatch warnings. Fixes: #21060
-
Do not set the policy version before recording our internal macros such as `__Python_add_library`. Otherwise callers get our policy version instead of theirs. Instead just set the specific policies we need. Also fix one case in our test suite where we were accidentally relying on the policy version to be set by `FindPython`. Fixes: #21042
-
- Aug 06, 2020
-
-
ef97fbe6 PCH: Avoid unnecessary 30s delay on MSBuild Generator with REUSE_FROM Acked-by:
-
8829d2ca GoogleTest: Restore support for list arguments in TEST_EXECUTOR Acked-by:
-
9a9ed4b9 Merge branch 'backport-3.17-automoc_timestamp_deps' 7445c9a5 AutoGen: Add test to check for correct AutoMoc dependencies a79056bb AutoGen: Fix over-specified direct dependencies of custom command Acked-by:
Aleix <aleixpol@kde.org> Merge-request: !5085
-
cdb50af2 Ninja: Restore shorter path to response files Acked-by:
alcroito <alexandru.croitor@qt.io> Merge-request: !5094
-
- Aug 05, 2020
- Aug 03, 2020
-
-
alcroito authored
When using Qt 5.15.0 or above together with Ninja, check that touching a source file of a dependency does not needlessly re-run AUTOMOC for the dependee target.
-
alcroito authored
The AutoMoc timestamp creating custom command explicitly depended on all dependencies of the origin target (associated to the AutoGen target). When an origin target depended on a shared library 'libfoo.so', if it was re-linked, the AutoMoc custom command would touch its output timestamp file, and thus cause needless rebuilding of sources, despite the shared library not having any influence on the AutoMoc generated files. Introduce a new '<target>_autogen_timestamp_deps' utility target, which will serve as an 'order-only' dependency for the custom command. This will prevent needless rebuilding, because touching 'libfoo.so' will not cause the custom command to be re-executed. The new AutoMoc dependency tree looks like: '_autogen_timestamp_deps (serves as order-only dep)' <- '<target_autogen>/timestamp' file ( + moc deps file) <- '<target>_autogen' target. Fixes: #21020 -
Brad King authored
Merge-request: !5094
-
In commit 99ed39b0 (Ninja Multi-Config: Make link response files per-config, 2020-07-15, v3.17.4~3^2), we added the target directory to the response file under the mistaken assumption that two different targets with the same name could be in different directories. However, this causes the path to the response file to be too long to fit on a command line. Take the path back out, while leaving in the per-config split. Fixes: #21050
-
Refactoring in commit 889a7146 (GoogleTestAddTests: Refactor into callable method, 2020-03-16, v3.18.0-rc1~450^2~3) accidentally parsed `TEST_EXECUTOR` as a single-value argument instead of a list.
-
- Jul 30, 2020
-
-
Brad King authored
-
Brad King authored
-
Brad King authored
-
21e497fe Clang: Fix fallback compile features when simulating old MSVC versions Acked-by:
Raul Tambre <raul@tambre.ee>
Merge-request: !5082 -
7051250a Unity Builds: Do not set SKIP_AUTOGEN to source files Acked-by:
-
