Skip to content
Snippets Groups Projects
  1. Mar 20, 2020
  2. Mar 19, 2020
    • Michael Hirsch, Ph.D's avatar
      FindMatlab: Add R2020a=9.8 · 75331a45
      Michael Hirsch, Ph.D authored and Brad King's avatar Brad King committed
      This allows Matlab R2020a to be recognized as a valid Matlab version.
      75331a45
    • Err0rC0deX's avatar
      GetPrerequisites: Classify vcruntime libraries as system · 417b765f
      Err0rC0deX authored and Brad King's avatar Brad King committed
      Previously GetPrerequisites classified `vcruntime*.dll` as type "other".
      They should be classified as type "system".
      417b765f
    • Brad King's avatar
      Merge topic 'trace-format-json-doc' into release-3.17 · 8fad32f5
      Brad King authored and Kitware Robot's avatar Kitware Robot committed
      
      1994f950 cmake: List valid values for --trace-format on the command line
      e39766d8 Help: Fix documentation of --trace-format parameter
      
      Acked-by: default avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !4500
      8fad32f5
    • Brad King's avatar
      export: Fix use-after-free on multiple calls overwriting same FILE · 8affe9aa
      Brad King authored
      CMake 3.16 and below allow multiple `export()` calls with the same output
      file even without using `APPEND`.  The implementation worked by accident
      by leaking memory.  Refactoring in commit 5444a809 (cmGlobalGenerator:
      modernize memrory managemenbt, 2019-12-29, v3.17.0-rc1~239^2) cleaned up
      that memory leak and converted it to a use-after-free instead.
      
      The problem is caused by using the `cmGlobalGenerator::BuildExportSets`
      map to own `cmExportBuildFileGenerator` instances.  It can own only
      one instance per output FILE name at a time, so repeating use of the
      same file now frees the old `cmExportBuildFileGenerator` instance
      and leaves the pointer in the `cmMakefile::ExportBuildFileGenerators`
      vector dangling.  Move ownership of the instances into `cmMakefile`'s
      vector since its entries are not replaced on a repeat output FILE.
      
      In future work we should introduce a policy to error out on this case.
      For now simply fix the use-after-free to restore CMake <= 3.16 behavior.
      
      Fixes: #20469
      8affe9aa
  3. Mar 18, 2020
  4. Mar 17, 2020
  5. Mar 16, 2020
  6. Mar 12, 2020
  7. Mar 11, 2020
  8. Mar 10, 2020
Loading