GitLab

In various places `///!` was used to start a comment line.  This is not valid
Doygen syntax.  This patch replaces `///!` comment starts with `//!`.

dad86f18 ParseImplicitIncludeInfo: Canonicalize implicit include dirs
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Michel Zou <xantares09@hotmail.com>
Merge-request: !3157

a8b7cbb7 Autogen: Do not treat hard-coded -I/usr/include exclusion as implicit include
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3159

6f6e0966 CPackIFW: Add missing cpack_ifw_configure_component_group option processing
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3160

ce180cf8 cmake: Fix '-E copy foo .' to avoid clobbering file
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3145

15be06a5 Tests: Fix Plugin test for international characters on Windows
24da7da6 Merge branch 'upstream-KWSys' into update-kwsys
81666349 KWSys 2019-03-28 (e92bdbe8)
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3158

Merge-request: !3157

The implicit include directory extraction added by commit 5990ecb7
(Compute implicit include directories from compiler output, 2018-12-07,
v3.14.0-rc1~108^2) leaves paths like `/usr/lib/../include` unchanged.
Fix the logic to canonicalize such paths (e.g. to `/usr/include`)
as we do for implicit link directories already.  This is important
to ensure the set of implicit directories is represented in the same
form as the include directories that will be compared to them.

Issue: #19095

Merge-request: !3159

Merge-request: !3160

Build KWSys with `CP_UTF8` internal encoding so that we can dynamically
load modules by absolute paths that contain international characters.
This is needed now that KWSys DynamicLoader uses KWSys Encoding instead
of hard-coding `CP_UTF8` itself.

Both commit 88ecfd8b (CPackIFW: Add some options, 2016-11-11,
v3.8.0-rc1~248^2) and commit e5089c56 (CPackIFW: Add some options,
2017-01-24, v3.8.0-rc1~53^2) added some options to this macro's
documentation and implementation, but the actual processing of the
parsed options was never added.  Add it now.
Reviewed-by: Konstantin Podsvirov <konstantin@podsvirov.pro>

The `cmLocalGenerator::GetIncludeDirectoriesImplicit` method is called
by `cmQtAutoGenInitializer` to get the compiler's list of implicit
include directories.  Since commit 557b2d6e (Fix regression in
-I/usr/include exclusion logic, 2019-02-13, v3.14.0-rc2~6^2~2) the
method hard-codes exclusion of `/usr/include` for historical reasons.
However, it should not be reported as a real implicit include directory
unless the compiler really has it.

Refactor the logic to distinguish the hard-coded exclusion of
`/usr/include` from the real list of implicit include directories.

Fixes: #19100

* upstream-KWSys:
  KWSys 2019-03-28 (e92bdbe8)

Code extracted from:

    https://gitlab.kitware.com/utils/kwsys.git

at commit e92bdbe8e6eca2a8b6dcf14920e5e25308504206 (master).

Upstream Shortlog
-----------------

Ben Boeckel (7):
      30198dbc DynamicLoader: fix error reporting on Windows
      cf6b5f69 DynamicLoader: use Encoding::ToWindowsExtendedPath for the libname
      d17291ad DynamicLoader: support loading libraries using flags
      40d9e482 DynamicLoader: support loading sibling libraries on Windows
      971809c5 DynamicLoader: test the SearchBesideLibrary flag
      efb006b9 DynamicLoader: include stdio.h for _snprintf
      9e8e9ba0 DynamicLoader: avoid the min/max macros from windows.h

Brad King (1):
      92334e76 SystemTools: CopyFileAlways: avoid copying file over self

Merge-request: !3145

Merge-request: !3153

Merge-request: !3147

1d16eae8 ctest_coverage: fix out-of-bounds index in Jacoco parser
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3147

a3a1e69f FindFontconfig: Convert module variables to camel case
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3153

b127e0c5 CUDA: Tolerate square brackets in PROMPT environment variable
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3151

82dec519 find_dependency: Remove clearing of unused cmake_fd_exact_arg variable
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3149

de0d57c9 cmTarget: Use std::unique_ptr instead of custom smart pointer
ecc782c7 cmTarget: Single line comment clanups
be2764a6 cmTarget: Make private `SetPropertyDefault` an in code lambda `InitProperty`
2bfee8a5 cmTarget: Remove obsolete `friend` definitions
a65a4041 cmTarget: Inline private HasImportLibrary method
ff91071a cmTarget: Move member method `CheckImportedLibName` to impl
afc4612f cmTarget: Move member method `ProcessSourceItemCMP0049()` to impl
72b0eeeb cmTarget: Move member booleans to impl
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
Merge-request: !3142

5e958ccd Help: Improve Cache documentation
07f3082d Help: Improve documentation links and formatting
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3152

Our documented standard for find module variable names is to match the
case of the find module package name.  This was overlooked when the
module was added by commit 84e7920b (FindFontconfig: Add module to
find Fontconfig, 2018-09-27, v3.14.0-rc1~523^2).

The module was released with the upper case names in CMake 3.14.0, so
fix it to have camel case names in 3.14.1.  This is incompatible but
anyone using a given release series should be using the latest patch on
it and we've made breaking fixups on newly released features like this
before.
Reported-by: Christophe Giboudeaux <christophe@krop.fr>
Fixes: #19094

The variable is unused since commit ab358d6a (Improve find_dependency
argument handling, 2017-05-22, v3.9.0-rc1~57^2) where handling of EXACT
keyword in find_dependency was reworked.

When the current source file is not found the FilePath variable was left
with the previous path content. In case the previous file had less lines
than the current one and there are 'line' entries for the current one
with higher number we ended up in a buffer overflow while indexing the
previous file entry with a line number higher.  By clearing the
FilePath, the empty() guard triggers correctly on an empty path and it
avoid modifying the wrong data.

b289243d cmGlobalGenerator: Inline `aRange` acquisition in `for(x:aRange)` invocations
bf9afa1e cmGlobalGenerator: Use auto for long iterator types
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
Merge-request: !3144

e7a760fe Autogen: Fix deadlock when uv_spawn() fails while trying to run moc
Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: Sebastian Holtermann <sebholt@xwmw.org>
Merge-request: !3139