1. 15 Aug, 2017 1 commit
    • Tibor Szabo's avatar
      FindCygwin: Fix regression when CYGWIN_INSTALL_PATH is already set · 62930253
      Tibor Szabo authored
      The change in commit v3.9.0-rc1~54^2 (FindCygwin: Use find_program
      instead of find_path, 2017-05-18) broke cases when `CYGWIN_INSTALL_PATH`
      is already set, e.g. on the command-line or by an earlier call to
      `find_package(Cygwin)`.  Since `find_program` now finds the actual
      `cygwin.bat` file, use a separate cache entry to save the location
      and then compute `CYGWIN_INSTALL_PATH`.  If `CYGWIN_INSTALL_PATH`
      is already set, use that to avoid `find_program` having to search.
      62930253
  2. 10 Aug, 2017 4 commits
  3. 08 Aug, 2017 6 commits
  4. 07 Aug, 2017 4 commits
  5. 03 Aug, 2017 7 commits
  6. 02 Aug, 2017 11 commits
  7. 28 Jul, 2017 2 commits
  8. 26 Jul, 2017 1 commit
  9. 25 Jul, 2017 1 commit
  10. 18 Jul, 2017 1 commit
  11. 17 Jul, 2017 1 commit
  12. 14 Jul, 2017 1 commit
    • Brad King's avatar
      Diagnose object library self-reference · d89e10cd
      Brad King authored
      The code
      
          add_library(A OBJECT a.c)
          target_sources(A PRIVATE $<TARGET_OBJECTS:A>)
      
      used to crash CMake via infinite recursion while evaluating the
      generator expression.  Then the change in commit v3.9.0-rc1~266^2~1
      (cmGeneratorTarget: Replace source classifier implementation,
      2017-04-07) avoided the infinite recursion because GetKindedSources now
      creates a map entry and initializes it once.  If it is called again on
      the same target during that initialization, the partially computed
      results are returned.  This is still wrong but does not crash.
      Detect and diagnose this case instead.
      
      Co-Author: Ben Boeckel <ben.boeckel@kitware.com>
      Fixes: #16578
      d89e10cd