Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VTK
VTK
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 432
    • Issues 432
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 117
    • Merge Requests 117
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • VTK
  • VTKVTK
  • Merge Requests
  • !5442

Merged
Opened Apr 19, 2019 by Tristan Coulange@tcoulange
  • Report abuse
Report abuse

Fix vtkPDistributedDataFilter for numCells < numProcs

Fix #17577 (closed)

When numCells < numProcs, the method TestFixTooFewInputFiles duplicates some cells on other procs. Then the filter sends these duplicated cells back to their original proc, but the duplicated cells are not merged for 2 reasons:

  • There is no global cell ids to detect duplication
  • The filter uses DuplicateCellsNo so no merging is applied

So when the method TestFixTooFewInputFiles duplicates some cells, now we compute the global ids (before duplication) and we add a variable duplicateCells which tells to the filter to apply merging. This MR also add a test for this special case.

Edited Apr 25, 2019 by Tristan Coulange

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.kitware.com/tcoulange/vtk.git" "fix_vtkPDistributedDataFilter"
git checkout -b "tcoulange/vtk-fix_vtkPDistributedDataFilter" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "tcoulange/vtk-fix_vtkPDistributedDataFilter"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 19
  • Commits 4
  • Pipelines 5
  • Changes 3
Assignee
Assign to
9.0
Milestone
9.0
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: vtk/vtk!5442

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.