Skip to content

WIP: Cb/osp denoiser2

Carson Brownlee requested to merge carson/vtk:cb/osp_denoiser2 into master

@demarle @utkarsh.ayachit

this is an updated version of the OpenImageDenoise implementation in paraview. By default it only kicks on if built and when accumulation samples are >= 8 (either up the number of spp or enable streaming).

This is marked WIP because I have been having issues getting the cmake targets from openimagedenoise working correctly with VTK's new target macros. All I should need to do is call target_link_libraries(VTK::vtkRenderingOSPRay OpenImageDenoise) and all should be well, and looking at the macro it seems that this is basically what vtk_module_link() is calling, yet the correct library and inlude paths are not being pulled from the openimagedenoise config. I have hardcoded them for now, which you can change in OSPRay/CMakeLists.txt.

Merge request reports