Fix OpenFOAMReader that infers wrong wedge cell type on some polyhedron.

The reader consider every cell with 2 triangles and 3 quads as a wedge but it might be wrong and this ends up with wrong cell topology and holes in the mesh. This patch fixes this issue by processing those wrongly inferred wedges as polyhedrons.

Attached is an example of such polyhedrons. Clearly it is not valid anyway because some faces are far to be planar: badpolyhedron-1481495.vtk

added 1 commit

• 0b55ace0 - Fix OpenFOAMReader that infer wront wedge cell type on some polyhedron.

Compare with previous version

Do: test

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 0b55ace0

@allisonvacanti @michael.migliore @mwestphal

changed title from Fix OpenFOAMReader that infer wront wedge cell type on some polyhedron. to Fix OpenFOAMReader that infer wrong wedge cell type on some polyhedron.

changed the description

Is there a valid polyhedron with 2 triangles and 3 quads that is not a wedge?

changed title from Fix OpenFOAMReader that infer wrong wedge cell type on some polyhedron. to Fix OpenFOAMReader that infers wrong wedge cell type on some polyhedron.

changed the description

I can't find any either, maybe the description is wrong in some way ?

In any case, if the point positions in the linked file are correct, the resulting polyhedron will not contain 2 triangles and 3 quad. There can be only one valid planar quad.

I stumbled across some of that code in the reader, but honestly didn't figure out how its cell topology matching works. Nice that you've had a dig and fixed it!

@olesen If OpenFOAM produces plenty of non planar faces, we will have to introduce a new option to split those cells to avoid different issues that can occures later during mesh processing or visualization.

@olesen Yes indeed, this is something we are going to work on soon.

mentioned in issue paraview/paraview#17787 (closed)

+2

OpenFOAM can (and will) generate non planar faces, and even sometimes non-convex polyhedrons. This fix is correct and should be integrated asap.

added 1002 commits

• 0b55ace0...6a58312b - 1001 commits from branch vtk:master
• 2cd2cc88 - Fix OpenFOAMReader that infer wronh wedge cell type on some polyhedron.

Compare with previous version

Rebasing on last master, last tests before merging...

Do: test

This merge request has been queued for testing. Test results may be viewed on:

• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 2cd2cc88