WIP: Fix OpenGL errors when destroying vtkWin32OpenGLRenderWindow

This commit affects the OpenGL (old) backend.

Commit 49802a3d changed the behavior of vtkWin32OpenGLRenderWindow::CleanUpRenderers() to set the render window on each of the renderers to 'this'. This results in OpenGL errors when the vtkWin32OpenGLRenderWindow destructor calls ren->SetRenderWindow(NULL), because the OpenGL context is already destroyed.

The OpenGL errors are similar to the following:

Generic Warning: In VTK\Rendering\OpenGL\vtkOpenGLDisplayListPainter.cxx, line 52
failed after ReleaseAllLists 16 OpenGL errors detected
  0 : (1282) Invalid operation
  1 : (1282) Invalid operation
  ...
  15 : (1282) Invalid operation

This commit provides an alternative fix for the original issue that restores the original implementation of CleanUpRenderers() but properly resets the renderers with the current render window in CreateOffScreenDC() and ResumeScreenRendering().

Do: test

This merge request has been queued for testing. Test results may be viewed on CDash or Buildbot (only visible from inside Kitware).

Branch-at: 0d281b8a

mentioned in merge request !2462 (merged)

Hi Max, sorry but I don't understand : does your fix consist of reverting commit 49802a3d ? Eloi

Sorry, I believe I misread the original commit and this change does indeed revert to the earlier behavior. It would be great to add a test for the offscreen rendering segfault.

In the meantime I will change this to a WIP.

marked as a Work In Progress

changed the description

Filed #17076 (closed) to track the issue and will close this.

closed