Skip to content
Snippets Groups Projects

vtkPythonUtil: check vtk python map valid

Merged vtkPythonUtil: check vtk python map valid
jcfr/vtk:vtkPythonUtil-check-vtkPythonMap-valid into master
Merged Jean-Christophe Fillion-Robin requested to merge jcfr/vtk:vtkPythonUtil-check-vtkPythonMap-valid into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Gobbi
    David Gobbi @dgobbi started a thread on the diff
    • Wrapping/PythonCore/vtkPythonUtil.cxx
    781 782 void *vtkPythonUtil::GetPointerFromSpecialObject(
    782 783 PyObject *obj, const char *result_type, PyObject **newobj)
    783 784 {
    785 if (vtkPythonMap == NULL)
    786 {
    787 return NULL;
  • Jean-Christophe Fillion-Robin
    Jean-Christophe Fillion-Robin @jcfr ·
    Author Owner

    Thanks for the review. Will submit an updated patch shortly.

  • Jean-Christophe Fillion-Robin Added 1 commit:

    Added 1 commit:

    • d382a3be - BUG: vtkPythonUtil: Check if vtkPythonMap is valid
  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Basic content checks passed!

    Changes since last check: compare

    Branch-at: d382a3be
    Acked-by: @kwrobot

  • Jean-Christophe Fillion-Robin
    Jean-Christophe Fillion-Robin @jcfr ·
    Author Owner

    Here is a revised version

    (Fun fact: Pushed from the airplane using available free wifi. I only add to change the pushurl to use https protocol)

  • David Gobbi
    David Gobbi @dgobbi ·
    Developer

    Do: test

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Testing commands handed to buildbot.

    Branch-at: d382a3be

  • buildbot
    buildbot @buildbot ·
    Maintainer

    Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

    Branch-at: d382a3be

  • David Gobbi
    David Gobbi @dgobbi ·
    Developer

    +2 Looks fine to me.

  • Jean-Christophe Fillion-Robin
    Jean-Christophe Fillion-Robin @jcfr ·
    Author Owner

    @dgobbi Thanks for your help.

    do: merge

  • Kitware Robot
    Kitware Robot @kwrobot ·
    Owner

    Warning: Proper spelling for commands is 'Do:'. Accepting command anyways.

    Branch successfully merged and pushed!

  • Jean-Christophe Fillion-Robin mentioned in commit 0b44c593

    mentioned in commit 0b44c593

  • Kitware Robot Status changed to merged

    Status changed to merged

  • Jean-Christophe Fillion-Robin Mentioned in commit 0b44c593

    Mentioned in commit 0b44c593

    • Please register or sign in to reply