Set the Alt key state in vtkRenderWindowInteractor

Control and shift key state was set in vtkRenderWindowInteractor from QVTKInteractorAdapter, but the state of the alt key was not. This patch addresses that oversight.

Hat tip to Mengda Wu wumengda@gmail.com for providing a patch on the VTK users mailing list that describes the needed fix.

Basic content checks passed!

Branch-at: 45128dae
Acked-by: @kwrobot

Do: test

Testing commands handed to buildbot.

Branch-at: 45128dae

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 45128dae

@finetjul Mind reviewing? You are one of two people git blame reports worked on this class.

Thanks!

Looks fine to me. It's too bad that Modified() can be called once too many. Maybe adding a new signature to the SetKeyEventInformation method could fix that small issue.

A second call to Modified() will be emitted only if the alt key state is changed. I would guess this is relatively rare, so it shouldn't be much of an issue.

I looked into adding a signature. The safest way to do that would be to at the alt key parameter as the last one and set its default value to 0, but then the modifier key parameters are not grouped together, which is ugly IMO. If you do group the alt key state parameter so that it follows the other modifier keys, it gets a little bit tricky keeping things backwards compatible when dealing with the various signatures and default parameter values.

@demarle Mind reviewing?

+2

Added workflow:needs-rebase-for-release label

@cory-quammen Can you rebase this branch so we can merge it in?

Added 1281 commits:

• 45128dae...a00b89d9 - 1280 commits from branch vtk:master
• cb280002 - Set the Alt key state in vtkRenderWindowInteractor

Rebased.

Basic content checks passed!

Changes since last check: compare

Branch-at: cb280002
Acked-by: @kwrobot

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: cb280002

Reassigned to @demarle

Okay once the builds are finished, @demarle can you merge this in ( since you gave it +2 )

Added workflow:buildbots and removed workflow:needs-rebase-for-release labels

Green dashboards, merge when ready.

Do: merge