Errors in H5detect
Hit this compiling Slicer, but also reproduced compiling VTK master with default options (no tests).
cmake: 3.11.1 gcc: 8.1.0
[2548/3688] Building C object ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o
FAILED: ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o
/usr/bin/cc -DVTK_IN_VTK -D_GNU_SOURCE -IThirdParty/hdf5/vtkhdf5 -I/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/hl/src -I/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src -IThirdParty/hdf5 -I/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5 -IThirdParty/zlib -I/home/phc/Software/VTK/VTK-master/ThirdParty/zlib -Ibin -w -w -std=c99 -Og -ftrapv -fno-common -Wundef -Wshadow -Wpointer-arith -Wbad-function-cast -Wcast-align -Wwrite-strings -Wconversion -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -Wnested-externs -Wno-unused-parameter -Wno-inline -Wno-aggregate-return -fmessage-length=0 -g -fPIE -MD -MT ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o -MF ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o.d -o ThirdParty/hdf5/vtkhdf5/src/CMakeFiles/H5detect.dir/H5detect.c.o -c /home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1363:1: error: attributes should be specified before the declarator in a function definition
static void
^~~~~~
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1366:55: error: expected end of line before ‘push’
DETECT_BYTE(signed char, SCHAR, d_g[nd_g]); nd_g++;
^
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1366:1: error: expected end of line before ‘ignored’
DETECT_BYTE(signed char, SCHAR, d_g[nd_g]); nd_g++;
^ ~~
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1366:1: error: expected end of line before ‘pop’
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1367:57: error: expected end of line before ‘push’
DETECT_BYTE(unsigned char, UCHAR, d_g[nd_g]); nd_g++;
^
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1367:1: error: expected end of line before ‘ignored’
DETECT_BYTE(unsigned char, UCHAR, d_g[nd_g]); nd_g++;
^ ~~
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1367:1: error: expected end of line before ‘pop’
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1368:47: error: expected end of line before ‘push’
DETECT_I(short, SHORT, d_g[nd_g]); nd_g++;
^
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1368:1: error: expected end of line before ‘ignored’
DETECT_I(short, SHORT, d_g[nd_g]); nd_g++;
^ ~~
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1368:1: error: expected end of line before ‘pop’
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1369:55: error: expected end of line before ‘push’
DETECT_I(unsigned short, USHORT, d_g[nd_g]); nd_g++;
^
/home/phc/Software/VTK/VTK-master/ThirdParty/hdf5/vtkhdf5/src/H5detect.c:1369:1: error: expected end of line before ‘ignored’
DETECT_I(unsigned short, USHORT, d_g[nd_g]); nd_g++;