1. 23 Sep, 2016 1 commit
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
  2. 22 Sep, 2016 1 commit
    • Ken Martin's avatar
      fix an OpenGL2 issue impacting slicer and add test · 0ea52ccc
      Ken Martin authored
      There were two issues impacting slicer. ImageMappers
      were not honoring their DisplayLocation property value
      and 2d mappers were setting zbufer values on 100%
      transparent pixels.
      
      Added a test from Max Smolens that tests for both of these
      issues to prevent future regressions.
      0ea52ccc
  3. 08 Mar, 2016 1 commit
  4. 04 Jan, 2016 1 commit
    • Sean McBride's avatar
      Fixed a bunch of clang-tidy misc-macro-parentheses warnings · a595ab8e
      Sean McBride authored
      This tool warns where macros should be using parens.
      Fixed many issues it pointed out by either:
       - adding parens (which it can do automatically)
       - removed unused (or rarely used) macros
       - replacing macros with functions, notably vtkMath stuff
      a595ab8e
  5. 01 May, 2015 1 commit
  6. 26 Sep, 2014 1 commit
    • Ken Martin's avatar
      Fix image mapper positions · 25f401d4
      Ken Martin authored
      When images had a position other than the origin, the offset was getting
      applied twice. Causing the images to be in the incorrect position. Also
      cleaned up some old unused function arguments while I was in there.
      
      Change-Id: Ie88a5c711e2d578781e2a83f89e5cc584210361e
      25f401d4
  7. 22 Aug, 2014 1 commit
  8. 07 Aug, 2014 1 commit
  9. 06 Aug, 2014 2 commits
  10. 26 Jun, 2014 1 commit
  11. 24 Jun, 2014 1 commit
  12. 13 Jun, 2014 3 commits
    • Marcus D. Hanwell's avatar
      Very judicious use of sed, vtkOpenGL2* -> vtkOpenGL* · a6a584b1
      Marcus D. Hanwell authored
      This now gives us a vtkRenderingOpenGL2 that has most of the same
      classes as vtkRenderingOpenGL - the two will clobber each other's
      headers, symbols etc and so can never be built/linked at the same
      time.
      
      Unfortunately a lot of classes SafeDownCast or dynamic_cast to the
      derived OpenGL forms of the classes in vtkRenderingCore, and so
      using a different class name presented significant issues despite
      the fact that these classes are (in an ideal world) implementations
      of the API in vtkRenderingCore for OpenGL 2.1 and above.
      
      Change-Id: Ie8c6234621e550d3fd67da732d2cf4839290d665
      a6a584b1
    • Marcus D. Hanwell's avatar
      Rename vtkOpenGL2* -> vtkOpenGL* · b40b181d
      Marcus D. Hanwell authored
      Using pure renames to make things clearer to git...
      
      Change-Id: Icbf5f782179a5e511aee06e7a1fa494be0a5be26
      b40b181d
    • Marcus D. Hanwell's avatar
      Made vtkRenderingOpenGL2 independent of vtkRenderingOpenGL · 8bc98a02
      Marcus D. Hanwell authored
      This required several classes to be copied over, they may not stay.
      It also required me to port many calls from vtkgl to GLEW, and get
      rid of checks for features in OpenGL 2.1 or less. The extension
      manager has been removed, and its functionality replaced.
      
      Change-Id: I60f8858a315a0e91c175aef6152ab57d26650cb4
      8bc98a02
  13. 09 Jun, 2014 1 commit
  14. 09 Nov, 2013 1 commit
  15. 08 Jul, 2013 1 commit
    • Burlen Loring's avatar
      OpenGL error hunt · a6fa3e37
      Burlen Loring authored
      This patch implements OpenGL error checking in VTK.
      
      OpenGL's error handling implementation error is designed such
      that internal error flags remain set with the first error that
      occurred until they are explicitly checked. With this design
      it's important to check and clear the error flags regularly
      else they become unusable as code checking for errors ends
      up reporting earlier undetected unrelated errors.
      
      This patch takes the following approach:
      
      1) at public entry points into code that uses OpenGL clear the
      error flags without reporting errors. This guards against
      reportinig unrealted errors, such as those caused by code
      outside of VTK. See vtkOpenGLClearErrorMacro
      
      2) before returning from functions that made OpenGL calls check
      for and report OpenGL errors. This detects Open GL errors in the
      function/method where they occurred facilitating debugging and it
      clears error flags so that user code doesn't detect errors caused
      by VTK. See vtkOpenGLCheckErrorMacro
      
      This patch cleans up a number of bugs that were detected by
      the new error checking and reporting.
      
      This patch also contains improvements for OpenGL pixel buffers, a
      renderbuffer object, and fast paths through framebuffer objects,
      and texture objects, and fast path for setting uniform variables,
      all of which are needed in vtkSurfaceLICPainter and
      vtkLineIntegralConvolution2D GPGPU code.
      
      Change-Id: I4ecefe9a444a74128bf73ef2ddfd5d4acea387ec
      a6fa3e37
  16. 09 Apr, 2012 2 commits
    • VTK Developers's avatar
      Remove trailing whitespace from all source files · 2d323fc4
      VTK Developers authored
      Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
      are maintained outside VTK.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      2d323fc4
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      cdd4d6fd
  17. 29 Mar, 2012 1 commit
  18. 07 Mar, 2012 1 commit
    • Kyle Lutz's avatar
      Fix misspellings in VTK/Rendering · 27fb8a1c
      Kyle Lutz authored
      This fixes a number of misspellings in the comments of
      the source files in VTK/Rendering. The misspellings were
      found using the codespell tool.
      
      Change-Id: Id7b9f02c583cac599568838c378140e0b6a407a7
      27fb8a1c
  19. 20 May, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · ecbbf7f7
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      ecbbf7f7
  20. 23 Apr, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · 19c55e0e
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      19c55e0e
  21. 23 Feb, 2008 1 commit
  22. 26 Apr, 2006 1 commit
  23. 06 Feb, 2006 1 commit
  24. 05 Jan, 2006 1 commit
    • Utkarsh Ayachit's avatar
      ENH: · fad86463
      Utkarsh Ayachit authored
      * vtkDataArray now has a new superclass-vtkAbstractArray.vtkAbstractArray
      provides type-agnostic API to access array elements. vtkDataArray provides
      a double API to access values -- such an API is deliberately missing from
      vtkAbstractArray, since arrays like string arrays are not castable to doubles.
      
      * vtkAbstractArray has the notion of components/tuples, but does not make
      any assumptions about the arragment of these. It's up to the concrete
      subclasses how the data is represented in memory.
      
      * vtkFieldData used to provide tuple API to get/set values from data arrays
      contained in it. However, now that FieldData can have arrays that are not
      vtkDataArrays, this API is not longer valid.
      The following are the methods that are no longer available:
      double* GetTuple(const vtkIdType);
      void SetTuple(const vtkIdType i, const double* tuple);
      void GetTuple(const vtkIdType i, double* tuple);
      void InsertTuple(const vtkIdType i, const double* tuple);
      void InsertNextTuple(cons double*);
      double GetComponent(const vtkIdType i, const int j);
      void SetComponent(const vtkIdType i, const int j, const double c);
      void InsertComponent(const vtkIdType i, const int j, const double c);
      However, new API is provided to copy tuples arround from one field data to
      another using:
      void SetTuple(const vtkIdType i, const vtkIdType j, vtkFieldData* source);
      void InsertTuple(const vtkIdType i, const vtkIdType j, vtkFieldData* source);
      vtkIdType InsertNextTuple(const vtkIdType j, vtkFieldData* source);
      
      * vtkFieldData provide a vtkDataArray* GetArray(int index) to retrieve arrays
      in the field data. This function can will now return a NULL if the array
      at the given index is not a data array. It provides
      vtkAbstractArray* GetAbstractArray(int index);
      to retrieve an array even if it isn't a vtkDataArray.
      
      * Since vtkFieldData can contain arrays that aren't subclasses of
      vtkDataArray, so can vtkDataSetAttributes. However, an attribute can only be
      a vtkDataArray subclass i.e. one cannot set a vtkStringArray as the SCALARS
      array for a Point Data, for example.
      
      * String Array IO is only supported in XML file formats. If deemed important,
      support may be added for lecacy file formats.
      
      *** Array Iterators ***
      Another addition to the VTK Arrays, is the notion of Array Iterator. A
      vtkArrayIterator subclass is be provided for every vtkAbstractArray
      subclass. The iterator is a random access iterator. The iterators are not
      available in any of the wrapped languages, however, in C++ they can be used to
      write templatized code to processes the array values without any implicit type
      conversion and consequent loss of precision. vtkArrayIteratorTemplateMacro is
      provided to simply switching between different types of the arrays. Examples of
      use of this macro and the iterators can be found in
      vtkXMLWriter.cxx / vtkXMLDataReader.cxx / vtkXMLStructuredDataReader.cxx.
      fad86463
  25. 22 Jul, 2005 1 commit
  26. 23 May, 2005 1 commit
  27. 15 Dec, 2004 1 commit
    • Brad King's avatar
      ENH: Removing inclusion of windows.h by top VTK headers. This results in a... · 3be919f8
      Brad King authored
      ENH: Removing inclusion of windows.h by top VTK headers.  This results in a substantial compile time reduction (~70%) on Windows compilers.  It also avoids forcing windows name mangling on user code.  Preprocessor work-arounds for this mangling has been added for VTK methods.  A new vtkWindows.h has been created for VTK code that really needs the windows API.  A vtkOpenGL.h has been created for VTK code that needs GL/gl.h because this header requires windows.h to be included first on some compilers.  This addresses bug #836.
      3be919f8
  28. 27 Sep, 2004 1 commit
  29. 13 Sep, 2004 1 commit
  30. 31 Aug, 2004 1 commit
  31. 12 Dec, 2003 1 commit
  32. 14 Nov, 2003 1 commit
  33. 25 Jan, 2003 1 commit
  34. 26 Dec, 2002 1 commit
  35. 13 Dec, 2002 1 commit
  36. 12 Dec, 2002 1 commit
    • Michalel Halle's avatar
      · 447def67
      Michalel Halle authored
      The readblock/writeblock OpenGL bugs that are protected by ifdefs seem
      to have been fixed long ago.  I changed the test to succeed only for
      version 1.1 (not the current 1.2).  Note that OpenGL 1.2 implementations
      define both GL_VERSION_1_1 *and* GL_VERSION_1_2 (they aren't version
      tokens, but rather compliance tokens).
      
      This test should more correctly be done using glGetString(), since the
      bug is in the server not the compile-time client in a remote rendering
      situation.  But that's another project....
      447def67