1. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  2. 09 Aug, 2016 1 commit
  3. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  4. 25 May, 2016 1 commit
    • Kitware Robot's avatar
      Remove all BTX and ETX markers from VTK headers · 4d127b1d
      Kitware Robot authored
      Perl was used to remove all the BTX and ETX markers from the code.
      The specific command that was run on all "vtk*.h" files was this:
          perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'
      
      This regex replaces each BTX/ETX line, plus any leading or trailing
      blank lines, with a single blank line.
      4d127b1d
  5. 22 Mar, 2016 1 commit
  6. 08 Mar, 2016 1 commit
  7. 22 Sep, 2015 1 commit
    • David Gobbi's avatar
      Wrap many more classes with python. · e6f75b9a
      David Gobbi authored
      This makes the python wrappers ignore WRAP_EXCLUDE, and instead use
      the new property WRAP_EXCLUDE_PYTHON that excludes fewer classes.
      The WRAP_SPECIAL flag, which used to act as a whitelist for python,
      has been removed.
      
      Because this change causes classes to be wrapped in python by default,
      some third-party VTK packages might break until they modify their own
      CMakeLists.txt files to add WRAP_EXCLUDE_PYTHON where necessary.
      e6f75b9a
  8. 20 Aug, 2015 1 commit
    • Brad King's avatar
      ENH: Remove use of include <vtksys/ios/*> and vtksys_ios::* · 3ae7dd3a
      Brad King authored
      We no longer need this compatibility layer for the compilers we support.
      Use the following commands to switch to standard header and namespace:
      
       git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
       git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'
      3ae7dd3a
  9. 22 Jul, 2015 1 commit
    • Bill Lorensen's avatar
      STYLE: Replace vtksys_stl and vtksys_ios:: with std:: · 924248d9
      Bill Lorensen authored
      In the early days of VTK, support for stl was not portable. vtksys_stl
      and vtksys_ios provided a portable implementation of the stl. Now, all
      of the VTK supported compilers have portable stl implementations.
      
      This patch:
        1) Replaces the vtksys_ios:: with std::.
        2) Replaces the vtksys_stl:: with std::.
        3) Removes "using" statements for stl
      924248d9
  10. 18 Dec, 2014 2 commits
  11. 09 Oct, 2014 1 commit
  12. 03 Jul, 2014 2 commits
    • Ben Boeckel's avatar
      linking: wrap tll() with a module-aware function · 3cd0686a
      Ben Boeckel authored
      This will allow kits to gather all of the required libraries to link
      since the modules themselves won't "exist" to link anything when kits
      are enabled.
      
      Change-Id: Ic73220c7b97e17a5fbc0aa6c0f7a5e5a61dc6bef
      3cd0686a
    • Ben Boeckel's avatar
      modules: add modules to "kits" · e5203447
      Ben Boeckel authored
      The main kits are:
      
          vtkCommon
          vtkFilters
          vtkIO
          vtkImaging
          vtkInteraction
          vtkOpenGL (required due to a dependency cycle from
                     vtkRenderingOpenGL on vtkImagingHybrid)
          vtkParallel
          vtkRendering
          vtkViews
          vtkWrapping
      
      Modules which deal with a specialization of another module belong to the
      kit related to the specialization (i.e., FiltersParallel and
      IOParallelXML both belong to the vtkParallel kit) to avoid circular
      dependencies that arise when put into the same kit as the "lesser"
      module.
      
      Change-Id: Icae0baa78d62cc0dcce84546541df600d4f311dd
      e5203447
  13. 16 Apr, 2014 1 commit
  14. 01 Sep, 2013 1 commit
  15. 19 Aug, 2013 1 commit
    • Brad King's avatar
      COMP: Cleanup CMP0022 and CMP0023 warnings · ed6c07d0
      Brad King authored
      CMake 2.8.12 introduces policies CMP0022 and CMP0023 that trigger
      warnings in some of VTK's CMake code.  Fix them as follows.  The result
      is a cleaner and more explicit link specification anyway.
      
      CMP0022 warns when we set the LINK_INTERFACE_LIBRARIES property directly
      without also setting the newly introduced INTERFACE_LINK_LIBRARIES
      property directly.  Simply drop these settings because they are achieved
      already by use of the keyword-based target_link_libraries signature.
      
      CMP0023 warns when we use both the plain and keyword signatures of the
      target_link_libraries command for a single target.  The module macros
      use the keyword signature (LINK_PUBLIC/LINK_PRIVATE), so any direct
      calls to the plain target_link_libraries signature are doing "private"
      linking.  Add the LINK_PRIVATE keyword to such calls to make this
      explicit and avoid the warning.
      
      Change-Id: I1e5bf687733e3f19462da698c0d5e3899439bf02
      ed6c07d0
  16. 14 Aug, 2013 1 commit
    • Marcus D. Hanwell's avatar
      Add support for private dependencies in VTK · 57901457
      Marcus D. Hanwell authored
      A simple implementation of private dependencies, with some of the most
      obvious private dependencies moved over. This should be used for all
      dependencies that are not exposed in the public API of the classes in
      the module.
      
      The target_link_libraries call defaults to private due to the way CMake
      implements the link logic. The private dependency logic can help reduce
      link line and include directory length for private links where the
      dependency's API is not exposed in the module. Also added code to ensure
      include directories are not duplicated for modules in the build tree.
      
      Change-Id: If4535338e8d5e9957d7bcce7d3ab0eadec21d2c4
      57901457
  17. 25 Jun, 2013 1 commit
    • Patrick Emond's avatar
      vtkMySQLQuery incorrectly returning non NULL values · c4d2fc93
      Patrick Emond authored
      When querying a table which has columns which may be null this class
      returns non-null values when it shouldn't. For instance, for the table:
      
      CREATE TABLE myTable (
        myIntValue int DEFAULT NULL,
        myFloatValue float DEFAULT NULL
      )
      
      Columns myIntValue and myFloatValue may be set to null, but when reading
      these values using vtkMySQLQuery the values 0 and 0.0 are returned
      instead of NULL.
      
      The reason is found in vtkMySQLQuery::DataValue().  Specifically, in the
      switch statement there are several return statements which do the
      following:
      
        return vtkVariant(base.ToInt());
      
      When the value is NULL the variable "base" is correctly set to an
      un-initialized state. Calling ToInt() returns 0 even if it is not a
      valid number (NULL).  This patch addresses the problem by returning
      the base variant without converting to int/long/float/double if the
      value is NULL.
      
      Change-Id: Ifbea52c2c1fb3ed6ccd3e9f7753f3f669c46f5e8
      c4d2fc93
  18. 04 Jun, 2013 1 commit
    • Brad King's avatar
      Convert VTKData test inputs to ExternalData content links · 3797f83d
      Brad King authored
      Add to the Testing/Data directory ExternalData content links mirroring
      the content and layout we use from the VTKData/Data directory.
      
      Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
      Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
      for all data directories added from VTKData/Data.  This will bulk-fetch
      all test input data currently used by tests of any module, enabled or
      not.  We can make the DATA{} references more granular later.
      
      Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
      ExternalData module to populate the real data files.  Replace references
      to VTK_DATA_ROOT in test command lines (after -D) with references to
      VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
      the VTKData repository.
      
      Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
      the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
      input data are now handled through ExternalData and Testing/Data content
      links.
      
      Change-Id: Id02490b76ea2e161b9038188264a4830485039d8
      3797f83d
  19. 17 May, 2013 1 commit
  20. 14 May, 2013 2 commits
    • Brad King's avatar
      Use ExternalData to reference test baselines · 42baebf3
      Brad King authored
      Teach vtk_add_test_* to use ExternalData_add_test to add tests and use
      DATA{} syntax to reference test baseline images.  Also update direct
      add_test calls in several modules.
      
      Change-Id: I1ddcec1c109ea9ca7840be9b6ccf015393039cba
      42baebf3
    • Brad King's avatar
      Use vtk_add_test_cxx function · 5b018861
      Brad King authored
      Refactor */*/Testing/Cxx/CMakeLists.txt to use the vtk_add_test_cxx
      function instead of direct add_test calls.
      
      Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd
      5b018861
  21. 16 Apr, 2012 1 commit
    • Brad King's avatar
      Allow multiple modules to auto-init a given module · e6aba7c2
      Brad King authored
      The prior auto-init implementation injected a definition of
      
        struct <mod>_AutoInit
      
      into application translation units.  If the same <mod> appeared in more
      than one auto-init list then the definition would be repeated and fail
      to compile.  Since macro expansion cannot implement an equivalent to
      include blockers we need an alternative.  Instead use functions
      
        <mod>_AutoInit_Construct
        <mod>_AutoInit_Destruct
      
      to hook into module static initialization and finalization.  Function
      declarations can be repeated.  Inject into an application translation
      unit at most one static data instance per module.  Generate its
      constructor and destructor to call the above functions for every module
      in the auto-init list.
      
      Change-Id: I202d74f8ba0a457a7688c0d22f68aacbcdc47617
      e6aba7c2
  22. 10 Apr, 2012 1 commit
    • Chris Harris's avatar
      FIX: Add configured headers for SQL test URL's · caa0949f
      Chris Harris authored
      The connection URL's for the SQL tests have been removed from the
      toolkit header so they need to be moved to individual headers
      for each test.
      
      Change-Id: I4b6f3948e89342f868a621f22d3c5983238daa11
      caa0949f
  23. 09 Apr, 2012 5 commits
    • Brad King's avatar
      Mark headers to be excluded from header style tests · 002f853f
      Brad King authored
      Add a comment to the bottom of each header that used to be excluded from
      kit HeaderTesting tests in monolithic VTK.  Format the comment in a way
      that cannot be accidentally copied into another header without
      modification.  This comment will tell HeaderTesting.py to exclude a
      header from testing so we do not have to separately list every excluded
      header in every module.
      
      Change-Id: I9d7ae607125459a6527843c8c15ac463a20f6812
      002f853f
    • VTK Developers's avatar
      Remove trailing whitespace from all source files · 2d323fc4
      VTK Developers authored
      Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
      are maintained outside VTK.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      2d323fc4
    • VTK Developers's avatar
      Include module-wide headers and export macros · 144f03ca
      VTK Developers authored
      Include the module-wide header from every header in each module.
      Reference the export/visibility macro for the module.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      144f03ca
    • VTK Developers's avatar
      Add modular VTK build system · 0c1471f1
      VTK Developers authored
      Add module.cmake, CMakeLists.txt, and other build system files.
      
      The modular VTK build system is not yet mature.  The monolithic build
      files had a lot of infrastructure.  The modular build files reproduce
      much of the functionality but some features will need to be restored
      later.  Document status and tasks in "TODO-Modularization.txt".
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      0c1471f1
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      cdd4d6fd