1. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  2. 13 Jul, 2016 1 commit
    • Sean McBride's avatar
      Used clang-tidy's "modernize-use-override" to add some C++11 overrides · 753dcec5
      Sean McBride authored
      It doesn't seem to have got everything, but it's a start.
      
      Some resulting whitespace is suboptimal, but one day
      we can fix that with clang-format. :)
      
      Just ran this command:
      run-clang-tidy.py -checks=-*,modernize-use-override -fix
      
      (I actually had to build my own clang to make clang-tidy
      output "VTK_OVERRIDE" instead of "override".)
      753dcec5
  3. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  4. 22 Mar, 2016 1 commit
  5. 08 Mar, 2016 1 commit
  6. 28 Jan, 2016 1 commit
  7. 22 Jan, 2016 1 commit
  8. 04 Jan, 2016 1 commit
    • Sean McBride's avatar
      Fixed a bunch of clang-tidy misc-macro-parentheses warnings · a595ab8e
      Sean McBride authored
      This tool warns where macros should be using parens.
      Fixed many issues it pointed out by either:
       - adding parens (which it can do automatically)
       - removed unused (or rarely used) macros
       - replacing macros with functions, notably vtkMath stuff
      a595ab8e
  9. 22 Sep, 2015 1 commit
    • David Gobbi's avatar
      Wrap many more classes with python. · e6f75b9a
      David Gobbi authored
      This makes the python wrappers ignore WRAP_EXCLUDE, and instead use
      the new property WRAP_EXCLUDE_PYTHON that excludes fewer classes.
      The WRAP_SPECIAL flag, which used to act as a whitelist for python,
      has been removed.
      
      Because this change causes classes to be wrapped in python by default,
      some third-party VTK packages might break until they modify their own
      CMakeLists.txt files to add WRAP_EXCLUDE_PYTHON where necessary.
      e6f75b9a
  10. 06 Aug, 2015 2 commits
  11. 05 Aug, 2015 1 commit
  12. 10 Jun, 2015 1 commit
  13. 02 Apr, 2015 1 commit
    • Sean McBride's avatar
      Fix -Wimplicit-fallthrough warnings; introduce VTK_FALLTHROUGH · 3cc4d9fc
      Sean McBride authored
      Fixed all clang -Wimplicit-fallthrough warnings:
      - Some fixed by adding missing breaks
      - Other fixed by adding VTK_FALLTHROUGH statement
      
      Under (modern) clang with C++11:
       #define VTK_FALLTHROUGH [[clang::fallthrough]]
      
      Otherwise:
       #define VTK_FALLTHROUGH ((void)0)
      
      VTK_FALLTHROUGH serves two purposes:
       - under clang, suppresses -Wimplicit-fallthrough warnings
       - makes code more self-documenting
      3cc4d9fc
  14. 31 Mar, 2015 1 commit
    • Dan Lipsa's avatar
      Redesign "vtkGhostLevels" arrays and related ghost functionalties. · 4dee0274
      Dan Lipsa authored
      Co-authored-by: default avatarYuanxin Liu <leo.liu@kitware.com>
      Co-authored-by: Berk Geveci's avatarBerk Geveci <berk.geveci@kitware.com>
      
       -The semantics of each unsigned char in the ghost arrays changes:
        Instead of storing a numeric value representing how far a cell is
        from the boundary, it is now a bit field specified by
        vtkDataSetAttributes::CellGhostTypes and
        vtkDataSetAttributes::PointGhostTypes.  The bit field is consistent
        with VisIt specs.
      
      - Previously, filters strip all ghost cells they request from upstream
        before finalizing the output. This is no longer done.
      
      - vtkUniform grids previously supported blanking through member arrays
        vtkUniformGrid::CellVisibility and
        vtkUniformGrid::PointVisibility. These arrays are removed and the
        blanking functionality are supported through the new ghost arrays
        instead.
      
      - the "vtkGhostLevel" arrays for cell and point data are renamed to
        vtkDataSetAttributes::GhostArrayName() ("vtkGhostType").
      
      - the version for VTK Legacy files is increased to 4.0 and the version for
        VTK XML files is increased to 2.0. When reading older files we
        convert vtkGhostLevels array to vtkGhostType.
      4dee0274
  15. 26 Mar, 2015 1 commit
  16. 16 Feb, 2015 1 commit
  17. 18 Dec, 2014 1 commit
  18. 06 Dec, 2014 1 commit
    • David Gobbi's avatar
      Fix warnings due to anonymous namespace. · 153473f3
      David Gobbi authored
      Some gcc-4.2 builds complain when a type is defined within an
      anonymous namespace, but subsequently used to define members of
      any class declared outside of the anonymous namespace.  This is
      probably a spurious warning, but it is easy to fix by making the
      type itself a member of the class that is using it.
      
      Change-Id: I4cf5cf2e9538f6a0fd611046193e9f0bd53b76d1
      153473f3
  19. 09 Oct, 2014 1 commit
  20. 23 Sep, 2014 1 commit
  21. 22 Sep, 2014 1 commit
  22. 29 Jul, 2014 1 commit
  23. 03 Jul, 2014 1 commit
    • Ben Boeckel's avatar
      modules: add modules to "kits" · e5203447
      Ben Boeckel authored
      The main kits are:
      
          vtkCommon
          vtkFilters
          vtkIO
          vtkImaging
          vtkInteraction
          vtkOpenGL (required due to a dependency cycle from
                     vtkRenderingOpenGL on vtkImagingHybrid)
          vtkParallel
          vtkRendering
          vtkViews
          vtkWrapping
      
      Modules which deal with a specialization of another module belong to the
      kit related to the specialization (i.e., FiltersParallel and
      IOParallelXML both belong to the vtkParallel kit) to avoid circular
      dependencies that arise when put into the same kit as the "lesser"
      module.
      
      Change-Id: Icae0baa78d62cc0dcce84546541df600d4f311dd
      e5203447
  24. 24 Jun, 2014 1 commit
  25. 23 Jun, 2014 1 commit
    • David Thompson's avatar
      Bug 14713: Read LS-Dyna point coordinates properly. · e4061e5f
      David Thompson authored
      An LS-Dyna simulation may have time-varying nodal coordinates.
      In this case, the initial, static coordinates are ignored since
      they are overwritten by the deflected coordinates as each timestep
      is read. However, it is apparently possible to configure LS-Dyna
      not to write the deflected coordinates. In which case, we *must*
      read the static coordinate data since that is all that's present.
      Do so.
      
      Change-Id: I4db3af4bbd0948212f179a620bde3bc0fefe23b3
      e4061e5f
  26. 20 Jun, 2014 1 commit
  27. 21 May, 2014 2 commits
    • Berk Geveci's avatar
      Updated filters and sources to work with new pipeline logic. · 747b780a
      Berk Geveci authored
      Change-Id: Id76d3bc545a64675a0820cb1d9b45c61a51efc6a
      747b780a
    • Berk Geveci's avatar
      Refactored how pieces and extents are handled. · 1a0b4e9d
      Berk Geveci authored
      Refactoring the way VTK goes between piece and structured
      extents. Before, extent translators were used when the pipeline
      moved from structured to unstructured data converting piece
      request to extent request. This caused many problems with filters
      that altered extents, mainly a lot of redundant IO due to
      repartitioning of different extents. This became extremely
      cumbersome to manage when running distributed. The new behavior
      pushes the extent translation all to way to the readers and
      only when readers are able to read a subset. This works much
      better. The only downside is that filters need to be able to
      handle data extents different than update extents. Most filters
      can do this but many imaging filters cannot. Those that are
      needed in parallel will have to be updated.
      
      As part of this work, I also removed MAXIMUM_NUMBER_OF_PIECES
      and added CAN_HANDLE_PIECE_REQUEST. MAXIMUM_NUMBER_OF_PIECES had
      reduced to being a boolean. 1 for serial sources, -1 for parallel
      sources. I removed it and added a CAN_HANDLE_PIECE_REQUEST instead.
      This key, produced by a source, tells the executive that a source is
      able to handle piece request. It is a source only key produced in
      RequestInformation and is not propagated downstream. If this key is
      not present, the executive will only execute the source for piece 0
      to produce the entire data. It is then up to the user to add a filter
      that splits the data for other piece requests. The only exception to
      this is when CAN_PRODUCE_SUB_EXTENT is present, in which case the
      executive will split using an extent translator AT THE source - not
      downstream.
      
      Conflicts:
      	Filters/FlowPaths/vtkParticleTracerBase.cxx
      
      Change-Id: I8db4040289ff87331adeecded4a738313d9b52df
      1a0b4e9d
  28. 06 May, 2014 1 commit
  29. 16 Apr, 2014 1 commit
  30. 13 Mar, 2014 1 commit
  31. 23 Sep, 2013 1 commit
  32. 01 Sep, 2013 1 commit
  33. 14 Aug, 2013 1 commit
    • Marcus D. Hanwell's avatar
      Add support for private dependencies in VTK · 57901457
      Marcus D. Hanwell authored
      A simple implementation of private dependencies, with some of the most
      obvious private dependencies moved over. This should be used for all
      dependencies that are not exposed in the public API of the classes in
      the module.
      
      The target_link_libraries call defaults to private due to the way CMake
      implements the link logic. The private dependency logic can help reduce
      link line and include directory length for private links where the
      dependency's API is not exposed in the module. Also added code to ensure
      include directories are not duplicated for modules in the build tree.
      
      Change-Id: If4535338e8d5e9957d7bcce7d3ab0eadec21d2c4
      57901457
  34. 25 Jun, 2013 1 commit
  35. 04 Jun, 2013 1 commit
    • Brad King's avatar
      Convert VTKData test inputs to ExternalData content links · 3797f83d
      Brad King authored
      Add to the Testing/Data directory ExternalData content links mirroring
      the content and layout we use from the VTKData/Data directory.
      
      Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
      Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
      for all data directories added from VTKData/Data.  This will bulk-fetch
      all test input data currently used by tests of any module, enabled or
      not.  We can make the DATA{} references more granular later.
      
      Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
      ExternalData module to populate the real data files.  Replace references
      to VTK_DATA_ROOT in test command lines (after -D) with references to
      VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
      the VTKData repository.
      
      Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
      the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
      input data are now handled through ExternalData and Testing/Data content
      links.
      
      Change-Id: Id02490b76ea2e161b9038188264a4830485039d8
      3797f83d
  36. 24 May, 2013 1 commit
    • Brad King's avatar
      Convert VTKLargeData test inputs to ExternalData content links · 4fbc3a0d
      Brad King authored
      Add a Testing/Data directory with ExternalData content links mirroring
      the content and layout we use from the VTKLargeData/Data directory.
      Add a VTK_USE_LARGE_DATA option to enable tests using such data.
      
      Call ExternalData_Expand_Arguments in */*/Testing/Cxx/CMakeLists.txt for
      tests that reference these data files in order to tell the ExternalData
      module to populate a ExternalData/Testing/Data directory in the build
      tree.  Pass the ExternalData/Testing directory in the build tree as the
      "-D" data directory option to tests using these data so that they can
      find the files where ExternalData puts them at build time.
      
      In the vtk_add_test_* API replace the LARGE_DATA options with a new
      TESTING_DATA option to indicate that a test uses the directory
      ExternalData/Testing/Data populated by ExternalData from the
      Testing/Data source directory.
      
      Drop VTK_LARGE_DATA_ROOT and stop using the VTKLargeData repository.
      Drop references to VTKLargeData from test source comments.
      
      Change-Id: Iaaf36293a840e65d6c171ae69b5c99db4c61443e
      4fbc3a0d
  37. 17 May, 2013 1 commit