1. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  2. 27 Jul, 2016 1 commit
    • Utkarsh Ayachit's avatar
      Cleanup QT5. · e1fe01a6
      Utkarsh Ayachit authored
      In module configuration files generated for Qt-based modules, we now
      export find_package() calls that find specific components from Qt5 i.e.
      `find_package(Qt5 COMPONENTS Widgets)` instead of
      `find_package(Qt5Widgets)`.
      e1fe01a6
  3. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  4. 06 May, 2016 1 commit
    • David C. Lonie's avatar
      Replace SafeDownCast calls on arrays with vtkArrayDownCast. · 0d71a308
      David C. Lonie authored
      SafeDownCast performs a series of virtual calls and string comparisons,
      which is quite slow, especially when used in worker functions.
      
      vtkArrayDownCast will switch between SafeDownCast and the more
      efficient FastDownCast (only available for common vtkAbstractArray
      subclasses) depending on whether or not FastDownCast is defined for
      the specific array type.
      0d71a308
  5. 08 Mar, 2016 1 commit
  6. 23 Oct, 2015 1 commit
  7. 22 Oct, 2015 1 commit
  8. 21 Oct, 2015 1 commit
  9. 29 Apr, 2015 1 commit
  10. 18 Dec, 2014 1 commit
  11. 03 Jul, 2014 1 commit
    • Ben Boeckel's avatar
      linking: wrap tll() with a module-aware function · 3cd0686a
      Ben Boeckel authored
      This will allow kits to gather all of the required libraries to link
      since the modules themselves won't "exist" to link anything when kits
      are enabled.
      
      Change-Id: Ic73220c7b97e17a5fbc0aa6c0f7a5e5a61dc6bef
      3cd0686a
  12. 07 May, 2014 1 commit
    • Brad King's avatar
      Export the locations of Qt5 packages on which modules depend · 23fbbebc
      Brad King authored
      Qt5 packages provide libraries to VTK in the form of imported targets.
      VTK libraries that link to them get exported with dependencies on the
      imported targets.  We must make them available to applications that link
      to these VTK libraries too.
      
      Teach each module that depends on Qt5 to export code that runs when
      an application loads the module as part of its build process.  Find
      the needed Qt5 package on behalf of the application to satisfy the
      module's dependency on it.
      
      Change-Id: Ib638ccafa084fbb06c20eb09464265501ccafc80
      23fbbebc
  13. 19 Aug, 2013 1 commit
    • Brad King's avatar
      COMP: Cleanup CMP0022 and CMP0023 warnings · ed6c07d0
      Brad King authored
      CMake 2.8.12 introduces policies CMP0022 and CMP0023 that trigger
      warnings in some of VTK's CMake code.  Fix them as follows.  The result
      is a cleaner and more explicit link specification anyway.
      
      CMP0022 warns when we set the LINK_INTERFACE_LIBRARIES property directly
      without also setting the newly introduced INTERFACE_LINK_LIBRARIES
      property directly.  Simply drop these settings because they are achieved
      already by use of the keyword-based target_link_libraries signature.
      
      CMP0023 warns when we use both the plain and keyword signatures of the
      target_link_libraries command for a single target.  The module macros
      use the keyword signature (LINK_PUBLIC/LINK_PRIVATE), so any direct
      calls to the plain target_link_libraries signature are doing "private"
      linking.  Add the LINK_PRIVATE keyword to such calls to make this
      explicit and avoid the warning.
      
      Change-Id: I1e5bf687733e3f19462da698c0d5e3899439bf02
      ed6c07d0
  14. 27 May, 2013 1 commit
    • Jean-Christophe Fillion-Robin's avatar
      COMP 12945: Allow VTK to build against Qt5 · 384636ec
      Jean-Christophe Fillion-Robin authored
      Since VTK build system has been updated to make use of CMake macros
      specific to Qt5, the support has to explicitly enabled configuring VTK
      with -DVTK_QT_VERSION:STRING="5"
      
      Additionally, in case Qt5 is not installed in a standard location,
      a custom prefix for "find_package" should be passed.
      For example:
        -DCMAKE_PREFIX_PATH:STRING=/home/jchris/Qt5.0.2/5.0.2/gcc_64/
      
      
      Finally, this commit also resolves the build errors reported below.
      
      Fix missing header build error by including Qt headers directly without
      specifying the intermediate directory.
      
      * Fix build error changing QString::toAscii into  QString::toLatin
      The method "toAscii" has been deprecated and is not available in
      default Qt5 distribution.
      See http://qt-project.org/doc/qt-5.0/qtcore/qstring.html#toAscii
      
      * Fix build error changing Qt::WFlags into Qt::WindowFlags
      See http://qt-project.org/doc/qt-5.0/qtcore/qt-obsolete.html
      
      * Fix build error changing QAbstractItemModel::reset() into
      combo QAbstractItemModel::beginResetModel()/QAbstractItemModel::endResetModel()
      The method "reset" has been deprecated and is not available in
      default Qt5 distribution.
      See http://qt-project.org/doc/qt-5.0/qtcore/qabstractitemmodel-compat.html#reset
      
      * Fix build error by including "vtkObjectBase.h":
      /home/jchris/Projects/Qt5.0.2/5.0.2/gcc_64/include/QtCore/qmetatype.h:464: error: invalid application of ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’
      
      * Fix "no matching function for call to ‘QPixmap::grabWidget(QWidget*)’" by using
      "QWidget::grab"
      See http://qt-project.org/doc/qt-5.0/qtwidgets/qwidget.html#grab
      
      * Fix missing QHttpHeader/QHttpRequestHeader headers by removing them.
      They have been removed from Qt5 and were not used in the code.
      
      * Fix error: ‘qInstallMsgHandler’ was not declared in this scope
      by using "qInstallMessageHandler"
      See http://qt-project.org/doc/qt-5.0/qtdoc/sourcebreaks.html
      
      * Fix Q4VTKWidgetPlugin.cxx:147: error: invalid application of
      ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’ by
      using "Q_PLUGIN_METADATA" macro instead of Q_EXPORT_PLUGIN
      or Q_EXPORT_PLUGIN2.
      See http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5#7ec1b8f08d7f31ebcb53188f0bd15ed5
      
      Change-Id: Ie7123e5990e3a8afb4d7d2efa0fda5bd7b98c1e3
      384636ec
  15. 09 Apr, 2012 4 commits
    • Brad King's avatar
      Restore VTK header tests removed by the modularization · 437db4b1
      Brad King authored
      Teach vtk_module_library to add a <module>.HeaderTest test.  Teach
      HeaderTesting.py to exclude headers containing a special comment like
      those added by the parent commit.
      
      Exclude GUISupport/Qt* and Views/Qt because the modules have headers
      that are not expected to follow VTK conventions.  Temporarily exclude
      the Chemistry/Core module until its headers are fixed or marked as
      excluded (they came from the Chemistry kit in monolithic VTK which had
      no header test).
      
      Change-Id: Ib6e1313a866db154f7b0e94aa340a10b16f8b9ca
      437db4b1
    • VTK Developers's avatar
      Include module-wide headers and export macros · 144f03ca
      VTK Developers authored
      Include the module-wide header from every header in each module.
      Reference the export/visibility macro for the module.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      144f03ca
    • VTK Developers's avatar
      Add modular VTK build system · 0c1471f1
      VTK Developers authored
      Add module.cmake, CMakeLists.txt, and other build system files.
      
      The modular VTK build system is not yet mature.  The monolithic build
      files had a lot of infrastructure.  The modular build files reproduce
      much of the functionality but some features will need to be restored
      later.  Document status and tasks in "TODO-Modularization.txt".
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      0c1471f1
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      cdd4d6fd