1. 08 Jan, 2019 3 commits
  2. 25 Oct, 2018 1 commit
    • Alexander Rettig's avatar
      vtkQtLabelRenderStrategyInternals: expose in a header · 54910fc0
      Alexander Rettig authored
      The implementation detail class `vtkQtLabelRenderStrategy::Internals` is
      moved to an own header file `vtkQtLabelRenderStrategyInternals.h` as
      otherwise it is not possible to cleanly derive from
      `vtkQtLabelRenderStrategy`: a derived class needs access to the
      `Internals` to be able to modify relevant functionality and therefore it
      must see the definition of that class.
      
      Fixes #17395
      54910fc0
  3. 26 Jun, 2018 1 commit
  4. 21 Dec, 2017 1 commit
  5. 04 Dec, 2017 1 commit
  6. 04 Oct, 2017 2 commits
    • Ken Martin's avatar
      manually convert more NULL to nullptr · de3c93a3
      Ken Martin authored
      This topic catches another batch of NULL conversions that
      clang did not handle for various reasons. It also includes
      a number of changes to comments and strings where NULL was
      used. It also catches some recent code changes where NULL
      was used instead of nullptr.
      de3c93a3
    • Kitware Robot's avatar
      Replace VTK_DELETE_FUNCTION with =delete. · 1ac2c008
      Kitware Robot authored
      Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
      wrap =delete;
      1ac2c008
  7. 02 Oct, 2017 1 commit
  8. 02 Jun, 2017 1 commit
    • Sean McBride's avatar
      Converted the last remaining sprintf to snprintf · 5c238b17
      Sean McBride authored
      These changes are more invasive than my previous conversions.
      a) Some private/protected method signatures now take a size parameter.
      b) Deleted vtkMPEG2Writer entirely, because 1) it uses sprintf and I can’t find the size of the buffer, I think it’s been removed. 2) The class hasn’t been built in years.
      c) some new defines introduced to avoid copy-pasting magic numbers.
      
      The only remaining sprintf, I think, are in third party or C code.
      5c238b17
  9. 07 Mar, 2017 1 commit
    • Utkarsh Ayachit's avatar
      Use vtk_module_export_code_find_package() for Qt4. · df741f7c
      Utkarsh Ayachit authored
      Similar to what we're doing with Qt5, this change now adds called to
      vtk_module_export_code_find_package() for Qt4. That way, when importing
      a module using Qt4, we automatically find Qt4.
      
      Also changed to use imported targets rather than library paths when
      linking to Qt4 libraries.
      df741f7c
  10. 16 Jan, 2017 1 commit
  11. 23 Sep, 2016 2 commits
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
    • David E. DeMarle's avatar
      replace VTK's nonstandard Doxygen with standard markup · 6a7e5148
      David E. DeMarle authored
      generated via:
      cd $VTKSRC
      perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
      cp -r ~/tmp/vtkheaders/* .
      6a7e5148
  12. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  13. 19 Aug, 2016 1 commit
    • Bill Lorensen's avatar
      ENH: Introduce vtkMTimeType · 9333d9d1
      Bill Lorensen authored
      This is a fix for:
      vtk/vtk#14310
      
      Windows applications that run for a long time report that rendered
      objects do not change. This is because the modified time on a Windows
      system is 32 bits. This causes overflows that defeat the modified time
      mechanism. This patch defines a new type, vtkMTimeType that is 64
      unsigned integer regardless of the architecture.
      
      A mechanism to provide backward compatibility is introduced. The
      preprocessor define "VTK_HAS_MTIME_TYPE" can be used in applications
      that must build against VTK versions that use the "unsigned long" type
      for MTime's.
      
      Methodology used to find MTime occurences:
      1) Identify files as follows:
         git grep "unsigned long" | grep ime | cut -d":" -f1,1 | sort | uniq
      2) Hand edit each of those files replacing "unsigned long" with
         "vtkMTimeType" where appropriate.
      3) Temporarily change typedef for vtkMTimeType to "double" to detect
         missing conversions
      9333d9d1
  14. 27 Jul, 2016 1 commit
    • Utkarsh Ayachit's avatar
      Cleanup QT5. · e1fe01a6
      Utkarsh Ayachit authored
      In module configuration files generated for Qt-based modules, we now
      export find_package() calls that find specific components from Qt5 i.e.
      `find_package(Qt5 COMPONENTS Widgets)` instead of
      `find_package(Qt5Widgets)`.
      e1fe01a6
  15. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  16. 25 May, 2016 1 commit
    • Kitware Robot's avatar
      Remove all BTX and ETX markers from VTK headers · 4d127b1d
      Kitware Robot authored
      Perl was used to remove all the BTX and ETX markers from the code.
      The specific command that was run on all "vtk*.h" files was this:
          perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'
      
      This regex replaces each BTX/ETX line, plus any leading or trailing
      blank lines, with a single blank line.
      4d127b1d
  17. 06 May, 2016 1 commit
    • David C. Lonie's avatar
      Replace SafeDownCast calls on arrays with vtkArrayDownCast. · 0d71a308
      David C. Lonie authored
      SafeDownCast performs a series of virtual calls and string comparisons,
      which is quite slow, especially when used in worker functions.
      
      vtkArrayDownCast will switch between SafeDownCast and the more
      efficient FastDownCast (only available for common vtkAbstractArray
      subclasses) depending on whether or not FastDownCast is defined for
      the specific array type.
      0d71a308
  18. 08 Mar, 2016 1 commit
  19. 22 Feb, 2016 1 commit
  20. 28 Jan, 2016 1 commit
  21. 14 May, 2015 1 commit
  22. 29 Apr, 2015 1 commit
  23. 06 Apr, 2015 1 commit
  24. 18 Dec, 2014 1 commit
  25. 03 Jul, 2014 1 commit
    • Ben Boeckel's avatar
      linking: wrap tll() with a module-aware function · 3cd0686a
      Ben Boeckel authored
      This will allow kits to gather all of the required libraries to link
      since the modules themselves won't "exist" to link anything when kits
      are enabled.
      
      Change-Id: Ic73220c7b97e17a5fbc0aa6c0f7a5e5a61dc6bef
      3cd0686a
  26. 07 May, 2014 1 commit
    • Brad King's avatar
      Export the locations of Qt5 packages on which modules depend · 23fbbebc
      Brad King authored
      Qt5 packages provide libraries to VTK in the form of imported targets.
      VTK libraries that link to them get exported with dependencies on the
      imported targets.  We must make them available to applications that link
      to these VTK libraries too.
      
      Teach each module that depends on Qt5 to export code that runs when
      an application loads the module as part of its build process.  Find
      the needed Qt5 package on behalf of the application to satisfy the
      module's dependency on it.
      
      Change-Id: Ib638ccafa084fbb06c20eb09464265501ccafc80
      23fbbebc
  27. 12 Nov, 2013 1 commit
  28. 30 Sep, 2013 2 commits
  29. 19 Aug, 2013 1 commit
    • Brad King's avatar
      COMP: Cleanup CMP0022 and CMP0023 warnings · ed6c07d0
      Brad King authored
      CMake 2.8.12 introduces policies CMP0022 and CMP0023 that trigger
      warnings in some of VTK's CMake code.  Fix them as follows.  The result
      is a cleaner and more explicit link specification anyway.
      
      CMP0022 warns when we set the LINK_INTERFACE_LIBRARIES property directly
      without also setting the newly introduced INTERFACE_LINK_LIBRARIES
      property directly.  Simply drop these settings because they are achieved
      already by use of the keyword-based target_link_libraries signature.
      
      CMP0023 warns when we use both the plain and keyword signatures of the
      target_link_libraries command for a single target.  The module macros
      use the keyword signature (LINK_PUBLIC/LINK_PRIVATE), so any direct
      calls to the plain target_link_libraries signature are doing "private"
      linking.  Add the LINK_PRIVATE keyword to such calls to make this
      explicit and avoid the warning.
      
      Change-Id: I1e5bf687733e3f19462da698c0d5e3899439bf02
      ed6c07d0
  30. 27 May, 2013 1 commit
    • Jean-Christophe Fillion-Robin's avatar
      COMP 12945: Allow VTK to build against Qt5 · 384636ec
      Jean-Christophe Fillion-Robin authored
      Since VTK build system has been updated to make use of CMake macros
      specific to Qt5, the support has to explicitly enabled configuring VTK
      with -DVTK_QT_VERSION:STRING="5"
      
      Additionally, in case Qt5 is not installed in a standard location,
      a custom prefix for "find_package" should be passed.
      For example:
        -DCMAKE_PREFIX_PATH:STRING=/home/jchris/Qt5.0.2/5.0.2/gcc_64/
      
      
      Finally, this commit also resolves the build errors reported below.
      
      Fix missing header build error by including Qt headers directly without
      specifying the intermediate directory.
      
      * Fix build error changing QString::toAscii into  QString::toLatin
      The method "toAscii" has been deprecated and is not available in
      default Qt5 distribution.
      See http://qt-project.org/doc/qt-5.0/qtcore/qstring.html#toAscii
      
      * Fix build error changing Qt::WFlags into Qt::WindowFlags
      See http://qt-project.org/doc/qt-5.0/qtcore/qt-obsolete.html
      
      * Fix build error changing QAbstractItemModel::reset() into
      combo QAbstractItemModel::beginResetModel()/QAbstractItemModel::endResetModel()
      The method "reset" has been deprecated and is not available in
      default Qt5 distribution.
      See http://qt-project.org/doc/qt-5.0/qtcore/qabstractitemmodel-compat.html#reset
      
      * Fix build error by including "vtkObjectBase.h":
      /home/jchris/Projects/Qt5.0.2/5.0.2/gcc_64/include/QtCore/qmetatype.h:464: error: invalid application of ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’
      
      * Fix "no matching function for call to ‘QPixmap::grabWidget(QWidget*)’" by using
      "QWidget::grab"
      See http://qt-project.org/doc/qt-5.0/qtwidgets/qwidget.html#grab
      
      * Fix missing QHttpHeader/QHttpRequestHeader headers by removing them.
      They have been removed from Qt5 and were not used in the code.
      
      * Fix error: ‘qInstallMsgHandler’ was not declared in this scope
      by using "qInstallMessageHandler"
      See http://qt-project.org/doc/qt-5.0/qtdoc/sourcebreaks.html
      
      * Fix Q4VTKWidgetPlugin.cxx:147: error: invalid application of
      ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’ by
      using "Q_PLUGIN_METADATA" macro instead of Q_EXPORT_PLUGIN
      or Q_EXPORT_PLUGIN2.
      See http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5#7ec1b8f08d7f31ebcb53188f0bd15ed5
      
      Change-Id: Ie7123e5990e3a8afb4d7d2efa0fda5bd7b98c1e3
      384636ec
  31. 13 Dec, 2012 1 commit
    • David C. Lonie's avatar
      Add multiline, justification, and shadows to vtkFreeTypeTools. · 6dd7b574
      David C. Lonie authored
      Also, explicitly return text dimensions from text rasterization
      functions. Older hardware requires texture image dimensions to be
      powers of 2. Since the text will only be rendered into a portion of
      the image in these cases, the text dimensions are needed to calculate
      the texture coordinates during rendering.
      
      Some classes were hiding the text dimensions in the image metadata, e.g.
      texture coordinates and text dimensions were stored in Spacing and Origin.
      This undocumented behavior was confusing and unintuitive.
      
      Now functions that rendering scaled images explicitly return the text
      dimensions.
      
      Change-Id: Ic74b0dd9573d336427038985c671a8b724c92429
      6dd7b574
  32. 09 Apr, 2012 3 commits
    • VTK Developers's avatar
      Remove trailing whitespace from all source files · 2d323fc4
      VTK Developers authored
      Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
      are maintained outside VTK.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      2d323fc4
    • VTK Developers's avatar
      Include module-wide headers and export macros · 144f03ca
      VTK Developers authored
      Include the module-wide header from every header in each module.
      Reference the export/visibility macro for the module.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      144f03ca
    • VTK Developers's avatar
      Add modular VTK build system · 0c1471f1
      VTK Developers authored
      Add module.cmake, CMakeLists.txt, and other build system files.
      
      The modular VTK build system is not yet mature.  The monolithic build
      files had a lot of infrastructure.  The modular build files reproduce
      much of the functionality but some features will need to be restored
      later.  Document status and tasks in "TODO-Modularization.txt".
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      0c1471f1