GitLab

At 0.0 the vtkFiltersAMRCxx-TestImageToAMR test would divide by zero
(giving nan) then convert that to int (which is undefined).

Found by clang's UBSan.

Also removed some dead code as a consequence,
like setting the deallocated pointer to null
then to a new address.

Also removed setting some ivars to null in dtors.

Co-authored-by: Yuanxin Liu <leo.liu@kitware.com>
Co-authored-by: Berk Geveci <berk.geveci@kitware.com>

 -The semantics of each unsigned char in the ghost arrays changes:
  Instead of storing a numeric value representing how far a cell is
  from the boundary, it is now a bit field specified by
  vtkDataSetAttributes::CellGhostTypes and
  vtkDataSetAttributes::PointGhostTypes.  The bit field is consistent
  with VisIt specs.

- Previously, filters strip all ghost cells they request from upstream
  before finalizing the output. This is no longer done.

- vtkUniform grids previously supported blanking through member arrays
  vtkUniformGrid::CellVisibility and
  vtkUniformGrid::PointVisibility. These arrays are removed and the
  blanking functionality are supported through the new ghost arrays
  instead.

- the "vtkGhostLevel" arrays for cell and point data are renamed to
  vtkDataSetAttributes::GhostArrayName() ("vtkGhostType").

- the version for VTK Legacy files is increased to 4.0 and the version for
  VTK XML files is increased to 2.0. When reading older files we
  convert vtkGhostLevels array to vtkGhostType.

Now that the VTK wrappers and all supported compilers can handle
using declarations, it is no longer necessary to override all method
signatures within the subclasses.

\Filters\Statistics\vtkOrderStatistics.cxx(346): error C2440: 'initializing' : cannot convert from 'lldiv_t' to 'div_t'

Interesting case.  Due to changing one of the params to div()
from int to vtkIdType (which can be long, long long, int, etc.)
the templated div() changed to one that returned the lldiv_t
struct instead of the div_t structure.

Switched to ldiv() because there seems to be only one version of it.

Specifically:
Filters/Sources/vtkHyperOctreeFractalSource.h:84: warning: comparison is always false due to limited range of data type

Reverted part of 5700d2ee.

Added explicit comparison with zero

Fixes many -Wconversion warnings.
Changes made where it makes sense, ex to match return type of method.

Fixed one or the other to match.

Found with clang -Wunused-member-function or
-Wunreachable-code.

Fixes clang -Wmissing-variable-declarations warnings

Change-Id: I7a52e4c73f331c56193e622d43d3e2a87f184293

A few good fixes in here that are all related. The biggest is a
fix to OpenGLActor to use the more comprehensive GetIsOpaque
method in determining if an actor is opaque. The old code only
looked at the property's opacity. This is why you would see folks
setting somethings opacity to 0.99 to get it treated as translucent
because the actor code wasn't handling it correctly. This change
resulted in 3 new valid images for tests that were rendering
translucent items as if they were opaque. I removed these tests
from the old backend as I did not want to change the behavior
for that backend.

Next up is depth peeling. OpenGL2 depth peeling would render
a number of peels up to the limit and then just stop. Any geometry
left between the opaque layer and the last translucent layer was
just thrown out.  This created very noticable artifacts and was bad.
This change makes it so that when it gets to the last pass, it will
render all remaining geometry using alpha blending. This is much
better. Fix example if you get the limit to 20 layers and 20 was
not enough to render all the geometry, this change renders 19
layers using depth peeling, then in the 20th render it would add
in all the remaining geometry as last layer. That last layer may
have overlapping geometry which is rendered using alpha blending.

Finally some changes to the PointGaussianMapper. It turns out that
the point gaussian mapper is an translucent mapper which means it
needs the first change, and it is a very tough case for depth peeling
resulting in the second change. While at it I modified this mapper
to render far fewer fragments, resulting is far fewer overlapping
layers and fewer artifacts. Really when using PointGaussian you
should turn off depthpeeling as it is not needed and actually makes
it worse, but these changes will make it better if you happen to have
it on.  Also cleaned up the mapper so that the radius is equal to
the standard devisation of the gaussian, previously it was four
standard deviations.

Change-Id: I62d90b6e424ac0e939033387ed10ba8caac66095

Also added missing print out of member variable.

Change-Id: I9ea62ea7c60545fa2a6a5552c8dd8b98d2fdd093

Change-Id: I5bf72a09660ad7bb3acf5596ce7be6fe114a8aeb

It was complaining that string->bool is always true

Change-Id: I9fa9da2a093a188566be38a914565a0d0e6b749e

Change-Id: I423d2494106f1637f97e803a483b57fb5c70468d

Change-Id: I5573964542026cb3c62d734041d8bb81c3189961

Also, fixed up and re-enabled vtkSplineRepresentationTest1.

Change-Id: Ied08e18ed3909ca36fde9863dc68e3711d4b8efe

Change-Id: I7862639b1a66c9d08e22be52327a1988a67c5ac6

This is required for std::max() and std::min().

I think (but don't quote me on this) that the older MSVC
compilers used to automatically include a MSVC specific
header called xutility where these were defined.
With respect to other comilers e.g. gcc, it is possible
that one of the other includes is adding the algorithm header in.

Change-Id: I3a51bf7013a838f7e1d696595a43735225a59452
Signed-off-by: Andrew Maclean <andrew.amaclean@gmail.com>

Change-Id: I4b1b0aebb59bdb58e88c1b284d08a87620275a3b

Change-Id: I2793cb7382f43fd2fb4a1f15df9f45399f41bd93

Add an SMP based implementation of vtkSynchronizedTemplatesCutter3D and a Test program.

Change-Id: I16da6db5f4a34c28cea202cc0cec8d748f374539

Change-Id: I17b99c887200f98c614bbbcb413db784da6075db

cppcheck warned because the later check involved an
index that’s used in the earlier check.  That could
easily be backwards if the index is not in range
without the check happening first.

Change-Id: Iaa79b07bb1eccd51db5e27252ab83d39f8e8b2f2

Change-Id: I2d81fe807e22d50913a57fa63c934deadc8e0787

Fixes cppcheck warning, should be a little faster

Change-Id: I24ebe2085e2f1c771d2a83fba6ebfb8761cfb9ab

Change-Id: Idea4b83c8554c927e17196d227676b4db5f38c32

Change-Id: Ieadbc4b11706f022d113cf975ef7db6ea5bb0f55

Found by cppcheck. Previously condition was always
true and assert could never fire.

Change-Id: I6d78a7494afce165877da9b5931a9d17616a7868

Change-Id: I4e3872ea3e35e5afaa9ee9f3c34a75d88036e45b

The vtkGeometryFilter assumed that vtkPolyData cells were traversed
in verts, then lines, then polys and finally triangle strips and
thus outputted cell data in that order. This is not the order that
polydata cells are iterated over though. Thanks to Andreas Buykx
for the patch that this fix is based on.

Change-Id: If5958b24f6b5d66e514667e504e94a3badabee9a

Change-Id: I1e3c341f1f6a1ab2ce2d907102eaadd46125d29b

Added SMP based implementation of vtkSynchronizedTemplates3D and a test for it.

Change-Id: I8349e343ddb421732c087bccd915d021d469d720