Commit ead181a7 authored by Ken Martin's avatar Ken Martin Committed by Kitware Robot

Merge topic 'faster_shaders'

e9ed1848 some performance improvements for the OpenGL2 shader
Acked-by: Kitware Robot's avatarKitware Robot <>
Reviewed-by: Utkarsh Ayachit's avatarUtkarsh Ayachit <>
Merge-request: !1898
parents b6c10579 e9ed1848
Pipeline #24528 running with stage
in 180 minutes and 50 seconds
This diff is collapsed.
......@@ -207,6 +207,20 @@ public:
// name.
bool IsAttributeUsed(const char *name);
// maps of std::string are super slow when calling find
// with a string literal or const char * as find
// forces construction/copy/destruction of a
// std::sting copy of the const char *
// In spite of the doubters this can really be a
// huge CPU hog.
struct cmp_str
bool operator()(const char *a, const char *b) const
return strcmp(a, b) < 0;
......@@ -284,10 +298,11 @@ protected:
std::string Error;
std::map<std::string, int> AttributeLocs;
std::map<std::string, int> UniformLocs;
// since we are using const char * arrays we have to
// free our memory :-)
void ClearMaps();
std::map<const char *, int, cmp_str> AttributeLocs;
std::map<const char *, int, cmp_str> UniformLocs;
friend class VertexArrayObject;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment