Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 772
    • Issues 772
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 211
    • Merge requests 211
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTKVTK
  • Merge requests
  • !8897

Object name for reporting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andreas Buykx requested to merge bxa/vtk:objectname into master Feb 11, 2022
  • Overview 70
  • Commits 1
  • Pipelines 13
  • Changes 14

Error and warning messages from pipeline execution currently show only the class name and pointer. This is usually insufficient to determine for example which specific algorithm raises the error.

This change introduces an object name for vtkObject. The object name is stored as a string member ObjectName with setter and getter. It is not a regular ivar: the MTime is not affected and no ModifiedEvent is invoked when the objectname is changed. The objectname is not to be copied by ShallowCopy and DeepCopy implementations.

A new virtual method on vtkObjectBase, GetObjectDescription, returns the description that is used in error and warning messages and Print output. The vtkObjectBase implementation returns the class name and object pointer. The vtkObject implementation overrides this and prints the object name as well if it is set.

The error messages issued by vtkExecutive classes now call the GetObjectDescription method of the algorithm so that if an algorithm has an object name it appears in the error message.

Added a python test to demonstrate the behavior and a changelog entry to briefly describe this change.

Edited Feb 14, 2022 by Andreas Buykx
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: objectname