Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 740
    • Issues 740
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 195
    • Merge requests 195
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTKVTK
  • Merge requests
  • !8222

Improve probe over line

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timothee Chabat requested to merge timothee.chabat/vtk:improvePlotOverLine into master Jul 27, 2021
  • Overview 61
  • Commits 2
  • Pipelines 11
  • Changes 5

Main improvements :

  • Use cell locators for computing the intersection with the line
  • Remove useless duplication of points 1 and points 2

Benchmark:

(this is a oneshot benchmark and has not been averaged among multiple runs)


  • Former implementation, Wavelet 200^3: 1922.89 ms
  • New Implementation, Wavelet 200^3: 4475.07 ms
  • New Implementation, Wavelet 200^3, 2nd execution (locators are cached): 16.07 ms

  • Former implementation, UG 200^3: 3431.68 ms
  • New Implementation, UG 200^3: 3210.71 ms
  • New Implementation, UG 200^3, 2nd execution (locators are cached): 16.42 ms

The UG was produced by vtkCellTypeSource with cell type HEX.


Summary

New implementation is always better if we do more than one execution. Else it has similar performance for point sets and is 2 times slower for image datas. Also for small datasets new implementation is always faster.

Edited Aug 05, 2021 by Timothee Chabat
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: improvePlotOverLine