Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 850
    • Issues 850
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 235
    • Merge requests 235
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTKVTK
  • Merge requests
  • !7031

update ray tracing for compatibility with OSPRay 2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David E. DeMarle requested to merge demarle/vtk:ospray2.x into master Jun 18, 2020
  • Overview 83
  • Commits 6
  • Pipelines 19
  • Changes 60

This update allows us to access volumetric path tracing and other new features of OSPRay 2 in VTK.

However, since OSPRay2's raycast or "scivis" renderer is simpler than OSPRay1's was, we lose shadows, multiple and colored light sources, gradient shaded volumes, and specular highlights in that context. The regression tests and baselines have been adjusted accordingly.

This commit compresses a long development branch by Carson Brownlee and David DeMarle. A selection of the commit message are as follows:

  • style fixes for ospInit and ospShutdown call sites

    Returning ospShutdown resulted in segfaults in OpenVKL. So let's leave it as always on once started. VisRTX does the same and we've done it this way in earlier releases so it will probably be fine.

  • restore temporal caching

    New approach is to simply cache the entire scene instead of individual props.

  • Update the ospray isosurface baseline image.

    Comparing with GL shows that the new version is more similar to GL so it is valid.

  • remove volume rendering sample adjustments

    The adjustments we had for osp1.8 seem to make matters worse such that several OSPRay tests (Caching, Perspective) render a volume that is so translucent that it is almost invisible. Without them osp2 seems to automagically do the right thing.

    On the negative side, this means that we no longer take VolumeProperty->ScalarOpacityUnityDistance into consideration.

  • compensate for lack of gradient shading in ospray2 vol rendering

    until ospray 2 gets diffuse volume shading, turn off shading and update baselines.

  • compensate for raycaster lighting limitations

    until ospray2 raycaster gets colored lights, switch these two tests over to pathtracer to make them happy.

    Also add a new alternate image for the lights test because path tracer is much brighter in corner than ray caster is.

  • update to ospray 2's revised material names

    To save a bit on runtime cost, we only provide backward compatibility at material library file parsing. In other words, user code that calls MakeMaterial() directly may have be updated.

  • changing ospray version number to 2.1

  • restructuring renderer to use list of instances instead of models.

Edited Jul 12, 2020 by David E. DeMarle
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ospray2.x