Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 778
    • Issues 778
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 212
    • Merge requests 212
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTKVTK
  • Merge requests
  • !5647

Properly qualify const expressions used by wrappers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Gobbi requested to merge dgobbi/vtk:wrap-qualify-consts into master Jun 10, 2019
  • Overview 5
  • Commits 2
  • Pipelines 1
  • Changes 4

When the wrappers come across an expression that is used as default parameter value, e.g. "x=SomeType::SomeVal", they must add qualifiers as necessary so that the wrapper code will compile. For example, the qualified expression might be "vtkMyClass::SomeType::SomeVal".

There was already some code in the wrappers that did this, but it was only able to handle constants that were members of the class, and wasn't capable of handling typedefs or enum classes. The new code is more compact and more complete.

Edited Jun 10, 2019 by David Gobbi
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: wrap-qualify-consts