Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 754
    • Issues 754
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 209
    • Merge requests 209
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTKVTK
  • Merge requests
  • !1790

ENH: Introduce vtkMTimeType

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bill Lorensen requested to merge lorensen/vtk:MTime into master Aug 09, 2016
  • Overview 55
  • Commits 1
  • Pipelines 1
  • Changes 473

This is a fix for: #14310 (closed)

Windows applications that run for a long time report that rendered objects do not change. This is because the modified time on a Windows system is 32 bits. This causes overflows that defeat the modified time mechanism. This patch defines a new type, vtkMTimeType that is 64 unsigned integer regardless of the architecture.

A mechanism to provide backward compatibility is introduced. The preprocessor define "VTK_HAS_MTIME_TYPE" can be used in applications that must build against VTK versions that use the "unsigned long" type for MTime's.

Methodology used to find MTime occurences:

  1. Identify files as follows: git grep "unsigned long" | grep ime | cut -d":" -f1,1 | sort | uniq
  2. Hand edit each of those files replacing "unsigned long" with "vtkMTimeType" where appropriate.
  3. Temporarily change typedef for vtkMTimeType to "double" to detect missing conversions
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: MTime