Skip to content

Consider QVTK* headers in WhatModulesVTK.py

Elvis Stansvik requested to merge estan/vtk:what-modules-script-fixes into master

Headers installed by the Qt and QtOpenGL modules in GUISupport use this header naming convention. This change lets the script identify that including QVTKWidget.h means you depend on the vtkGUISupportQt module, for instance.

Here's an example:

estan@newton:~/orexplore/VTK$ cat test.cpp 
#include <vtkSmartPointer.h>
#include <QVTKWidget.h>

Before this change

estan@newton:~/orexplore/VTK$ ./Utilities/Maintenance/WhatModulesVTK.py . test.cpp 
Modules and their dependencies:
find_package(VTK COMPONENTS
  vtkCommonCore
  vtkkwiml
)
Your application code includes 2 of 189 vtk modules.

All modules referenced in the files:
find_package(VTK COMPONENTS
  vtkCommonCore
)
Your application code includes 1 of 189 vtk modules.

Minimal set of modules:
find_package(VTK COMPONENTS
  vtkCommonCore
)
Your application code includes 1 of 189 vtk modules.

After this change

estan@newton:~/orexplore/VTK$ ./Utilities/Maintenance/WhatModulesVTK.py . test.cpp 
Modules and their dependencies:
find_package(VTK COMPONENTS
  vtkCommonColor
  vtkCommonCore
  vtkCommonDataModel
  vtkCommonExecutionModel
  vtkCommonMath
  vtkCommonMisc
  vtkCommonSystem
  vtkCommonTransforms
  vtkGUISupportQt
  vtkImagingCore
  vtkInteractionStyle
  vtkRenderingCore
  vtkRenderingOpenGL
  vtkkwiml
)
Your application code includes 14 of 189 vtk modules.

All modules referenced in the files:
find_package(VTK COMPONENTS
  vtkCommonCore
  vtkGUISupportQt
)
Your application code includes 2 of 189 vtk modules.

Minimal set of modules:
find_package(VTK COMPONENTS
  vtkCommonCore
  vtkGUISupportQt
)
Your application code includes 2 of 189 vtk modules.

Merge request reports