Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 740
    • Issues 740
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 197
    • Merge requests 197
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTKVTK
  • Merge requests
  • !1592

Fix multiple definitions of vtkInteractionCallback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Max Smolens requested to merge msmolens/vtk:fix-multiple-vtkinteractioncallback-classes into master Jun 27, 2016
  • Overview 16
  • Commits 2
  • Changes 3

A class called vtkInteractionCallback was defined twice: in vtkImplicitCylinderWidget.cxx and in vtkImplicitPlaneWidget2.cxx. This violates the one definition rule and can lead to undefined behavior.

This commit resolves the ambiguity by removing the callback from vtkImplicitCylinderWidget. vtkImplicitCylinderWidget does not actually require the callback; the code is leftover from a copy/paste of vtkImplicitPlaneWidget2. vtkImplicitPlaneWidget2 uses the callback to implement SetLockNormalToCamera(), which does not exist on vtkImplicitCylinderWidget.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-multiple-vtkinteractioncallback-classes