Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 759
    • Issues 759
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 205
    • Merge requests 205
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTKVTK
  • Issues
  • #18456
Closed
Open
Created Feb 04, 2022 by Jean-Christophe Fillion-Robin@jcfrDeveloper

Remove duplicated class vtkTextureArray

Occurrences:

  • Interaction/Widgets/vtkTexturedButtonRepresentation2D.cxx
  • Interaction/Widgets/vtkTexturedButtonRepresentation.cxx

This was discovered while working on !8885 (merged).

It is important to avoid duplicated symbol names to avoid violating the ODR (One Definition Rule).

For some more context, see https://discourse.slicer.org/t/transition-of-nightly-build-from-vtk-9-0-20201111-to-9-1-20220125/21669/

Proposal approaches:

  1. Move each vtkTextureArray to vtkTexturedButtonRepresentation::vtkTextureArray and vtkTexturedButtonRepresentation2D::vtkTextureArray

  2. Rename vtkTextureArray respectively to vtkTexturedButtonRepresentationTextureArray and vtkTexturedButtonRepresentation2DTextureArray

  3. Identify similar use of text array in the toolkit and create a dedicated vtkTextureArray class

I suggest to move forward with approach 1

cc: @ken-martin

Assignee
Assign to
Time tracking