Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK VTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 830
    • Issues 830
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 232
    • Merge requests 232
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTKVTK
  • VTKVTK
  • Issues
  • #17961
Closed
Open
Issue created Jul 15, 2020 by Yohann Bearzi@yohann.bearziDeveloper

Bug in `vtkQuad::IntersectWithLine`

If you look at vtkQuad::IntersectWithLine, you should notice that d1 == 0 and d2 == 0 because the distance is computed between 2 points sharing the same memory address. Indeed, vtkPoints::GetPoint returns an internal buffer that always points to the same address.

I fixed this bug in a branch, but it turns out that it breaks a test. Fixing this bug only impacts non-planar quads.

Looking at that, it makes me wonder why should non-planar quads be treated in this algorithm, because there are 2 ways to tesselate it, and choosing the tesselation strategy is very much arbitrary. If one wants non-planar quads, one should probably use a vtkNonLinearCell. At least the user would know beforehand what its cell looks like.

Should we fix the code keeping the same tesselation strategy and update the failing baseline, or should we simplify the intersection detection assuming that a vtkQuad is always planar?

Edited Jul 15, 2020 by Yohann Bearzi
Assignee
Assign to
Time tracking