GitLab

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

This fix selects std::unique_ptr when the compiler is identified as being C++11
 compliant.

To ensure the compiler is C++11 compliant or better, __cplusplus, _MSC_VER and
_CPPLIB_VER are tested.
_MSC_VER is used since Microsoft compilers still use 19711L
 as the __cplusplus value.
_CPPLIB_VER is used to test for better Dinkumware support.

The variable VTK_HAS_STD_UNIQUE_PTR is defined if std::unique_ptr is available.

Perl was used to remove all the BTX and ETX markers from the code.
The specific command that was run on all "vtk*.h" files was this:
    perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'

This regex replaces each BTX/ETX line, plus any leading or trailing
blank lines, with a single blank line.

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

Find/replace of:

with C++ counterparts.  Changed only vtk*.cxx files.
Didn’t touch .h or .c or any 3rd party.

VTK no longer supports any compilers/platforms on which the
C++ streams have buggy EOF handling.  Drop our compatibility
layer for this case.

Use std::auto_ptr instead.

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

Also removed some dead code as a consequence,
like setting the deallocated pointer to null
then to a new address.

Also removed setting some ivars to null in dtors.

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

Added error checks in XMLDataParser to return a failing status for bad
headers. Added a test that reads bad image data, poly data,
rectilinear grid data, uniform data and unstructured grid data.

Change-Id: I2284cbe0cebb1934994096bbe64e2492062d33c9

Change-Id: If4c8bae0d8811a42b1606dc5f48108508739df4e

The main kits are:

    vtkCommon
    vtkFilters
    vtkIO
    vtkImaging
    vtkInteraction
    vtkOpenGL (required due to a dependency cycle from
               vtkRenderingOpenGL on vtkImagingHybrid)
    vtkParallel
    vtkRendering
    vtkViews
    vtkWrapping

Modules which deal with a specialization of another module belong to the
kit related to the specialization (i.e., FiltersParallel and
IOParallelXML both belong to the vtkParallel kit) to avoid circular
dependencies that arise when put into the same kit as the "lesser"
module.

Change-Id: Icae0baa78d62cc0dcce84546541df600d4f311dd

Done using a few regular expressions & find & replace.
Fixes many -Wextra-semi warnings.

Change-Id: I5ef603e88d4c0a390cfb2d22d8d92c21bf554024

Change-Id: I94935b6fe4d5e76e453507f9387b5ca357286cab

A simple implementation of private dependencies, with some of the most
obvious private dependencies moved over. This should be used for all
dependencies that are not exposed in the public API of the classes in
the module.

The target_link_libraries call defaults to private due to the way CMake
implements the link logic. The private dependency logic can help reduce
link line and include directory length for private links where the
dependency's API is not exposed in the module. Also added code to ensure
include directories are not duplicated for modules in the build tree.

Change-Id: If4535338e8d5e9957d7bcce7d3ab0eadec21d2c4

Just added 'static' in front of many private functions.

Change-Id: I892a46d684e00a44e7f84a7343e2cf5690f07eed

I exposed several data members through getters in order
to be able to develop custom readers in Python. Also added a
hint to export GetUpdateExtent() to Python. In this particular
case, I am combining the XML reader and the MPIImageReader
to read a structured grid. The XML reads the meta data, the
MPIImageReader reads the appended data using MPI/IO.

Change-Id: I7877ecc68f8b200f56ea258eca3bf871feccaaf5

Some of the module dependencies were somewhat weird, like
IOImage depending on IOGeometry and Rendering depending on
XML which contains all XML reader. Fixed the depency problems
by creating XMLParser and Movie modules and moving some
classes to them. I also moved many classes to RenderingCore
because they were only needed there.
One other minor change is to change vtkProperty to use
vtkImageReader2Factor such that it didn't explicitely depend
on bunch of reader. This will allow us to add/remove readers
to IOImage more easily.

Change-Id: Iaaa2edffd31193c13a4ef59e5be5b3eeada3501e