1. 12 Sep, 2016 24 commits
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
      6e113ad4
  2. 07 Jul, 2016 24 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  3. 08 Mar, 2016 24 commits
  4. 28 Jan, 2016 24 commits
  5. 06 Apr, 2015 24 commits
  6. 26 Mar, 2015 24 commits
  7. 13 Mar, 2015 24 commits
    • David Gobbi's avatar
      BUG 15358: Remove inappropriate cast from pointer to long. · bdc156e2
      David Gobbi authored
      Fix some code that was written many years before 64-bit Windows
      existed.  A pointer was being cast to "long".  Ironically, the
      cast was unnecessary because the method accepts "void *".
      
      Change-Id: If1095b55523379b880408e84df4e982870152c04
      bdc156e2
  8. 01 Mar, 2015 24 commits
  9. 18 Dec, 2014 24 commits
  10. 02 Sep, 2014 24 commits
    • David Cole's avatar
      Rendering: Use AdjustWindowRect to ensure pixel perfect client size · 4386c035
      David Cole authored
      Continuing in the vein of commit 5f8b3c0c this commit eliminates more
      (less often seen) calls to GetSystemMetrics to yield proper window
      sizing by calling AdjustWindowRect. This takes window borders into
      account properly across more versions of Windows.
      
      Change-Id: I140da2959266f0292223e0b495b33b9230049ba7
      4386c035
  11. 03 Jul, 2014 24 commits
    • Ben Boeckel's avatar
      linking: wrap tll() with a module-aware function · 3cd0686a
      Ben Boeckel authored
      This will allow kits to gather all of the required libraries to link
      since the modules themselves won't "exist" to link anything when kits
      are enabled.
      
      Change-Id: Ic73220c7b97e17a5fbc0aa6c0f7a5e5a61dc6bef
      3cd0686a
    • Ben Boeckel's avatar
      modules: add modules to "kits" · e5203447
      Ben Boeckel authored
      The main kits are:
      
          vtkCommon
          vtkFilters
          vtkIO
          vtkImaging
          vtkInteraction
          vtkOpenGL (required due to a dependency cycle from
                     vtkRenderingOpenGL on vtkImagingHybrid)
          vtkParallel
          vtkRendering
          vtkViews
          vtkWrapping
      
      Modules which deal with a specialization of another module belong to the
      kit related to the specialization (i.e., FiltersParallel and
      IOParallelXML both belong to the vtkParallel kit) to avoid circular
      dependencies that arise when put into the same kit as the "lesser"
      module.
      
      Change-Id: Icae0baa78d62cc0dcce84546541df600d4f311dd
      e5203447
  12. 22 Jan, 2014 24 commits
    • Sean McBride's avatar
      Misc cleanup of code nearby clang analyzer warnings. · 5ff4c6b0
      Sean McBride authored
      No warnings were actually fixed.  Removed some unnecessary checks for null before delete(), changed some variables used as booleans to real 'bool's, moved some declarations together with initial assignment, made some private globals static.
      
      Change-Id: I76d54ae907dc504866576df935c9a47e71785f68
      5ff4c6b0
  13. 19 Aug, 2013 24 commits
    • Brad King's avatar
      COMP: Cleanup CMP0022 and CMP0023 warnings · ed6c07d0
      Brad King authored
      CMake 2.8.12 introduces policies CMP0022 and CMP0023 that trigger
      warnings in some of VTK's CMake code.  Fix them as follows.  The result
      is a cleaner and more explicit link specification anyway.
      
      CMP0022 warns when we set the LINK_INTERFACE_LIBRARIES property directly
      without also setting the newly introduced INTERFACE_LINK_LIBRARIES
      property directly.  Simply drop these settings because they are achieved
      already by use of the keyword-based target_link_libraries signature.
      
      CMP0023 warns when we use both the plain and keyword signatures of the
      target_link_libraries command for a single target.  The module macros
      use the keyword signature (LINK_PUBLIC/LINK_PRIVATE), so any direct
      calls to the plain target_link_libraries signature are doing "private"
      linking.  Add the LINK_PRIVATE keyword to such calls to make this
      explicit and avoid the warning.
      
      Change-Id: I1e5bf687733e3f19462da698c0d5e3899439bf02
      ed6c07d0
  14. 14 Aug, 2013 24 commits
    • Marcus D. Hanwell's avatar
      Add support for private dependencies in VTK · 57901457
      Marcus D. Hanwell authored
      A simple implementation of private dependencies, with some of the most
      obvious private dependencies moved over. This should be used for all
      dependencies that are not exposed in the public API of the classes in
      the module.
      
      The target_link_libraries call defaults to private due to the way CMake
      implements the link logic. The private dependency logic can help reduce
      link line and include directory length for private links where the
      dependency's API is not exposed in the module. Also added code to ensure
      include directories are not duplicated for modules in the build tree.
      
      Change-Id: If4535338e8d5e9957d7bcce7d3ab0eadec21d2c4
      57901457
  15. 03 Apr, 2013 24 commits
    • Sean McBride's avatar
      Removed VS6 and VS7 workarounds · de8eae2b
      Sean McBride authored
      Assume that if _MSC_VER is defined that it is >= 1310
      (ie VS7.1).
      
      This improves the readability of the code, and slightly
      improved code coverage.
      
      Change-Id: Iffc601f4cff53c4e267835e39b2b17a3adf74494
      de8eae2b
  16. 14 Mar, 2013 24 commits
    • Sean McBride's avatar
      Fixed various clang -Wundef warnings · 0b992282
      Sean McBride authored
      Use #ifdef instead of just #if to fix some -Wundef warnings.
      In most cases, this just makes things more consistent with
      existing code.
      
      Change-Id: I7aec13b54793de4e85eedcfe94cde83a147b217b
      0b992282
  17. 31 Aug, 2012 24 commits
  18. 19 Jul, 2012 24 commits
    • Bill Lorensen's avatar
      BUG: Modules missing membership in StandAlone or Rendering. · 453a2f95
      Bill Lorensen authored
      The StandAlone + Rendering groups should contain what was in VTK
      before modularization without turning on additional flags.
      
      The StandAlone group is a special group of all modules that need no
      external dependencies, such as Boost, MPI, etc. It does include
      modules that rely on third party libraries VTK can build (by
      default). It DOES NOT include modules that depend on OpenGL. Those
      modules are in the Rendering group.
      
      Several modules that meet the above criteria for membership in the
      StandAlone group did not specify their membership via the GROUPS
      StandAlone property. Also, several modules were missing from the
      Rendering group.
      
      This topic was verified by building the VTK Wiki Examples:
      http://www.vtk.org/Wiki/VTK/Examples/Cxx against an installed VTK that
      was built with only the StandAlone and Rendering properties enabled.
      
      Change-Id: I8bbca22f44c087b0cbe9ff92ee2819a292b43da5
      453a2f95
  19. 09 Apr, 2012 24 commits
    • VTK Developers's avatar
      Remove trailing whitespace from all source files · 2d323fc4
      VTK Developers authored
      Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
      are maintained outside VTK.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      2d323fc4
    • VTK Developers's avatar
      Include module-wide headers and export macros · 144f03ca
      VTK Developers authored
      Include the module-wide header from every header in each module.
      Reference the export/visibility macro for the module.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      144f03ca
    • VTK Developers's avatar
      Add modular VTK build system · 0c1471f1
      VTK Developers authored
      Add module.cmake, CMakeLists.txt, and other build system files.
      
      The modular VTK build system is not yet mature.  The monolithic build
      files had a lot of infrastructure.  The modular build files reproduce
      much of the functionality but some features will need to be restored
      later.  Document status and tasks in "TODO-Modularization.txt".
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      0c1471f1
    • VTK Developers's avatar
      Modularize VTK tree layout · cdd4d6fd
      VTK Developers authored
      Move source files from their former monolithic VTK location to their new
      location in modular VTK without modification.  This preserves enough
      information for "git blame -M" and "git log --follow" to connect
      modularized VTK files to their original location and history.
      
      Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
      Co-Author: Chris Harris <chris.harris@kitware.com>
      Co-Author: Brad King <brad.king@kitware.com>
      Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>
      cdd4d6fd