1. 28 Aug, 2020 1 commit
  2. 27 Aug, 2020 1 commit
    • David E. DeMarle's avatar
      add ways to precisely control the size of ospray implicits · 3ec16afc
      David E. DeMarle authored
      I've expanded the enablescaling boolean that used to choose
      between per actor or per point modes to include two new modes.
      The new modes do per actor per point scalar without any manipulation
      of the user provided values.
      
      This change is carefully backwards compatible.
      3ec16afc
  3. 21 Aug, 2020 1 commit
  4. 18 Aug, 2020 1 commit
  5. 13 Aug, 2020 1 commit
  6. 06 Aug, 2020 1 commit
  7. 05 Aug, 2020 1 commit
  8. 04 Aug, 2020 4 commits
  9. 27 Jul, 2020 1 commit
  10. 21 Jul, 2020 1 commit
  11. 20 Jul, 2020 2 commits
  12. 17 Jul, 2020 1 commit
  13. 15 Jul, 2020 1 commit
    • Paul Lafoix's avatar
      Handle anisotropy in the PBR shader · ba1c76b4
      Paul Lafoix authored
      Add two options to vtkProperty, and link them to OSPray:
      
      * anisotropy (between 0 and 1) that controls the strength of the anisotropy.
      It will be possible to use a texture to hold this value (WIP).
      
      * rotation (between 0 and 1) that rotate the direction of the anisotropy
      (ie. the tangent) around the normal counter-clockwise.
      A value of 1 correspond to a rotation of 2*PI. If needed, the rotation is done is
      the fragment shader because it allows the user to pass the rotaion as a
      texture value.
      ba1c76b4
  14. 10 Jul, 2020 3 commits
  15. 24 Jun, 2020 3 commits
    • David E. DeMarle's avatar
      clean up the tests · 15d7fd38
      David E. DeMarle authored
      I adjusted the lights test to reduce noise and better match
      original scivis appearance.
      
      Since we are on a new ospray major version now, I removed all
      of the alternate baseline images, many of which
      corresponded to long dead ospray minor versions.
      15d7fd38
    • David E. DeMarle's avatar
      converting molecule mapper to ospray 2 · 12644d1e
      David E. DeMarle authored
      Note that test is changed to path tracer because lower image
      quality with ospray 2's scivis renderer.
      12644d1e
    • David E. DeMarle's avatar
      update ray tracing for compatibility with OSPRay 2 · 2ad10f74
      David E. DeMarle authored
      This update allows us to access volumetric path tracing
      and other new features of OSPRay 2 in VTK.
      
      However, since OSPRay2's raycast or "scivis" renderer is
      simpler than before, we lose shadows and multiple
      and colored light sources, gradient shaded volumes and
      specular highlights in that context. The regression tests
      and baselines have been adjusted accordingly.
      
      This commit compresses a long development branch by
      Carson Brownlee and David DeMarle. A selection of the commit
      message are as follows:
      
      RayTracedMolecules will be restored in the next commit
      
      -
          style fixes for ospInit and ospShutdown call sites
      
          Returning ospShutdown resulted in segfaults in OpenVKL. So let's
          leave it as always on once started. VisRTX does the same and
          we've done it this way in earlier releases so it will probably
          be fine.
      -
          restore temporal caching
      
          New approach is to simply cache the entire scene instead of
          individual props.
      -
          Update the ospray isosurface baseline image.
      
          Comparing with GL shows that the new version is more similar to
          GL so it is valid.
      -
          compensate for lack of gradient shading in ospray2 vol rendering
      
          until ospray 2 gets diffuse volume shading, turn off shading and
          update baselines.
      -
          compensate for raycaster lighting limitations
      
          until ospray2 raycaster gets colored lights, switch these two
          tests over to pathtracer to make them happy.
      
          Also add a new alternate image for the lights test because
          path tracer is much brighter in corner than ray caster is.
      -
          update to ospray 2's revised material names
      
          To save a bit on runtime cost, we only provide backward
          compatibility at material library file parsing. In other words, user
          code that calls MakeMaterial() directly may have be updated.
      -
          changing ospray version number to 2.1
      -
          restructuring renderer to use list of instances instead of models.
      -
          adding isosurface material
      -
          using 3d data array for volume data
      -
          adding error logging.
      -
          adding volume anisotropy
      -
          intial commit of ospray 2.0 rendering code base.
      2ad10f74
  16. 22 Jun, 2020 1 commit
  17. 22 May, 2020 1 commit
  18. 06 May, 2020 3 commits
    • Sean McBride's avatar
      Corrected some slightly-wrong (70-90 char long) function separator comments · bd6903eb
      Sean McBride authored
      Used this script then manually reverted changes to ThirdParty and the like:
      
      find . -iname "*.cxx" -exec sed -i '' s:^//-----------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//----------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//---------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//--------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//-------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//-----------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//----------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//---------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//--------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//-------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//--------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//---------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//----------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//-----------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//-------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//--------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//---------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      
      find . -iname "*.cxx" -exec sed -i '' s:^//\ -----------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ----------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ---------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ --------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ -------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ -----------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ----------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ---------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ --------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ -------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ --------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ---------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ----------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ -----------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ -------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ --------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      find . -iname "*.cxx" -exec sed -i '' s:^//\ ---------------------------------------------------------------------------------------$:\/\/\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-\-:g {} +
      bd6903eb
    • Kitware Robot's avatar
      clang-format: do another sweep for the Cpp11 option · 1d403067
      Kitware Robot authored and Ben Boeckel's avatar Ben Boeckel committed
      1d403067
    • Aron Helser's avatar
      Fix compile error on VS2019 with ospray enabled. · 9a74228a
      Aron Helser authored
      Need #include <string>
      9a74228a
  19. 05 May, 2020 1 commit
  20. 29 Apr, 2020 1 commit
  21. 28 Apr, 2020 1 commit
  22. 22 Apr, 2020 1 commit
    • Hans Johnson's avatar
      STYLE: Prefer = default to explicitly trivial implementations · f118a65a
      Hans Johnson authored
      This check replaces default bodies of special member functions with
      = default;. The explicitly defaulted function declarations enable more
      opportunities in optimization, because the compiler might treat
      explicitly defaulted functions as trivial.
      
      Additionally, the C++11 use of = default more clearly expreses the
      intent for the special member functions.
      f118a65a
  23. 21 Apr, 2020 1 commit
    • Hans Johnson's avatar
      PERF: readability container size empty · 6baf8b35
      Hans Johnson authored
      The emptiness of a container should be checked using the empty() method
      instead of the size() method. It is not guaranteed that size() is a
      constant-time function, and it is generally more efficient and also
      shows clearer intent to use empty(). Furthermore some containers may
      implement the empty() method but not implement the size() method. Using
      empty() whenever possible makes it easier to switch to another container
      in the future.
      
      cd ${BLDDIR}
      run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,readability-container-size-empty  -header-filter=.* -fix
      6baf8b35
  24. 16 Apr, 2020 1 commit
    • Hans Johnson's avatar
      STYLE: Use override statements for C++11 · 898b4870
      Hans Johnson authored
      Describe function overrides using the override keyword from C++11.
      
      -----
      https://stackoverflow.com/questions/39932391/virtual-override-or-both-c
      When you override a function you don't technically need to write either virtual
      or override.
      
      The original base class declaration needs the keyword virtual to mark it as
      virtual.
      
      In the derived class the function is virtual by way of having the ¹same type as
      the base class function.
      
      However, an override can help avoid bugs by producing a compilation error when
      the intended override isn't technically an override. For instance, the function
      type isn't exactly like the base class function. Or that a maintenance of the
      base class changes that function's type, e.g. adding a defaulted argument.
      
      In the same way, a virtual keyword in the derived class can make such a bug
      more subtle by ensuring that the function is still virtual in the further
      derived classes.
      
      So the general advice is,
      
      Use virtual for the base class function declaration.  This is technically
      necessary.
      
      Use override (only) for a derived class' override.  This helps maintenance.
      -----
      
      Remove 'virtual' is implied when 'override' is specified, so remove the
      redundant specification.
      
      cd \${BLDDIR}
      run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-override  -header-filter=.* -fix
      898b4870
  25. 15 Apr, 2020 1 commit
  26. 06 Apr, 2020 1 commit
  27. 01 Apr, 2020 1 commit
  28. 27 Mar, 2020 1 commit
  29. 06 Mar, 2020 1 commit
  30. 04 Mar, 2020 1 commit
    • Ken Martin's avatar
      improve the performance of scene graphs · 8d45b7db
      Ken Martin authored
      Replace vtk collection with some more standard
      std containers. Update the algorithms for child
      management to be nlogn instead of n*n and to use
      lightweight iterators. The vtkCollectionIterator is
      horribly slow due to heap allocations, reference counting
      and destruction. The collection lightweight iterator is fine
      but really should move all collections to std::forward_list
      which is what they basically are.
      
      Add a couple methods to vtkMatrix4x4.h that are repeatedly
      used in rendering and are a bit faster.
      8d45b7db