GitLab

This tool warns where macros should be using parens.
Fixed many issues it pointed out by either:
 - adding parens (which it can do automatically)
 - removed unused (or rarely used) macros
 - replacing macros with functions, notably vtkMath stuff

1437ec79 Capture warning and error macro output
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1040

when testing for ogl support capture warning and error
output messages

999a964a Revert previous change which clear selected arrays at each ReqInfo
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !1036

d3d5f91f Python: stub out python GIL calls if no thread support
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Chuck Atkins <chuck.atkins@kitware.com>
Tested-by: Chuck Atkins <chuck.atkins@kitware.com>
Reviewed-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !1034

7ba44c33 Fix build issue when VTK_ENABLE_KITS is ON.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !1035

This is temporary fix for build issues introduced by 42cd4ce4 when
VTK_ENABLE_KITS is ON. We are reverting to old behavior when
VTK_ENABLE_KITS is ON.

This resolves linking errors when doing static cross-compile builds
against python with no thread support.

9d952e92 Fix memory leak in vtkMath::SolveLeastSquares.
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !1012

This fix is in reference to issue #2698. During the execution of method
vtkMath::SolveLeastSquares, if a matrix inversion failed then the method
would exit without dealocating locally allocated memory. This Fix corrects
this behavior.

Reviewed-by and Acked-by copied by hand due to a rebase.

Reviewed-by: @utkarsh.ayachit
Acked-by: @ben.boeckel
Acked-by: @robertmaynard

b4c8e91e Add user option to select a shared/static system JsonCpp library.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !994

410ced5b vtkCompositeSurfaceLICMapper: Add missing member initializers
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1030

88376dfb Fix crash of the WindowToImageFilter when specifying a Viewport.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !919

50bc89e4 New Win32 approach to SupportsOpenGL
e83bf68e Try to make the OpenGLSupport process better
8f2cea5c try a different approach
78fd576e better testing for opengl support
6d6cc259 fix so that it only frees the display when it created it
f5076346 try something to see if it fixes a pv issue
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1021

67e00720 ENH: Add text chunk read/write to PNG reader/writer
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Reviewed-by: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Merge-request: !902

8fe92274 Clear current cell/point selection arrays in RequestInformation
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Cory Quammen <cory.quammen@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !1015

The `LastOpaqueCheckTime` member in particular is used by `GetIsOpaque`
in a condition before being set and so must be initialized.  Otherwise
the condition may never be true and then the also-uninitialized value of
`LastOpaqueCheckValue` will be used, leading to unpredictable rendering.
Initialize all members to avoid such trouble.

42cd4ce4 Wrapping: Get preprocessor flags from CMake generator
f4af1aac Wrapping: Re-order wrapping parser flag construction
abef02e3 Wrapping: De-duplicate vtk_wrap_hierarchy argument file name
740809c4 Wrapping: Pass module name to vtk_wrap_hierarchy
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: David Gobbi <david.gobbi@gmail.com>
Merge-request: !1014

0584cc63 Threaded and implemented power parameter
91cd5140 Fixed interpolation for precise hits
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Berk Geveci <berk.geveci@kitware.com>
Merge-request: !1028

Add a test for this feature.

vtkShepardMethod has been threaded with vtkSMPTools. Also added
is the power parameter to control the interpolation basis.
Finally, a serious bug when distance==0 (between sample and
interpolated point) was fixed. Additional documentation was also
added into the mix.

66bbc5be Add hints for Center and Axis getters of ImplicitCylinderRepresentation
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Merge-request: !1027

a3d85c02 Merge branch 'upstream-KWSys' into update-kwsys
a36bf7c7 KWSys 2015-12-14 (c1149ef6)
893f3e2d ENH: Drop KWSys FundamentalType component
a6df084e Configure KWSys import script to add a `git shortlog`
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !1026

They are needed for ParaView integration of the Implicit cylinter widget.

Currently we explicitly construct a list of include directories and
compile definitions to pass to the wrapping parsers from module
variables.  With CMake 3.1 and above we can use `file(GENERATE)` and the
`$<TARGET_PROPERTY:...>` generator expression to get the
`INCLUDE_DIRECTORIES` and `COMPILE_DEFINITIONS` of the wrapped module
library at generate time from CMake.  This can actually be done in a few
earlier versions of CMake too but we need 3.1 to have a generator
expression in the `add_custom_command` `DEPENDS` option.

This approach avoids use of manually constructed lists of preprocessor
flags and always ensures that the wrapping parsers get the same
preprocessor flags as the compiler will get when compiling the module
library.  It will also allow us to get preprocessor flags through CMake
usage requirements (e.g. target_include_directories and
target_compile_definitions) for third-party system libraries.

Group preprocessor flags separately from hints and types flags.

Use a variable to hold the name of the arguments file.

The first argument of `vtk_wrap_hierarchy` was accidentally unused and
the `${vtk-module}` variable from the calling scope was used instead.
Clean this up by passing the module name as the first argument and
referencing it by that argument name.

d9d26ba4 Merge branch 'upstream-zlib' into zlib-soversion
1cbd9fde zlib 2015-12-14 (751703ae)
ea74dd0b zlib: remove zlib1.rc from the list of used files.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !1009

Do the x window type check on windows as well

36a816d1 Fix PUnstructuredGridGhostCellsGenerator so it does not modify input
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1024

Cache the result provide an API for a string message
Verify that a shader program compiles

* upstream-KWSys:
  KWSys 2015-12-14 (c1149ef6)

Code extracted from:

    http://public.kitware.com/KWSys.git

at commit c1149ef69956eab13221e05ffb2d9b5e55c2e3ee (master).

Upstream Shortlog
-----------------

Brad King (1):
      c1149ef6 Drop the FundamentalType.h component of KWSys

We have not used it in VTK for a long time.

17fa0866 vtkfreetype: Use KWIML for integer sizes
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1025

Since commit 54a3d8ed (Drop detection of type size information for VTK
at CMake time, 2015-12-04) the `VTK_SIZEOF_*` values are not available
at CMake time for configuration into header files.  Port use of them in
vtkfreetype over to KWIML macros instead.