1. 01 Mar, 2013 1 commit
    • Sean McBride's avatar
      Prevent writing of non-0/1 values into bool · 8e7375d3
      Sean McBride authored
      When running the test 'vtkCommonCoreTcl-TestSetGet',
      clang's -fsanitize=bool complained:
      
      runtime error: load of value 37, which is not a valid value for type 'bool'
      
      The code called resize() on an stl vector which ended up using the default
      constructor (which didn't initialize any ivars) and then subsequent new items
      (I think) were copied from this one prototype by
      IVFDataSetInfo::IVFDataSetInfo(const IVFDataSetInfo &ivfci)
      which then copied the randomly-initialized bool into another bool,
      and thus the error.  Fixed by zeroing everything in the default ctor.
      
      Change-Id: Icd1a8c1b6a6eb84b525048b0177910f2a7d2f855
      8e7375d3
  2. 27 Feb, 2013 1 commit
  3. 31 Jan, 2013 1 commit
  4. 25 Jan, 2013 2 commits
  5. 25 Oct, 2012 1 commit
    • Yuanxin Liu's avatar
      Fix parallel streakline filter bugs · 0e1ed9ee
      Yuanxin Liu authored
      vtkParticleTracerBase::PreviousOutputPointData needs to shallow copy
      OutputPointData instead of pointer-copy. This is fixed. It is also
      renamed to something better: ParticlePointData, with comments added.
      
      The "<" operator for StreakParticle needs to return false for
      equality. Otherwise, stl sort will crap out with memory corruption.
      
      Fixed a spurious warning
      
      Change-Id: I2e2c6aa1defab135fc6f9b5767ed7f03ba1bcc92
      0e1ed9ee
  6. 23 Oct, 2012 1 commit
    • Yuanxin Liu's avatar
      Further improve the previous fix. · 2d4a1f94
      Yuanxin Liu authored
      - Added a unit test.
      
      - The InPointData and OutPointData parameters for InterpolatePoint in
        the previous commit were backwards, even though they were used in
        the backward way so the results are correct. Fixed now.
      
      - Added an input check to see if the input contains mismatching data.
        This is to to preserve the efficiency for the common case.
      
      Change-Id: I2aa1326dc7e653a8a66e04b7d2c3ac645c048fb9
      2d4a1f94
  7. 17 Oct, 2012 1 commit
    • Andrew Bauer's avatar
      Fix potential problem with stream tracers for multiblocks. · 000bb46d
      Andrew Bauer authored
      Doing a special function to interpolate the point data
      from the input to the output
      it makes sure the array exists in the input before trying to copy it to the
      output. if it doesn't exist in the input but is in the output then we
      remove it from the output instead of having bad values there.
      this is meant for multiblock data sets where the grids may not have the
      same point data arrays or have them in different orders.
      
      Change-Id: Ieab40a7d33ef47d14780cdd8e194da42eabaf7e2
      000bb46d
  8. 05 Sep, 2012 2 commits
  9. 28 Aug, 2012 1 commit
  10. 27 Aug, 2012 1 commit
    • Yuanxin Liu's avatar
      particle tracing: fix test failures · de9a241b
      Yuanxin Liu authored
      - Guard against the boundary condition where the previous termination
        time is the last step in the time sequence.  Also add a test to make
        sure this works.
      
       - Fix a problem where iterator an empty stl list is decremented,
        which seems to happen on windows.
      
      Change-Id: I31821a421bf5b9e37dc581777c02f77661d1fae5
      de9a241b
  11. 24 Aug, 2012 2 commits
    • Yuanxin Liu's avatar
      vtkParticleTracerBase:: Improve functionality for coprocessing · 1a13b77f
      Yuanxin Liu authored
      1. Add a flag to disable this->ResetCache()
      2. Remove an unnecessary condition when advancing this->CurrentTimeStep.
         This condition causes extra time requests in a coprocessing work flow
      3. More graceful handling of the situation when there is only one time step
      4. Fixes a few warnings and stylistic issues.
      
      Change-Id: Id562c302a5e5503296a8787dc329607a9389eb18
      1a13b77f
    • Yuanxin Liu's avatar
      AMR classes: major data structure changes · 8fc6cf25
      Yuanxin Liu authored
      The main motivation for the changes is to improve the efficiency
      of AMR data structures by replacing the data set containers and meta
      data representation with new data structures.
      
      First, the meta data associated with the AMR data is moved from
      vtkInformation to a new class vtkAMRInformation so that they do not
      have to be deep copied. Related changes also include:
      
      - Before, when the LOAD_REQUESTED_BLOCKS() key is not set, the reader
        would recompute AMR meta data based on the requested blocks.  This
        is no longer done: meta data always represents what is on file.
        The reason is to avoid the sensitive meta data computation that
        depends on connectivitiy of the requested blocks.
      
      - Processor ranks are no longer stored in the meta data. Filters
        can easily generate them by using
        vtkAMRUtilities::DistributeProcessInformation
      
      - There used to be two types of 1D indices used to reference blocks in
        an AMR: vtkOverlappingAMR::GetFlatIndex and
        vtkOverlappingAMR::GetCompositeIndex. Now only the latter is used.
        The "other" 1D index is file type specific so now only the readers
        reference them (vtkAMRInformation::GetAMRBlockSourceIndex())
      
      - To make it easy to traversal the bounding boxes in the meta data. A
        new key vtkObject::BOUNDING_BOX() has been added that works with
        vtkOverlappingAMRDataIterator. See its use in vtkCompositeCutter for
        an example.
      
      - In a multiprocess setting, vtkAMRSliceFilter for each process computes
        the complete meta data to avoid communication
      
      - Many functions in vtkAMRUtilities are removed because they provide
        support for computing meta data from data sets. In the new design,
        meta information is always created before data sets are constructed.
      
      Second, VtkUniformGridAMR now use a more compact representation of the grid
      blocks than the tree implementation done previously. To facilicate
      this, vtkCompositeDataSet now becomes a fully abstract class and all
      concrete implementation gest pushed to the class vtkDataObjectTree.
      In the new implementation, the non-null blocks are stored in an stl
      vector. So traversing them (using vtkUniformGridAMRDataIterator) is
      efficient.
      - The AMRBox has been reduced to store only the lower and upper
        corners.  Information such as origin and spacing are moved to the
        container class vtkAMRInformation, since they are often common to
        all boxes or boxes on the same level.
      
      - File reoganization: - AMR File readers are moved from Filters/AMR to
        IO/AMR - AMR algorithms (vtk*AMR*Algorithm) are moved from
        Filters/General to Common/ExecutionModel
      
      Finally, tkAMRVolumeWrapper is moved from filters to rendering.
      The dependency on vtkAMRResampler and vtkParallelCore makes it
      difficult for it go to Rendering/Volume so a new module
      Rendering/VolumeAMR is created.
      
      Change-Id: Id73d214e6a5ac4d4a08fde5d979365f46edfa390
      8fc6cf25
  12. 15 Aug, 2012 1 commit
    • Yuanxin Liu's avatar
      vtkParticlePathFilter:: Fix compiler warning · 5b859ba5
      Yuanxin Liu authored
      Converting asserts to error macros.
      Also disable the user of asserts in vtkStreaklineFilter to avoid
      similar problems in the future.
      
      Change-Id: I1e2fa1c2cdd9acf23554f9bed18d7bad73c13895
      5b859ba5
  13. 13 Aug, 2012 3 commits
  14. 24 Jul, 2012 1 commit
    • Yuanxin Liu's avatar
      Add seed points to streak lines · 6d773a3d
      Yuanxin Liu authored
      Previous implementation of streak lines do not include seed points.
      These seed points are now included by injecting them at the last
      step of the particle tracing loop.
      
      Change-Id: Ie00c0bc8c70b01a5b9ba67d676ca686fd0d6df16
      6d773a3d
  15. 10 Jun, 2012 1 commit
  16. 08 Jun, 2012 1 commit
  17. 01 Jun, 2012 1 commit