1. 01 Mar, 2013 2 commits
    • Sean McBride's avatar
      Prevent writing of non-0/1 values into bool · 8e7375d3
      Sean McBride authored
      When running the test 'vtkCommonCoreTcl-TestSetGet',
      clang's -fsanitize=bool complained:
      
      runtime error: load of value 37, which is not a valid value for type 'bool'
      
      The code called resize() on an stl vector which ended up using the default
      constructor (which didn't initialize any ivars) and then subsequent new items
      (I think) were copied from this one prototype by
      IVFDataSetInfo::IVFDataSetInfo(const IVFDataSetInfo &ivfci)
      which then copied the randomly-initialized bool into another bool,
      and thus the error.  Fixed by zeroing everything in the default ctor.
      
      Change-Id: Icd1a8c1b6a6eb84b525048b0177910f2a7d2f855
      8e7375d3
    • Bill Lorensen's avatar
      COMP: Precision issues · 5fd5b667
      Bill Lorensen authored
      The original test was failing on one platform: AIX.
      Change the test to have coordinates that can be represented exactly in
      IEEE FP.
      See if this helps.
      
      Change-Id: Ibf6d5472e9c3b42cc858cfe92ea5c415085ff716
      5fd5b667
  2. 28 Feb, 2013 1 commit
    • Bill Lorensen's avatar
      COMP: Remove redundant test and unify tolerances · ca880016
      Bill Lorensen authored and David Gobbi's avatar David Gobbi committed
      TestParametricFunctions.py existed in two modules. The version in
      Filters/Sources used random numbers to populate the splines. This was
      undesirable for producing consistent results across platforms.
      
      The version in Common/ComputationalGeometry uses explicit points and
      matches the points in the corresponding .tcl test.
      
      Also, the .tcl and .py tests had different image tolerances. This
      patch unifies those tolerances.
      
      There are currently four baselines for these tests. Once merged, we
      will remove all of the alternate baselines.
      
      Change-Id: Ie09a6a27e0856596fcda2df7cec2d11ee279ed78
      ca880016
  3. 27 Feb, 2013 4 commits
  4. 24 Feb, 2013 1 commit
    • Bill Lorensen's avatar
      COMP: Add Render after animation loop · 4f99d550
      Bill Lorensen authored
      These 3 tests all have animation loops and fail mysteriously on some
      platforms. The patch adds an extra Render after the animation loop. If
      this patch resolves the problem, there may be issues with the testing
      framework for tcl and python.
      
      Change-Id: I7b438b466522c52da8017ce388a84f1affe90e93
      4f99d550
  5. 19 Feb, 2013 1 commit
  6. 15 Feb, 2013 1 commit
    • Bill Lorensen's avatar
      ENH: Tcl tests should not fail if VTK_DATA_ROOT is missing. · c5ab6fda
      Bill Lorensen authored
      A test should run without VTK_DATA_ROOT unless it needs input data
      from VTK_DATA_ROOT. Tests that have image baselines should still run
      unless they need input data.
      
      rtImage.tcl is modified to skip baseline comparisons if VTK_DATA_ROOT
      is not defined.
      
      CMakeLists.txt files are converted to use add_test_tcl macro for
      consistency.
      
      CMakeLists.txt files are changed to isolate tests that need input
      data.
      
      This was tested as follows:
      1) configured a build with VTK_DATA_ROOT undefine
         ctest -R Tcl-
         154 tests passed
      2) configured a build with VTK_DATA_ROOT defined
         ctest -R Tcl-
         390 tests passed
      
      This means that 390-154 = 236 tcl tests require input data
      
      Change-Id: I9067a3e3e2a710ddf353f0181cc7b22a85b5ef10
      c5ab6fda
  7. 13 Feb, 2013 2 commits
    • Bill Lorensen's avatar
      ENH: CXX tests should not fail if VTK_DATA_ROOT is missing. · eb4be53c
      Bill Lorensen authored
      The vtkTestingInteractor was trying to run regression tests even if
      VTK_DATA_ROOT was not defined.
      
      Many Testing/Cxx CMakeLists.txt files tried to run tests that required
      input data, even though VTK_DATA_ROOT was not defined.
      
      Subsequent topics will address Tcl and Python tests.
      
      Change-Id: Iabf242f9f498ce044948ca1d4a29378b76ceb21d
      eb4be53c
    • Zack Galbreath's avatar
      Fix memory leak when getting a tree from RCalculatorFilter's output · 3fee36a7
      Zack Galbreath authored
      This commit updates vtkRAdapter::RToVTKTree() to match the memory
      management strategy used in vtkRAdapter::RToVTKTable().  This commit
      also removes the deletion of the vtkTree in TestRInterface, as this
      is rendered inappropriate by the previously mentioned change.
      
      Change-Id: I764c9d28199d7b5421383947567cd37a93dbdec3
      3fee36a7
  8. 12 Feb, 2013 1 commit
    • Robert Maynard's avatar
      Correct incorrectly calculating min and max cell for each piece. · 8a73bfeb
      Robert Maynard authored
      Previously we incorrectly calculated the min and max cell
      for each piece if we had less cells that pieces. This was
      caused by using integer division instead of float division.
      
      Also I correct the issue that if we have zero cells we would
      divide by zero causing VTK to crash.
      
      Change-Id: Id7f99dfa0b6b85727f326a38c62ada16af8a51ac
      8a73bfeb
  9. 11 Feb, 2013 1 commit
  10. 10 Feb, 2013 2 commits
  11. 06 Feb, 2013 3 commits
    • Andrew Maclean's avatar
      Fix MeshQuality Python test. · 57d4214c
      Andrew Maclean authored
      
      
      A new python version called MeshQuality.py has been
       written, it is based on MeshQuality.cxx.
      
      The old meshQuality.py has been deleted.
      
      The new version tests mesh quality more thoroughly than
       the old version and produces the same output
       as MeshQuality.cxx.
      
      Change-Id: I8b98a24d2dbb2721ea6a32ba614835c75caeb873
      Signed-off-by: Andrew Maclean's avatarAndrew Maclean <andrew.amaclean@gmail.com>
      57d4214c
    • Bill Lorensen's avatar
      COMP: Regression test failures on some platforms · b17fead8
      Bill Lorensen authored
      Some windows and linux systems fail the regression tests by minor
      amounts. This patch specifies a larger image tolerance.
      
      In particular, the VTK continuous build has a recurring regression
      failure for one of these tests. With the increased tolerance, the test
      passes.
      
      Tolerances were set so that the tests pass on a Fedora/Mesa system and
      were verified on a Fedora/OpenGL system.
      
      Change-Id: Ibf59e01f67e171050411b19ca70041b7b478a1fe
      b17fead8
    • Bill Lorensen's avatar
      COMP: Uninitialized memory reads · 5c851441
      Bill Lorensen authored
      Running the otherPrint test with valgrind uncovered several
      uninitialized memory read defects
      
      Change-Id: I31779489cca5aef2b250f6793254fa61c387aa7a
      5c851441
  12. 03 Feb, 2013 2 commits
  13. 01 Feb, 2013 3 commits
    • David Gobbi's avatar
      Regenerate meshQuality.py from the more complete meshQuality.cxx · e47635fa
      David Gobbi authored
      Change-Id: I54388b3d367ac9ef3778442d3cf33c111f21c948
      e47635fa
    • Bill Lorensen's avatar
      COMP: Tests that require numpy should warn if numpy is missing · 29b6a7f3
      Bill Lorensen authored
      Python tests that use require numpy should warn and not fail if numpy
      is missing.
      
      Change-Id: I99def5001c2a000276f4164f3bcc8fed1d309587
      29b6a7f3
    • Bill Lorensen's avatar
      COMP: Python tests missing -D argument · 808ad105
      Bill Lorensen authored
      These python tests are missing the -D argument. The macros
      add_test_python and add_test_python1 only generate the -D argument if
      a second argument is provided to the macro. Usually, the second
      argment is the regression baseline directory. Although these tests do
      not have a baseline inage, they do require access to VTK_DATA_ROOT.
      
      This patch adds a second argument to the macro, which causes the
      python test macros to generate a proper -D argument for the test.
      
      NOTE: The content of the argument is not used. Its presence alone
      causes the macros to generate a proper -D argument for the test.
      
      Change-Id: Iec5ccf52a8124212bddb1cfc4cac0f43f6d0f5d8
      808ad105
  14. 31 Jan, 2013 3 commits
    • Bill Lorensen's avatar
      ENH: Convert tests to new testing framework · 3ac4b2fb
      Bill Lorensen authored
      Converted tests to use the vtkTestingObjectFactory.
      1) The explicit regression testing was removed from each test.
      2) Error tolerance can be specified on the add_test command.
      
      A number of style issues were also addressed:
      
      1) Converted cout, cerr, endl to std::cout, std::cerr, std::endl.
      2) Where appropriate used SmartPointer's.
      3) Replaced "return 0/1" with "return EXIT_SUCCESS/EXIT_FAILURE"
      
      Change-Id: If0fcd3ce3d849cf17e239ac9f7a7788adbe93a46
      3ac4b2fb
    • Sean McBride's avatar
      COMP: fixed warnings issued by clang's -Wdocumentation · 0f9b3d07
      Sean McBride authored
      Change-Id: I323fae1a6b9c6221c773c0d7c4813ed7a4e58ea1
      0f9b3d07
    • Bill Lorensen's avatar
      COMP: Adjust error threshold for TestDensifyPolyData · 9abd425f
      Bill Lorensen authored
      Some platforms report image errors with small differences. Here we
      increase the error threshold for TestDensifyPolyData. Also, the
      CMakeLists.txt file is instrumented to allow easy addition of new
      error thresholds.
      
      Converted TestDensifyPolyData to use the new testing framework. This
      permits error tolerances to be specified in the CMakeLists.txt file
      rather than hard coded in the test.
      
      Change-Id: I7759465def406ccd0f761e3e478dd754806e084e
      9abd425f
  15. 30 Jan, 2013 1 commit
  16. 29 Jan, 2013 2 commits
  17. 28 Jan, 2013 1 commit
  18. 25 Jan, 2013 6 commits
  19. 24 Jan, 2013 3 commits