GitLab

Addresses paraview/paraview#18302.

If the gradient filter is operating on an unstructured grid and
the gradient wasn't requested but other quantities derived from
the gradient was requested there was a segfault in referring to
the gradient array.

Found via `codespell` and regex

If the vtkGradientFilter is used over a composite dataset with
the selected array not being available on all non-empty composite
dataset blocks the vtkGradientFilter will return an error for
those blocks. The error message when that happens is now improved
to let users know that the error may be the result of the missing
arrays.

Addresses paraview/paraview#17551.

Adding in functionality to allow inserting vtkNew objects into
stl containers of vtkSmartPointer objects as well as comparisons
between vtkNew objects and raw pointers. Also removing Get() and
GetPointer() calls from vtkNew objects since in most instances we
can just pass in the vtkNew<> object instead of having to use the
Get() or GetPointer() methods to get the raw pointer.

The cell dimension for unstructured grids and polydata can vary. These changes allow
specifying the cell dimensions to use when performing the computations. The default
behavior should be exactly the same as before. Also getting rid of the GetVoidPointer()
calls on the input array. Using them on the output array should be fine though since
the arrays are explicitly created with the AOS layout. Also, simplified the
Q-criterion computation. This modification also makes the output arrays be either
vtkFloatArrays or vtkDoubleArrays.

Addresses paraview/paraview#16931.

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

Making gradients output optional since that may not be needed
and can require a lot of memory for topologically structured
grids. Also adding in divergence option.

Co-authored-by: Yuanxin Liu <leo.liu@kitware.com>
Co-authored-by: Berk Geveci <berk.geveci@kitware.com>

 -The semantics of each unsigned char in the ghost arrays changes:
  Instead of storing a numeric value representing how far a cell is
  from the boundary, it is now a bit field specified by
  vtkDataSetAttributes::CellGhostTypes and
  vtkDataSetAttributes::PointGhostTypes.  The bit field is consistent
  with VisIt specs.

- Previously, filters strip all ghost cells they request from upstream
  before finalizing the output. This is no longer done.

- vtkUniform grids previously supported blanking through member arrays
  vtkUniformGrid::CellVisibility and
  vtkUniformGrid::PointVisibility. These arrays are removed and the
  blanking functionality are supported through the new ghost arrays
  instead.

- the "vtkGhostLevel" arrays for cell and point data are renamed to
  vtkDataSetAttributes::GhostArrayName() ("vtkGhostType").

- the version for VTK Legacy files is increased to 4.0 and the version for
  VTK XML files is increased to 2.0. When reading older files we
  convert vtkGhostLevels array to vtkGhostType.

Change-Id: I7f24245fcebe8949d8028a15a85254970c42dbd9

-Use bool instead of int.
-Move declarations and initial definitions together

Change-Id: I4874984b7f76b141cd3d1f8078b536c129dcc136

This fixes a "Conditional jump or move depends on uninitialised
value(s)" error from valgrind by zero initializing the values at
the top of ComputeGradientsSG().

Change-Id: Idfc249ed797c798a9bd79ece2883ca48d9735afb

Change-Id: I96a87b82ad4db6fe57cafbc1881575538474f084

Change-Id: I3b6363a94342ea57aa150561ae5614c70060754d

This fixes a windows only test failure (TestAMRInterpolatedVelocityField)
Also fixes some header issue in TestPStreamAMR.cxx.

Change-Id: I2bade8ee66287eee916b038542f33e270b2b4257

If the input field was a vector field (i.e. had 3 components) and
if ComputeVorticity was set, the output would be the vorticity
INSTEAD of the gradient. If ComputeQCriterion was set, this was output
as a separate field. Changed it so that ComputeVorticity is output
as a separate field now as well. Also each of the outputted fields
can have their names set.

Change-Id: Ia7d85a8e1706561311aeaed7aded9d0a2d36fc41

Change-Id: Ic2ffcfdb91c31e40ed3b0a22a08a504dd50136b7

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

This fixes a number of misspellings in the comments of
the source files in VTK/Graphics. The misspellings were
found using the codespell tool.

Change-Id: I199a88b6ddcc7924f6c1063bcf60fa556a4c62aa

Change-Id: Ib5a08d39907f2d2190a719333a838bbd41be75b7

Since the behaviour of SetInput changed - it no
longer connects the pipeline but sets up the data
object as the input -, it was decided to rename
it to SetInputData. This includes similar methods
such as AddInputData. This commit makes on
sweeping change that compiles.

Change-Id: I9ff08c32a604cb95d3c64ee9d9963d8dc335941c

Change-Id: I88b47c95a04c15ebe242dc289b6f5bc27540e150

Fixed the compiler warning and error from a previous commit.
Stupid windows VS10 compiler apparently doesn't like :: to refer to
objects in the anonymous namespace.

Change-Id: I1b3b8638b0f4b641f7c518c8b226dfa1a31f118e

The vtkGradientFilter has been modified to also have
the option of computing Q criterion which is a
comparison of vorticity and shear which is useful
in CFD.

Change-Id: If0a86651fe37057c7bc1069382b008979c3b3f64

Fixed the compiler warning and error from a previous commit.
Stupid windows VS10 compiler apparently doesn't like :: to refer to
objects in the anonymous namespace.

Change-Id: I1b3b8638b0f4b641f7c518c8b226dfa1a31f118e

The vtkGradientFilter has been modified to also have
the option of computing Q criterion which is a
comparison of vorticity and shear which is useful
in CFD.

Change-Id: If0a86651fe37057c7bc1069382b008979c3b3f64

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

ENH: Adding the functionality to compute vorticity/curl for a 3 component vector with the vtkGradientFilter.  Also adding tests for doing this as well as computing gradients for non-scalar arrays (i.e. arrays with number of components greater than 1).

ENH: Adding functionality so that the filter can deal with non-scalar field data.  Also improved performance and accuracy by specializing for topologically uniform grids.

COMP:Temporarily revert back good fix for warning to see which gcc flag triggers the warning. I will put the fix back again tomorrow.

PERF: Make the check for degernate cells, which was taking about half the time for point-based gradients, be much faster.