GitLab

For now, vtkTypeBool is just a typedef for int, but one day it can become a real bool.

Found with a regex:

vtkBooleanMacro.*int\)

Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
wrap =delete;

Now that VTK requires a C++11 compiler we can ditch using custom typedefs

I used perl regex to find any groups that spanned a protected: or
private: access specifier.

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

Include the module-wide header from every header in each module.
Reference the export/visibility macro for the module.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

Enhance test script to better test both algorithms

of a vtkPolyData input.
Thanks to Philip Batchelor philipp.batchelor@kcl.ac.uk for creating and
contributing the class and Andrew Maclean a.maclean@acfr.usyd.edu.au
for cleanups and fixes