Skip to content
GitLab
Commit ad641f4a authored by Brian Wylie's avatar Brian Wylie
Browse files

BUG: Add a 10% boundary to the bit array used in 'ResolveCoincidentPoints'.... 

BUG: Add a 10% boundary to the bit array used in 'ResolveCoincidentPoints'. This may resolve a heap corruption bug. Not absolutely sure, but certainly having the boundary is better than not having it.
parent d93b5d03
Hide whitespace changes
Inline Side-by-side
Infovis/vtkClustering2DLayoutStrategy.cxx
View file @ ad641f4a
......@@ -37,7 +37,7 @@
#include "vtkFastSplatter.h"
#include "vtkImageData.h"
vtkCxxRevisionMacro(vtkClustering2DLayoutStrategy, "1.10");
vtkCxxRevisionMacro(vtkClustering2DLayoutStrategy, "1.11");
vtkStandardNewMacro(vtkClustering2DLayoutStrategy);
// This is just a convenient macro for smart pointers
......@@ -535,8 +535,16 @@ void vtkClustering2DLayoutStrategy::ResolveCoincidentVertices()
giantGrid->SetValue(i, 0);
}
double bounds[6];
double bounds[6], paddedBounds[6];
this->Graph->GetBounds(bounds);
// Give bounds a 10% padding
paddedBounds[0] = bounds[0] - (bounds[1]-bounds[0])*.1;
paddedBounds[1] = bounds[1] + (bounds[1]-bounds[0])*.1;
paddedBounds[2] = bounds[2] - (bounds[3]-bounds[2])*.1;
paddedBounds[3] = bounds[3] + (bounds[3]-bounds[2])*.1;
paddedBounds[4] = paddedBounds[5] = 0;
int totalCollisionOps = 0;
for(vtkIdType i=0; i<numVertices; ++i)
......@@ -545,11 +553,11 @@ void vtkClustering2DLayoutStrategy::ResolveCoincidentVertices()
// Compute indices into the buckets
int indexX = static_cast<int>(
(rawPointData[rawIndex]-bounds[0]) /
(bounds[1]-bounds[0]) * (xDim-1) + .5);
(rawPointData[rawIndex]-paddedBounds[0]) /
(paddedBounds[1]-paddedBounds[0]) * (xDim-1) + .5);
int indexY = static_cast<int>(
(rawPointData[rawIndex+1]-bounds[2]) /
(bounds[3]-bounds[2]) * (yDim-1) + .5);
(rawPointData[rawIndex+1]-paddedBounds[2]) /
(paddedBounds[3]-paddedBounds[2]) * (yDim-1) + .5);
// See if you collide with another vertex
if (giantGrid->GetValue(indexX + indexY*xDim))
......@@ -559,7 +567,7 @@ void vtkClustering2DLayoutStrategy::ResolveCoincidentVertices()
// by randomly jumping to a place that doesn't
// have another vertex
bool collision = true;
float jumpDistance = 5.0*(bounds[1]-bounds[0])/xDim; // 2.5 grid spaces max
float jumpDistance = 5.0*(paddedBounds[1]-paddedBounds[0])/xDim; // 2.5 grid spaces max
int collisionOps = 0;
// You get 10 trys and then we have to punt
......@@ -573,11 +581,11 @@ void vtkClustering2DLayoutStrategy::ResolveCoincidentVertices()
// Test
indexX = static_cast<int>(
(rawPointData[rawIndex]-bounds[0]) /
(bounds[1]-bounds[0]) * (xDim-1) + .5);
(rawPointData[rawIndex]-paddedBounds[0]) /
(paddedBounds[1]-paddedBounds[0]) * (xDim-1) + .5);
indexY = static_cast<int>(
(rawPointData[rawIndex+1]-bounds[2]) /
(bounds[3]-bounds[2]) * (yDim-1) + .5);
(rawPointData[rawIndex+1]-paddedBounds[2]) /
(paddedBounds[3]-paddedBounds[2]) * (yDim-1) + .5);
if (!giantGrid->GetValue(indexX + indexY*xDim))
{
collision = false; // yea
......@@ -591,6 +599,7 @@ void vtkClustering2DLayoutStrategy::ResolveCoincidentVertices()
}
// Delete giantGrid
giantGrid->Initialize();
giantGrid->Delete();
// Report number of collision operations just for sanity check
......
Infovis/vtkCommunity2DLayoutStrategy.cxx
View file @ ad641f4a
......@@ -38,7 +38,7 @@
#include "vtkFastSplatter.h"
#include "vtkImageData.h"
vtkCxxRevisionMacro(vtkCommunity2DLayoutStrategy, "1.6");
vtkCxxRevisionMacro(vtkCommunity2DLayoutStrategy, "1.7");
vtkStandardNewMacro(vtkCommunity2DLayoutStrategy);
// This is just a convenient macro for smart pointers
......@@ -535,8 +535,16 @@ void vtkCommunity2DLayoutStrategy::ResolveCoincidentVertices()
giantGrid->SetValue(i, 0);
}
double bounds[6];
double bounds[6], paddedBounds[6];
this->Graph->GetBounds(bounds);
// Give bounds a 10% padding
paddedBounds[0] = bounds[0] - (bounds[1]-bounds[0])*.1;
paddedBounds[1] = bounds[1] + (bounds[1]-bounds[0])*.1;
paddedBounds[2] = bounds[2] - (bounds[3]-bounds[2])*.1;
paddedBounds[3] = bounds[3] + (bounds[3]-bounds[2])*.1;
paddedBounds[4] = paddedBounds[5] = 0;
int totalCollisionOps = 0;
for(vtkIdType i=0; i<numVertices; ++i)
......@@ -545,11 +553,11 @@ void vtkCommunity2DLayoutStrategy::ResolveCoincidentVertices()
// Compute indices into the buckets
int indexX = static_cast<int>(
(rawPointData[rawIndex]-bounds[0]) /
(bounds[1]-bounds[0]) * (xDim-1) + .5);
(rawPointData[rawIndex]-paddedBounds[0]) /
(paddedBounds[1]-paddedBounds[0]) * (xDim-1) + .5);
int indexY = static_cast<int>(
(rawPointData[rawIndex+1]-bounds[2]) /
(bounds[3]-bounds[2]) * (yDim-1) + .5);
(rawPointData[rawIndex+1]-paddedBounds[2]) /
(paddedBounds[3]-paddedBounds[2]) * (yDim-1) + .5);
// See if you collide with another vertex
if (giantGrid->GetValue(indexX + indexY*xDim))
......@@ -559,7 +567,7 @@ void vtkCommunity2DLayoutStrategy::ResolveCoincidentVertices()
// by randomly jumping to a place that doesn't
// have another vertex
bool collision = true;
float jumpDistance = 5.0*(bounds[1]-bounds[0])/xDim; // 2.5 grid spaces max
float jumpDistance = 5.0*(paddedBounds[1]-paddedBounds[0])/xDim; // 2.5 grid spaces max
int collisionOps = 0;
// You get 10 trys and then we have to punt
......@@ -573,11 +581,11 @@ void vtkCommunity2DLayoutStrategy::ResolveCoincidentVertices()
// Test
indexX = static_cast<int>(
(rawPointData[rawIndex]-bounds[0]) /
(bounds[1]-bounds[0]) * (xDim-1) + .5);
(rawPointData[rawIndex]-paddedBounds[0]) /
(paddedBounds[1]-paddedBounds[0]) * (xDim-1) + .5);
indexY = static_cast<int>(
(rawPointData[rawIndex+1]-bounds[2]) /
(bounds[3]-bounds[2]) * (yDim-1) + .5);
(rawPointData[rawIndex+1]-paddedBounds[2]) /
(paddedBounds[3]-paddedBounds[2]) * (yDim-1) + .5);
if (!giantGrid->GetValue(indexX + indexY*xDim))
{
collision = false; // yea
......
Infovis/vtkConstrained2DLayoutStrategy.h
View file @ ad641f4a
......@@ -17,7 +17,7 @@
See Copyright.txt or http://www.paraview.org/HTML/Copyright.html for details.
----------------------------------------------------------------------------*/
// .NAME vtkConstrained2DLayoutStrategy - a simple fast 2D graph layout
// that looks for a 'constraint' array (vtkFloatArray). Any entry in the
// that looks for a 'constraint' array (vtkDoubleArray). Any entry in the
// constraint array will indicate the level of impedence a node has to
// the force calculations during the layout optimization. The array is
// assumed to be normalized between zero and one, with one being totally
......
Infovis/vtkFast2DLayoutStrategy.cxx
View file @ ad641f4a
......@@ -37,7 +37,7 @@
#include "vtkFastSplatter.h"
#include "vtkImageData.h"
vtkCxxRevisionMacro(vtkFast2DLayoutStrategy, "1.16");
vtkCxxRevisionMacro(vtkFast2DLayoutStrategy, "1.17");
vtkStandardNewMacro(vtkFast2DLayoutStrategy);
// This is just a convenient macro for smart pointers
......@@ -483,8 +483,16 @@ void vtkFast2DLayoutStrategy::ResolveCoincidentVertices()
giantGrid->SetValue(i, 0);
}
double bounds[6];
double bounds[6], paddedBounds[6];
this->Graph->GetBounds(bounds);
// Give bounds a 10% padding
paddedBounds[0] = bounds[0] - (bounds[1]-bounds[0])*.1;
paddedBounds[1] = bounds[1] + (bounds[1]-bounds[0])*.1;
paddedBounds[2] = bounds[2] - (bounds[3]-bounds[2])*.1;
paddedBounds[3] = bounds[3] + (bounds[3]-bounds[2])*.1;
paddedBounds[4] = paddedBounds[5] = 0;
int totalCollisionOps = 0;
for(vtkIdType i=0; i<numVertices; ++i)
......@@ -493,11 +501,11 @@ void vtkFast2DLayoutStrategy::ResolveCoincidentVertices()
// Compute indices into the buckets
int indexX = static_cast<int>(
(rawPointData[rawIndex]-bounds[0]) /
(bounds[1]-bounds[0]) * (xDim-1) + .5);
(rawPointData[rawIndex]-paddedBounds[0]) /
(paddedBounds[1]-paddedBounds[0]) * (xDim-1) + .5);
int indexY = static_cast<int>(
(rawPointData[rawIndex+1]-bounds[2]) /
(bounds[3]-bounds[2]) * (yDim-1) + .5);
(rawPointData[rawIndex+1]-paddedBounds[2]) /
(paddedBounds[3]-paddedBounds[2]) * (yDim-1) + .5);
// See if you collide with another vertex
if (giantGrid->GetValue(indexX + indexY*xDim))
......@@ -507,7 +515,7 @@ void vtkFast2DLayoutStrategy::ResolveCoincidentVertices()
// by randomly jumping to a place that doesn't
// have another vertex
bool collision = true;
float jumpDistance = 5.0*(bounds[1]-bounds[0])/xDim; // 2.5 grid spaces max
float jumpDistance = 5.0*(paddedBounds[1]-paddedBounds[0])/xDim; // 2.5 grid spaces max
int collisionOps = 0;
// You get 10 trys and then we have to punt
......@@ -521,11 +529,11 @@ void vtkFast2DLayoutStrategy::ResolveCoincidentVertices()
// Test
indexX = static_cast<int>(
(rawPointData[rawIndex]-bounds[0]) /
(bounds[1]-bounds[0]) * (xDim-1) + .5);
(rawPointData[rawIndex]-paddedBounds[0]) /
(paddedBounds[1]-paddedBounds[0]) * (xDim-1) + .5);
indexY = static_cast<int>(
(rawPointData[rawIndex+1]-bounds[2]) /
(bounds[3]-bounds[2]) * (yDim-1) + .5);
(rawPointData[rawIndex+1]-paddedBounds[2]) /
(paddedBounds[3]-paddedBounds[2]) * (yDim-1) + .5);
if (!giantGrid->GetValue(indexX + indexY*xDim))
{
collision = false; // yea
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment