Fixed misc cppcheck warnings:

- warning about not rethrowing
- added extra parens
- warning about iterator misuse
- unused variable

Common/DataModel/Testing/Cxx/quadraticIntersection.cxx

@@ -157,8 +157,7 @@ void IntersectWithCell(unsigned nTest,
 
 int TestIntersectWithLine(int argc, char* argv[])
 {
-  std::ostringstream vtkmsg_with_warning_C4701;
-  ostream& strm = vtkmsg_with_warning_C4701;
+  std::ostringstream strm;
   strm << "Test vtkCell::IntersectWithLine Start" << endl;
 
   vtkSmartPointer<vtkRenderWindow> renderWindow =

IO/AMR/vtkAMRDataSetCache.cxx

@@ -38,7 +38,6 @@ vtkAMRDataSetCache::~vtkAMRDataSetCache()
       {
       iter->second->Delete();
       }
-    this->Cache.erase( iter );
     }
 }
 

IO/Core/vtkUTF8TextCodec.cxx

@@ -106,7 +106,7 @@ void vtkUTF8TextCodec::ToUnicode(istream& InputStream,
       }
     else
       {
-      throw ef;
+      throw;
       }
     }
 }

Imaging/Core/Testing/Cxx/TestImageStencilIterator.cxx

@@ -121,7 +121,7 @@ static bool CheckStencilExtents(
           j >= stencilExt[2] && j <= stencilExt[3] &&
           k >= stencilExt[4] && k <= stencilExt[5])
         {
-        match &= !inside ^ (*p > 127);
+        match &= (!inside) ^ (*p > 127);
         }
       else
         {